All of lore.kernel.org
 help / color / mirror / Atom feed
From: svenkatr@ti.com (S, Venkatraman)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH] arm: fiq: convert enable/disable_fiq to inline functions
Date: Mon, 29 Aug 2011 21:49:25 +0530	[thread overview]
Message-ID: <CANfBPZ-MbHP8zAqmi3m6=PjSkvBeWO=H18B+ALZToeHrQdbcfw@mail.gmail.com> (raw)
In-Reply-To: <alpine.LFD.2.00.1108291112010.20358@xanadu.home>

On Mon, Aug 29, 2011 at 8:44 PM, Nicolas Pitre <nicolas.pitre@linaro.org> wrote:
> On Mon, 29 Aug 2011, Venkatraman S wrote:
>
>> FIQ_START is an platform specific constant used in the
>> implementation of enable_fiq and disable_fiq.
>> Converting then to inline functions enables different
>> architectures which use the FIQ module to exist in a single
>> zImage with different values of FIQ_START.
>>
>> Signed-off-by: Venkatraman S <svenkatr@ti.com>
>
> I fail to see how this patch inproves things. The asm/fiq.h file is just
> as global as kernel/fiq.c is.
>

Argh!! I intended this to be a macro like this
#define enable_fiq(x)  enable_irq((x) + FIQ_START)
so that the constant is needed only at places where it is expanded.

This way different platforms can have their local irqs.h supply the constant,
where the macros are used.

Somehow I thought inline functions are more readable and assumed the
same macro'ish behaviour.

Will a macro variant of this be more useful ?

Thanks,
Venkat.

  reply	other threads:[~2011-08-29 16:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-29 14:29 [RFC PATCH] arm: fiq: convert enable/disable_fiq to inline functions Venkatraman S
2011-08-29 15:14 ` Nicolas Pitre
2011-08-29 16:19   ` S, Venkatraman [this message]
2011-08-29 16:33     ` Nicolas Pitre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CANfBPZ-MbHP8zAqmi3m6=PjSkvBeWO=H18B+ALZToeHrQdbcfw@mail.gmail.com' \
    --to=svenkatr@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.