From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-23.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36001C433DB for ; Mon, 8 Feb 2021 19:57:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E578A64E66 for ; Mon, 8 Feb 2021 19:57:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235230AbhBHT5J (ORCPT ); Mon, 8 Feb 2021 14:57:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34734 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235358AbhBHSOK (ORCPT ); Mon, 8 Feb 2021 13:14:10 -0500 Received: from mail-il1-x129.google.com (mail-il1-x129.google.com [IPv6:2607:f8b0:4864:20::129]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B175AC06178C for ; Mon, 8 Feb 2021 10:13:30 -0800 (PST) Received: by mail-il1-x129.google.com with SMTP id m20so13628279ilj.13 for ; Mon, 08 Feb 2021 10:13:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/e5PLp3RTxWM6g/qVFsn49ZO2ohirYic5f4PB4jc4ZY=; b=BFg1UkNZ9SMlhyTC6i87VjnB4xZ+DXY84WteYAKejtKFAFnYFyKbtiYDMizAWFEG0I ViJWJoUapoct5jaDBcHYqQQdfNXEXZtFalj1LtGZuOggkN3TWv8No4VxNdwVj0OvLSqj y5h0I4mpHlgQapMx2SPYQ1981oYIKbarywq2rBhscty+X4vAi44jaG4BH192+HWTQnqc OrhV4DRtqUXZTIxUqYzY9BPgs1wO8if6DKTA+R9J0p4Y+pz+2kQH6bMThBm5+T9FUBfh dXkjetwjUFTdM1oLCuHS+2a0+QtUuB+WqPydFTR9l359i4u5DbS5ECw/lLohqlD+2Xh7 leow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/e5PLp3RTxWM6g/qVFsn49ZO2ohirYic5f4PB4jc4ZY=; b=D/vbx15asJB73BronlHxRkA9u36s9GeKevN9vJdoE8oO+PYzOb98dHL35ZqWW9Zy0h g43qor8UU7P/uTgc9OraeOD7i7sFnRR91SKLWnMILLTjWH8FAWH/Z4HMYS7rLYdtxb+Z s9Mird1eE7JXniJN2YwgYcEI0CtydSI8oHCdQnHC7k/f6wDca+f+29CM+IFXpUZI2etV zBlIGxVPVNsqWLA3yABVVjpsGMd58fCH9iybcYKSzuqWgyC+eC7A0V7bCe3knBrgPjdw hnaWgUfIc3tzlUozK2mv0rfZTeNE2+pAeEpcAqZ1LPCFnO462aMcfotEzVEcRuTgbKhp t+uA== X-Gm-Message-State: AOAM5330Z+a9BpduJkFglo+e40jpJ06l45kRsHrnu83cgTYXtzRy1nkE BHg0OH7FJbEPtg30ypAD0hSTtoBXhjHSejxoPHQFIw== X-Google-Smtp-Source: ABdhPJxWBm/7+d+3KjPYZevjBOfi/4p7431fD5LmT+LRlgqWcGBxS3YK+5yPxuNo74mcVr37b5wgf5gpi43olmI6hwM= X-Received: by 2002:a92:3f06:: with SMTP id m6mr16244038ila.283.1612808009705; Mon, 08 Feb 2021 10:13:29 -0800 (PST) MIME-Version: 1.0 References: <20210208090841.333724-1-wangyanan55@huawei.com> <20210208090841.333724-2-wangyanan55@huawei.com> In-Reply-To: <20210208090841.333724-2-wangyanan55@huawei.com> From: Ben Gardon Date: Mon, 8 Feb 2021 10:13:18 -0800 Message-ID: Subject: Re: [RFC PATCH 1/2] KVM: selftests: Add a macro to get string of vm_mem_backing_src_type To: Yanan Wang Cc: kvm , linux-kselftest@vger.kernel.org, LKML , Paolo Bonzini , Shuah Khan , Andrew Jones , Marc Zyngier , Peter Xu , Sean Christopherson , Aaron Lewis , Vitaly Kuznetsov , wanghaibin.wang@huawei.com, yuzenghui@huawei.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 8, 2021 at 1:08 AM Yanan Wang wrote: > > Add a macro to get string of the backing source memory type, so that > application can add choices for source types in the help() function, > and users can specify which type to use for testing. Coincidentally, I sent out a change last week to do the same thing: "KVM: selftests: Add backing src parameter to dirty_log_perf_test" (https://lkml.org/lkml/2021/2/2/1430) Whichever way this ends up being implemented, I'm happy to see others interested in testing different backing source types too. > > Signed-off-by: Yanan Wang > --- > tools/testing/selftests/kvm/include/kvm_util.h | 3 +++ > tools/testing/selftests/kvm/lib/kvm_util.c | 8 ++++++++ > 2 files changed, 11 insertions(+) > > diff --git a/tools/testing/selftests/kvm/include/kvm_util.h b/tools/testing/selftests/kvm/include/kvm_util.h > index 5cbb861525ed..f5fc29dc9ee6 100644 > --- a/tools/testing/selftests/kvm/include/kvm_util.h > +++ b/tools/testing/selftests/kvm/include/kvm_util.h > @@ -69,7 +69,9 @@ enum vm_guest_mode { > #define PTES_PER_MIN_PAGE ptes_per_page(MIN_PAGE_SIZE) > > #define vm_guest_mode_string(m) vm_guest_mode_string[m] > +#define vm_mem_backing_src_type_string(s) vm_mem_backing_src_type_string[s] > extern const char * const vm_guest_mode_string[]; > +extern const char * const vm_mem_backing_src_type_string[]; > > struct vm_guest_mode_params { > unsigned int pa_bits; > @@ -83,6 +85,7 @@ enum vm_mem_backing_src_type { > VM_MEM_SRC_ANONYMOUS, > VM_MEM_SRC_ANONYMOUS_THP, > VM_MEM_SRC_ANONYMOUS_HUGETLB, > + NUM_VM_BACKING_SRC_TYPES, > }; > > int kvm_check_cap(long cap); > diff --git a/tools/testing/selftests/kvm/lib/kvm_util.c b/tools/testing/selftests/kvm/lib/kvm_util.c > index fa5a90e6c6f0..a9b651c7f866 100644 > --- a/tools/testing/selftests/kvm/lib/kvm_util.c > +++ b/tools/testing/selftests/kvm/lib/kvm_util.c > @@ -165,6 +165,14 @@ const struct vm_guest_mode_params vm_guest_mode_params[] = { > _Static_assert(sizeof(vm_guest_mode_params)/sizeof(struct vm_guest_mode_params) == NUM_VM_MODES, > "Missing new mode params?"); > > +const char * const vm_mem_backing_src_type_string[] = { > + "VM_MEM_SRC_ANONYMOUS ", > + "VM_MEM_SRC_ANONYMOUS_THP ", > + "VM_MEM_SRC_ANONYMOUS_HUGETLB", > +}; > +_Static_assert(sizeof(vm_mem_backing_src_type_string)/sizeof(char *) == NUM_VM_BACKING_SRC_TYPES, > + "Missing new source type strings?"); > + > /* > * VM Create > * > -- > 2.23.0 >