From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36DB0C43461 for ; Wed, 19 May 2021 21:41:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1C93160233 for ; Wed, 19 May 2021 21:41:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229550AbhESVmk (ORCPT ); Wed, 19 May 2021 17:42:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55212 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229464AbhESVmj (ORCPT ); Wed, 19 May 2021 17:42:39 -0400 Received: from mail-io1-xd33.google.com (mail-io1-xd33.google.com [IPv6:2607:f8b0:4864:20::d33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 27139C06175F for ; Wed, 19 May 2021 14:41:17 -0700 (PDT) Received: by mail-io1-xd33.google.com with SMTP id d11so14523164iod.5 for ; Wed, 19 May 2021 14:41:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=vgT0cqueYQ35F17EV/w98BJe637HcCWQdSVrM36k57w=; b=VS1DsELVUEQIwSJav2W6pVmjTqUn2kC1U0SVlMpEK2GjPoZHGQSfHqu0b/pyG/e3Z9 vEQg5iVNlrrAg+sG6zrMYLkqdyCJ/tgrUTY5lWek7BzbUjrnC1brA4wokElk642gqR1V nYagZSM0XLKtX8czDHmfwkrQZDhgU1IvTa0KYZOY+3OFrlrUERE9LB1HzE6uNddg+nZq 1R9AVmQbZr4ZICEpe9r3DUsdpUzSEGkgDDC99RHHo5w7GQHRMUbuyn6wPL88ChQX7QR+ NNSd4GPidClzDDJEY9rHP/DDy1bVNbLpY3c7PsQ9CN4jdF6j8YzjDrGTuWl9V6EX8ovk GXqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=vgT0cqueYQ35F17EV/w98BJe637HcCWQdSVrM36k57w=; b=qszXVo2lTPihjMqrT+O5rcPh9hMNDp9rKZoYCCDubF7ZNgYk6BKsruCDJvxgGH9OG6 wu91lXV/Ogv1I18rcLKP/GijYFzIQnI4I8UErWeVPvx9P2sr+1bNvG1MXNvwa3/efeaj zbi1JOV24eOwMl7WLn7wVFU9ClaCbpb3aiAgB4J+NczDXTRLRVKhYhBbz8wqsjuGVPg3 MuGdPtIetVuebxu+Xa9dxsypWu3Umaj5HqKYf8n9fCOEto3rVr5bL3y2hSeSb6rTdBcS T+Rbsu66Jwa2+oQr92n0+9ChSNLKxLnGIlxgVLY1JL3lyBHxRqkD3la8QdSbH9U44ke/ iV1A== X-Gm-Message-State: AOAM53348E5I36BATHOGCwPNnRlm/bKmLuVS1AxLw0EQHF8JWADdyPe2 BQyKD07jWSlkJyr4tshWEIv5K0+H6bkMx4dklwrmDQ== X-Google-Smtp-Source: ABdhPJzMCYo7mCacU8kewSUEr7ktjrK3MXXBaPHCK3qO5XW2iMSrr477pxN9bW5S+VutjgKjZo8YBsx1VxqB6RpHHVE= X-Received: by 2002:a05:6602:1212:: with SMTP id y18mr1882842iot.189.1621460476160; Wed, 19 May 2021 14:41:16 -0700 (PDT) MIME-Version: 1.0 References: <20210519200339.829146-1-axelrasmussen@google.com> <20210519200339.829146-2-axelrasmussen@google.com> In-Reply-To: <20210519200339.829146-2-axelrasmussen@google.com> From: Ben Gardon Date: Wed, 19 May 2021 14:41:05 -0700 Message-ID: Subject: Re: [PATCH v2 01/10] KVM: selftests: trivial comment/logging fixes To: Axel Rasmussen Cc: Aaron Lewis , Alexander Graf , Andrew Jones , Andrew Morton , Emanuele Giuseppe Esposito , Eric Auger , Jacob Xu , Makarand Sonare , Oliver Upton , Paolo Bonzini , Peter Xu , Shuah Khan , Yanan Wang , kvm , LKML , linux-kselftest@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 19, 2021 at 1:03 PM Axel Rasmussen wrote: > > Some trivial fixes I found while touching related code in this series, > factored out into a separate commit for easier reviewing: > > - s/gor/got/ and add a newline in demand_paging_test.c > - s/backing_src/src_type/ in a comment to be consistent with the real > function signature in kvm_util.c > > Signed-off-by: Axel Rasmussen Reviewed-by: Ben Gardon Thanks for doing this! > --- > tools/testing/selftests/kvm/demand_paging_test.c | 2 +- > tools/testing/selftests/kvm/lib/kvm_util.c | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/tools/testing/selftests/kvm/demand_paging_test.c b/tools/testing/selftests/kvm/demand_paging_test.c > index 5f7a229c3af1..9398ba6ef023 100644 > --- a/tools/testing/selftests/kvm/demand_paging_test.c > +++ b/tools/testing/selftests/kvm/demand_paging_test.c > @@ -169,7 +169,7 @@ static void *uffd_handler_thread_fn(void *arg) > if (r == -1) { > if (errno == EAGAIN) > continue; > - pr_info("Read of uffd gor errno %d", errno); > + pr_info("Read of uffd got errno %d\n", errno); > return NULL; > } > > diff --git a/tools/testing/selftests/kvm/lib/kvm_util.c b/tools/testing/selftests/kvm/lib/kvm_util.c > index fc83f6c5902d..f05ca919cccb 100644 > --- a/tools/testing/selftests/kvm/lib/kvm_util.c > +++ b/tools/testing/selftests/kvm/lib/kvm_util.c > @@ -663,8 +663,8 @@ int kvm_memcmp_hva_gva(void *hva, struct kvm_vm *vm, vm_vaddr_t gva, size_t len) > * > * Input Args: > * vm - Virtual Machine > - * backing_src - Storage source for this region. > - * NULL to use anonymous memory. > + * src_type - Storage source for this region. > + * NULL to use anonymous memory. > * guest_paddr - Starting guest physical address > * slot - KVM region slot > * npages - Number of physical pages > -- > 2.31.1.751.gd2f1c929bd-goog >