From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11A8AC2D0F8 for ; Wed, 13 May 2020 07:12:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E1751206F5 for ; Wed, 13 May 2020 07:12:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=flowbird.group header.i=@flowbird.group header.b="K5pzuy/Q" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731804AbgEMHM0 (ORCPT ); Wed, 13 May 2020 03:12:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52978 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730553AbgEMHM0 (ORCPT ); Wed, 13 May 2020 03:12:26 -0400 Received: from mail-lj1-x244.google.com (mail-lj1-x244.google.com [IPv6:2a00:1450:4864:20::244]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B17E1C061A0F for ; Wed, 13 May 2020 00:12:25 -0700 (PDT) Received: by mail-lj1-x244.google.com with SMTP id b6so888370ljj.1 for ; Wed, 13 May 2020 00:12:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=flowbird.group; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=IRFk30OEdsBaX3lNynkWDdT0LAUKPWkllb6vWrvUfFU=; b=K5pzuy/Q0DbKRQJhtwBbIhHrErl3UFCylyh40MxEmVKtgp7yEA96J6jzDlnp1Z9lX3 L0095lu9fUxrCVlwBbN8u7k/YjU5gQNhOooEFNtUQuKet6vVAPI48KqdvwDDSoWxkmNw +PylWBmbq3ADzq9SmaUFmuSSxZT6qEFLq+V/2QzC90vcKfu7ZAw7q1+eCKk985st/+rD L0WnmVbg1Zay9q2IAo3SswAhLrVPrbQyjbJyS5GnZ/rQoLHTPXPjoZLTn/MHOb9BorNj TxoihN27LfVVuTTxxgi5ohtgAfasA7G6w5fuCLWotsAmKVh4quhdqPwl8wkOmMx30QtM 4TuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=IRFk30OEdsBaX3lNynkWDdT0LAUKPWkllb6vWrvUfFU=; b=SpmjFN8AEqStTF0k9nJrjRVeRaXsXWjnuh9+TvJurXORFpYjDEopkevpTXKYqGytcg O2VGfpl1Dsv4ND2nNy0npTK0pVBGlQlcc0vcJtPNICKDfUGh6rnhuo1tzZGS2ix/W1HM Tzh00XvYgHLEfgc8kvWJC4WLF2H9MGSl4f7GMdreLVBJtkyrDMxJr9/z9gfvLE+BCMp3 2lg4LuHNsWJ4WfS1qi7Y0XwDFlFEp1L56ju3r+jI+8YrMq4J3YkzvHxT2Wrvr1mtRD2u 629I4P3qGz8YN3Vd1km5Lf/K9khqAMDfFu6GHuCnkCH03LJbHa8Wy1aKdIcIZI7YxB0G cQdQ== X-Gm-Message-State: AOAM530eNuvbrGEdUb4M4+aAFXwEx8B6BxMZexpZ4TdZ+6Uu49TM0Spu lc+Gm7ef4mNFCrPH+ImSpjqM4Reua3mqMXw0t2LzDQ== X-Google-Smtp-Source: ABdhPJxOVv0j3JItO5IlLO900Ue/XycQksnMkwQAPd8Io9f7MPELoXRwn0ku6xHMSL2Omjmun1aVBi7/j3xnmT3aaQ4= X-Received: by 2002:a2e:8e98:: with SMTP id z24mr16710225ljk.134.1589353944120; Wed, 13 May 2020 00:12:24 -0700 (PDT) MIME-Version: 1.0 References: <1589218356-17475-1-git-send-email-yibin.gong@nxp.com> <1589218356-17475-4-git-send-email-yibin.gong@nxp.com> <20200513060525.GJ5877@pengutronix.de> In-Reply-To: <20200513060525.GJ5877@pengutronix.de> From: "Fuzzey, Martin" Date: Wed, 13 May 2020 09:12:13 +0200 Message-ID: Subject: Re: [PATCH v7 RESEND 03/13] Revert "dmaengine: imx-sdma: fix context cache" To: Sascha Hauer Cc: Robin Gong , vkoul@kernel.org, Shawn Guo , =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= , Rob Herring , Fabio Estevam , dan.j.williams@intel.com, mark.rutland@arm.com, catalin.marinas@arm.com, Will Deacon , Lucas Stach , Sascha Hauer , linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, "Linux-Kernel@Vger. Kernel. Org" , dl-linux-imx , dmaengine@vger.kernel.org, devicetree@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org On Wed, 13 May 2020 at 08:07, Sascha Hauer wrote: > > On Tue, May 12, 2020 at 01:32:26AM +0800, Robin Gong wrote: > > This reverts commit d288bddd8374e0a043ac9dde64a1ae6a09411d74, since > > 'context_loaded' finally removed. > > > > Signed-off-by: Robin Gong > > --- > > I think this can safely be folded into the next patch which makes it > more clear what is happening. > Agreed, not only that but having 2 separate patches also means that the bug that was fixed by the commit being reverted could reappear during bisection. More generally I think reverts should be reserved for commits that later turn out to be wrong or unneeded (ie should never really have been applied). If they were OK at the time but later become unnecessary due to other code changes I think all the related modifications should be done in a single normal non revert patch. Martin From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1365BC2D0F9 for ; Wed, 13 May 2020 07:12:31 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BC651206F5 for ; Wed, 13 May 2020 07:12:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ttAWMtfl"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=flowbird.group header.i=@flowbird.group header.b="K5pzuy/Q" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BC651206F5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=flowbird.group Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=lZoMr60ypIQfemeSeKGjf3tYrG+qSJBukz64ySctag8=; b=ttAWMtfl9q4qjw TUQxPE0QbT4DwkvUhkZYqMLmOlnsTAX9wQsbf680x3PPc1jMNKZnJm5UJQ4I5yJFusg4I4QITlDRS xEoCGZCt9qJ1TKaTWlKUoQd79e8/yVPbwoPllZotF+RDlGovxV4RvT6rCkoiUWRhI+kIEX5y/jFKd mSU8+6Ru2WhXks+GnN3MJFpTVNmon3kThfhmcLNZoDrzPEYhNWjn25lGQcz7vI1uHFGv8oQBjjHA5 RLY7NngCWBpiQpyE9Bi86uTeVeXCV180uTXwT0Nf3VHF7THkZPslmdajutgPb1+ytmFqrWjb+cXa1 bx36gmR9zgTLbSpkAb5Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jYlZ7-0004ZJ-Vc; Wed, 13 May 2020 07:12:29 +0000 Received: from mail-lj1-x242.google.com ([2a00:1450:4864:20::242]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jYlZ4-0004XB-GS for linux-arm-kernel@lists.infradead.org; Wed, 13 May 2020 07:12:27 +0000 Received: by mail-lj1-x242.google.com with SMTP id o14so15468068ljp.4 for ; Wed, 13 May 2020 00:12:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=flowbird.group; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=IRFk30OEdsBaX3lNynkWDdT0LAUKPWkllb6vWrvUfFU=; b=K5pzuy/Q0DbKRQJhtwBbIhHrErl3UFCylyh40MxEmVKtgp7yEA96J6jzDlnp1Z9lX3 L0095lu9fUxrCVlwBbN8u7k/YjU5gQNhOooEFNtUQuKet6vVAPI48KqdvwDDSoWxkmNw +PylWBmbq3ADzq9SmaUFmuSSxZT6qEFLq+V/2QzC90vcKfu7ZAw7q1+eCKk985st/+rD L0WnmVbg1Zay9q2IAo3SswAhLrVPrbQyjbJyS5GnZ/rQoLHTPXPjoZLTn/MHOb9BorNj TxoihN27LfVVuTTxxgi5ohtgAfasA7G6w5fuCLWotsAmKVh4quhdqPwl8wkOmMx30QtM 4TuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=IRFk30OEdsBaX3lNynkWDdT0LAUKPWkllb6vWrvUfFU=; b=MTYMeltu3Jyyzi036BSDp6FPA/lK6Mn5OuxDc9v3mBDIGBKq7SxQYGbsTlFFncQbZv vgKDeWDqS0Z8Nn2U/WxtLOY78ElSWepA57OU6UMHkFuUtfOMAwo9Kcn14mnxfP8J1a8W c9B/SBK/O4Ks+lsjIHsc+U41hIdbaQRwiiia2TKDs0v48ewt5ySGL1aQXAfdn4RElzEc zZpcItmhUvVTVoHTordc0caKmcDdDGKfJlXaN0mhLrbFw3EVTJaDQ1AAOh0wuV9TEH2a Ue+v2Z4dayBfFfuNySPozSPviE9ydm8RKo8HzuQOg3n1uxYPQg5WQJ1BAU1tkcBWt+Qe SLYw== X-Gm-Message-State: AOAM5337NnaufE7b7n6VaTwHqj2c/WmEJF+5lhcVf7gG+Ov/L8RPdJr/ XE1YJDgabQy+THsLwr3Td4iz32UlJTdHAOsNnUFCeQ== X-Google-Smtp-Source: ABdhPJxOVv0j3JItO5IlLO900Ue/XycQksnMkwQAPd8Io9f7MPELoXRwn0ku6xHMSL2Omjmun1aVBi7/j3xnmT3aaQ4= X-Received: by 2002:a2e:8e98:: with SMTP id z24mr16710225ljk.134.1589353944120; Wed, 13 May 2020 00:12:24 -0700 (PDT) MIME-Version: 1.0 References: <1589218356-17475-1-git-send-email-yibin.gong@nxp.com> <1589218356-17475-4-git-send-email-yibin.gong@nxp.com> <20200513060525.GJ5877@pengutronix.de> In-Reply-To: <20200513060525.GJ5877@pengutronix.de> From: "Fuzzey, Martin" Date: Wed, 13 May 2020 09:12:13 +0200 Message-ID: Subject: Re: [PATCH v7 RESEND 03/13] Revert "dmaengine: imx-sdma: fix context cache" To: Sascha Hauer X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200513_001226_543525_0BC5969C X-CRM114-Status: GOOD ( 12.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, catalin.marinas@arm.com, Shawn Guo , Will Deacon , "Linux-Kernel@Vger. Kernel. Org" , linux-spi@vger.kernel.org, vkoul@kernel.org, Rob Herring , dl-linux-imx , Sascha Hauer , =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= , dmaengine@vger.kernel.org, dan.j.williams@intel.com, Robin Gong , Fabio Estevam , linux-arm-kernel@lists.infradead.org, Lucas Stach Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 13 May 2020 at 08:07, Sascha Hauer wrote: > > On Tue, May 12, 2020 at 01:32:26AM +0800, Robin Gong wrote: > > This reverts commit d288bddd8374e0a043ac9dde64a1ae6a09411d74, since > > 'context_loaded' finally removed. > > > > Signed-off-by: Robin Gong > > --- > > I think this can safely be folded into the next patch which makes it > more clear what is happening. > Agreed, not only that but having 2 separate patches also means that the bug that was fixed by the commit being reverted could reappear during bisection. More generally I think reverts should be reserved for commits that later turn out to be wrong or unneeded (ie should never really have been applied). If they were OK at the time but later become unnecessary due to other code changes I think all the related modifications should be done in a single normal non revert patch. Martin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel