From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D08F6C55179 for ; Thu, 29 Oct 2020 18:09:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 619192087D for ; Thu, 29 Oct 2020 18:09:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="qYyU4vJ7" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725914AbgJ2SJ4 (ORCPT ); Thu, 29 Oct 2020 14:09:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43316 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725923AbgJ2SJa (ORCPT ); Thu, 29 Oct 2020 14:09:30 -0400 Received: from mail-oi1-x241.google.com (mail-oi1-x241.google.com [IPv6:2607:f8b0:4864:20::241]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0914CC0613D2 for ; Thu, 29 Oct 2020 11:09:00 -0700 (PDT) Received: by mail-oi1-x241.google.com with SMTP id x1so3910472oic.13 for ; Thu, 29 Oct 2020 11:09:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=mBUzc9CK7MUBRWLylSHpe2XD8BDUPf6CGZ/koJbns3c=; b=qYyU4vJ7lIMZB7mVlFC8g9vfsaKue73KJZYbT2ipvTyGxqr3B/Pb1WNfZNCWp0Rz2n VySxQ/9rUoMGieDNBPR/H7OukAl2dCnpp+LkP0WmGeVdsA/J/GGB0HBPRbVGd9fr7Rtl CmPB5S/6/sPoolazQBJWrQiD+/paaFMs2uinPNEs3upQeFEnxKygeOe0XcNsN/fseBhK Kg/0gT4sTYKG70U2nwMGDEGWRlslBuLc4g1XUqy4rP/4jo20J0RqifYGfFEpjmVmi79h 04yfpBFIJk15QqwCC/63x1BEpKt5Odj82zoSfDUJoXUVt4gKQ6/S5Zzhj6FNTJBvxEzQ mL0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mBUzc9CK7MUBRWLylSHpe2XD8BDUPf6CGZ/koJbns3c=; b=DSqBXmeHJ4eo1L926/VMSGKg49eZt4OOkzhAQ6Pf+9iYW3A3qyEleXxXvHlA2YYhtp 5l4S4GUnrCBTGc0PuXTJy5JrdPutYZLdsgI1Eu4c1SlFcdp1fPNCfx/PICDDpGlcAfGp JNgI0VjCcmokrbV+jlW0wlFKPZnTJss4o8eoIhSlUkmQt2trZfYUo4xzEdqD1nVsklBs q/BlSdHYahAhhHYZR0ijkUvqUrklQ4Kd4APoyewu+7KI5zbWcyFopi/DGfz6bjV5tjsh Wns/+OdtKu0l4BMnGAYMNwsEHnYuVA8Ie0VICihnBYESHX+n82XC9/IntDG8+Kh4i+ut nxPw== X-Gm-Message-State: AOAM530JieFtN5RD2W3tIYeAzFv46ifmt+iErOc1BE83NWQ1A1kDOkuT TYubPriAkAKjZ/DgPd+uRHxR32R/Fo/J0IQe8Nw0NA== X-Google-Smtp-Source: ABdhPJxqT2kL0a4tFiy+m/bOuNX6YodgkMrdSY8ftIGXaGCFzPFB4GPgxkbcd9UTdg23gBYzEH+631+hIBSlXikbbHo= X-Received: by 2002:aca:3442:: with SMTP id b63mr321446oia.15.1603994940142; Thu, 29 Oct 2020 11:09:00 -0700 (PDT) MIME-Version: 1.0 References: <20201028171757.765866-1-ribalda@chromium.org> <20201028182744.GZ4077@smile.fi.intel.com> In-Reply-To: From: Ricardo Ribalda Date: Thu, 29 Oct 2020 19:08:47 +0100 Message-ID: Subject: Re: [PATCH] gpiolib: acpi: Support GpioInt with active_low polarity To: Andy Shevchenko Cc: Andy Shevchenko , Mika Westerberg , Linus Walleij , Bartosz Golaszewski , "open list:GPIO SUBSYSTEM" , ACPI Devel Maling List , Linux Kernel Mailing List , Tomasz Figa Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org Adding Tomasz in CC in case he wants to share more info about the device. On Thu, Oct 29, 2020 at 6:31 PM Andy Shevchenko wrote: > > On Thu, Oct 29, 2020 at 5:37 PM Ricardo Ribalda wrote: > > On Thu, Oct 29, 2020 at 3:38 PM Andy Shevchenko > > wrote: > > > > > > On Wed, Oct 28, 2020 at 06:17:57PM +0100, Ricardo Ribalda wrote: > > > > On the current implementation we only support active_high polarity for > > > > GpioInt. > > > > > > > > There can be cases where a GPIO has active_low polarity and it is also a > > > > IRQ source. > > > > > > > > De-couple the irq_polarity and active_low fields instead of re-use it. > > > > > > > > With this patch we support ACPI devices such as: > > > > > > Is it real device on the market?! > > > > Yes, it is a chromebook. > > You mean it's already on sale with this broken table?! I do not agree that it is broken. It follows the current standard ;) > > > > This table is broken. _DSD GPIO active_low is only for GpioIo(). > > > > AFAIK the format of the _DSD is not in the ACPI standard. We have > > decided its fields. (please correct me if I am wrong here) > > _DSD is a concept that is part of the spec, but each UUID and its > application is out of scope indeed. > > GPIO application to _DSD is described in the in-kernel documentation. > Thanks for pointing out the issues it has. > > > On the other mail I have described why we need to make use of the > > active_low on a GpioInt() > > > > If there is another way of describing ActiveBoth + inverted polarity > > please let me know and I will go that way. > > I answered it there, please, continue this topic there. > NAK to the proposed change. > > > > If it is a ChromeBook, please fix the firmware. Lets agree what is the best way to describe in acpi my usecase and I will implement it. > > -- > With Best Regards, > Andy Shevchenko -- Ricardo Ribalda