From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D49AC433FE for ; Tue, 19 Apr 2022 11:46:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1351857AbiDSLtQ (ORCPT ); Tue, 19 Apr 2022 07:49:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39852 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1351842AbiDSLtL (ORCPT ); Tue, 19 Apr 2022 07:49:11 -0400 Received: from mail-oi1-x235.google.com (mail-oi1-x235.google.com [IPv6:2607:f8b0:4864:20::235]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 93FC52AE2E for ; Tue, 19 Apr 2022 04:46:29 -0700 (PDT) Received: by mail-oi1-x235.google.com with SMTP id bj24so12351385oib.11 for ; Tue, 19 Apr 2022 04:46:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=zr+VGX0mhBp9NZinaclK39Iaheyjh+GcxufQM98q2T4=; b=TaPVENVs6UeX/0wd28BijzB9+2vH3hkykLfAx6Z+TianLJL/RErxbAX9zvCD+siM/Z uLqmKaIs6I21/BZuoX5aH54xHpMduMGKHjQmyllRJaUuuBA2culEnlxqKuir7uxiFapV 3KrFAo/2ggciJwo9Etg/qeEu5hsSc4fTqlm8c= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zr+VGX0mhBp9NZinaclK39Iaheyjh+GcxufQM98q2T4=; b=U3Wpxd9CpUGKzZy9qWyos3h5yMgwVjEh7C5DWM3fIH1AXGkwrZahWlrEGm0tStdMoL gnuNTK4hCjAmvsnJ4RAT/nCW3x1u5yDcL1Hyf6V9W4/z2ZrEjhzRT6hbc9+DWkm8MtdF fvK/fICM2Jme8e9CjYugxt0tvBXQWtOCa6oW68UTZCLX/OAvustUUZXuv6C2mxf8V9t5 Rq2SA7k/EsSg0FQqgL+I52kaG4QusUTbrhoVFJ8BYX5Dv/4JrVHfAFnnovm3B/Z9ZKUg Ixy8x7SLIVsyjAkubijYFcUa1aD7ghc8Qkm0ioYyDXBYeTFOoVJrcaAPKxrJD8nHRVks PnIQ== X-Gm-Message-State: AOAM533drcuHUiw6VYvmKchcKQPxNdY+LtWlBloHo1d9nuFkn+8LEwLS zz7IFYGFLi4WWW6oyn7aEgpZlWCRl/Nq3Q== X-Google-Smtp-Source: ABdhPJzYa/FMt4AwzPZvvGyCipFylBW05AyjcbZFE23Ot17k4K9hz6yCnN4iiS0BGFxKE4W/QdR6EA== X-Received: by 2002:a05:6808:1d7:b0:322:5866:9ee3 with SMTP id x23-20020a05680801d700b0032258669ee3mr6682848oic.171.1650368788691; Tue, 19 Apr 2022 04:46:28 -0700 (PDT) Received: from mail-oo1-f48.google.com (mail-oo1-f48.google.com. [209.85.161.48]) by smtp.gmail.com with ESMTPSA id x2-20020a4a2a42000000b0033a3c4392c3sm2277798oox.26.2022.04.19.04.46.26 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 19 Apr 2022 04:46:27 -0700 (PDT) Received: by mail-oo1-f48.google.com with SMTP id 65-20020a4a1a44000000b00333316787bbso2642786oof.3 for ; Tue, 19 Apr 2022 04:46:26 -0700 (PDT) X-Received: by 2002:a4a:8081:0:b0:33a:52ed:3b3b with SMTP id z1-20020a4a8081000000b0033a52ed3b3bmr1777631oof.26.1650368786395; Tue, 19 Apr 2022 04:46:26 -0700 (PDT) MIME-Version: 1.0 References: <20220418090652.3156-1-Ping-lei.Lin@mediatek.com> In-Reply-To: <20220418090652.3156-1-Ping-lei.Lin@mediatek.com> From: Ricardo Ribalda Date: Tue, 19 Apr 2022 13:46:15 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3] media: usb: uvc: Add UVC_GUID_FORMAT_H265 To: James_Lin Cc: linux-kernel@vger.kernel.org, Laurent Pinchart , Mauro Carvalho Chehab , Matthias Brugger , Hans Verkuil , Ezequiel Garcia , Arnd Bergmann , Sergey Senozhatsky , Alexandre Courbot , Sakari Ailus , linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, sherlock.chang@mediatek.com, lecopzer.chen@mediatek.com, max.yan@mediatek.com, tm.wu@mediatek.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi James Thanks for your patch On Mon, 18 Apr 2022 at 11:07, James_Lin wrote: > > This patch aims to add UVC_GUID_FORMAT_H265 > High Efficiency Video Coding (HEVC), also known as H.265 and MPEG-H Part 2. > They describe the same video encoding method. > So for handling their behavior is the same. > However, when external camera device describes this encoding method, > some use hevc, some use h265. > There is no uniform specification to describe this encoding method. > So if an external camera device use h265 to describe this encoding method, > driver will not recognize it. > Therefore, this patch is to enable driver to read HEVC/H265 > and convert it to V4L2_PIX_FMT_HEVC. > > Signed-off-by: James_Lin Reviewed-by: Ricardo Ribalda > --- > drivers/media/usb/uvc/uvc_driver.c | 5 +++++ > drivers/media/usb/uvc/uvcvideo.h | 3 +++ > 2 files changed, 8 insertions(+) > > diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c > index dda0f0aa78b8..e437e9f95890 100644 > --- a/drivers/media/usb/uvc/uvc_driver.c > +++ b/drivers/media/usb/uvc/uvc_driver.c > @@ -154,6 +154,11 @@ static struct uvc_format_desc uvc_fmts[] = { > .guid = UVC_GUID_FORMAT_H264, > .fcc = V4L2_PIX_FMT_H264, > }, Maybe I would add a comment here saying that some cameras represent hevc as h265. > + { > + .name = "H.265", > + .guid = UVC_GUID_FORMAT_H265, > + .fcc = V4L2_PIX_FMT_HEVC, > + }, > { > .name = "Greyscale 8 L/R (Y8I)", > .guid = UVC_GUID_FORMAT_Y8I, > diff --git a/drivers/media/usb/uvc/uvcvideo.h b/drivers/media/usb/uvc/uvcvideo.h > index 143230b3275b..41f4d8c33f2a 100644 > --- a/drivers/media/usb/uvc/uvcvideo.h > +++ b/drivers/media/usb/uvc/uvcvideo.h > @@ -139,6 +139,9 @@ > #define UVC_GUID_FORMAT_H264 \ > { 'H', '2', '6', '4', 0x00, 0x00, 0x10, 0x00, \ > 0x80, 0x00, 0x00, 0xaa, 0x00, 0x38, 0x9b, 0x71} > +#define UVC_GUID_FORMAT_H265 \ > + { 'H', '2', '6', '5', 0x00, 0x00, 0x10, 0x00, \ > + 0x80, 0x00, 0x00, 0xaa, 0x00, 0x38, 0x9b, 0x71} > #define UVC_GUID_FORMAT_Y8I \ > { 'Y', '8', 'I', ' ', 0x00, 0x00, 0x10, 0x00, \ > 0x80, 0x00, 0x00, 0xaa, 0x00, 0x38, 0x9b, 0x71} > -- > 2.18.0 > -- Ricardo Ribalda From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D2E43C433EF for ; Tue, 19 Apr 2022 13:00:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Tr0/9gxkBQ5/fuuo9IvYscCo/VrUZpQOLJQHTZteyY0=; b=RxVeg3/ukcGY9X 1Ik9Cl6dQkcvsqv/JcV326jZO7HKoKIpCIpnJ32xoDVvBzq1NXNItRp+yUfDo4pQqcZ4DZXsFTsil hjveRocjw+78g1ZaAVW23NrDbbq1tLMNqmaKVMcCmJHfFGZ3+xDEGNHfe0eIgaH/VAgUQD4nCWfvK XAnCdAcxRfVrxHdvV1I5SO7128XZU567zeFuGWcev4QGUJ2fzla0JhSB0xWWwXmiivjy+5gXmkWG7 bGxVuJ5f1r9sLsNwWOkfum1kZ+SJEnhiY0coXs/V09DUzSDElHDEP8NgTLz3m8ikpEGFqBxzuqydK 7aUkmmE9u1x5ELRS3z0g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ngnQE-003er3-6m; Tue, 19 Apr 2022 12:57:34 +0000 Received: from mail-oi1-x235.google.com ([2607:f8b0:4864:20::235]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ngmJR-003Egq-Ir for linux-arm-kernel@lists.infradead.org; Tue, 19 Apr 2022 11:46:31 +0000 Received: by mail-oi1-x235.google.com with SMTP id e189so17794151oia.8 for ; Tue, 19 Apr 2022 04:46:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=zr+VGX0mhBp9NZinaclK39Iaheyjh+GcxufQM98q2T4=; b=TaPVENVs6UeX/0wd28BijzB9+2vH3hkykLfAx6Z+TianLJL/RErxbAX9zvCD+siM/Z uLqmKaIs6I21/BZuoX5aH54xHpMduMGKHjQmyllRJaUuuBA2culEnlxqKuir7uxiFapV 3KrFAo/2ggciJwo9Etg/qeEu5hsSc4fTqlm8c= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zr+VGX0mhBp9NZinaclK39Iaheyjh+GcxufQM98q2T4=; b=OuIB683SU9h8JqMulk0j3jEU14WreEiQeclOqvQAcZzo5TW1MZmJ/SPbNFYGKaRThd MM91cZPDQBjtCMm10lMYnd/smmto1UhMk/0bNif3ZiUpIidSrjMJVKlT8MsOYYZfSYjK 1LUngd512nupur0Rq9XVHbJsh96u4pFnjezDfODxjyAkjBcSSpB0aXDnljPugr+IQM+L 9u1Lb9A5P6xyQJCJ5qbFSivVZeCq7EB2WsJ8+XHExObqiv3FcmEea8nYMVsKlkjZLDRt EATXANbp2K7bZEfNx9OHv0uPyL5iPxPXtZotg6qqhtFsPRZhTL3BczCAKH+g6ucjZAl/ eAsw== X-Gm-Message-State: AOAM532jtKcRSsR305l1a5enWIrcmZYR1piPuvNTB8VS742Sq+CurEcD oNmhMwLWs+gtSrdfzKf3Ectz6KmUu0KpOw== X-Google-Smtp-Source: ABdhPJwhxbYAKUWjp2G2974a0qGkNF9lFUV4qHAAaCaIO7CUeeSGsn8M4TO22WnrUNNR8vZTLqQeKg== X-Received: by 2002:a05:6808:1250:b0:2da:39df:1f92 with SMTP id o16-20020a056808125000b002da39df1f92mr9191661oiv.27.1650368787617; Tue, 19 Apr 2022 04:46:27 -0700 (PDT) Received: from mail-oo1-f54.google.com (mail-oo1-f54.google.com. [209.85.161.54]) by smtp.gmail.com with ESMTPSA id c20-20020a4a2854000000b00329d3f076aasm5325756oof.24.2022.04.19.04.46.26 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 19 Apr 2022 04:46:27 -0700 (PDT) Received: by mail-oo1-f54.google.com with SMTP id m22-20020a056820051600b0033a41079257so910061ooj.4 for ; Tue, 19 Apr 2022 04:46:26 -0700 (PDT) X-Received: by 2002:a4a:8081:0:b0:33a:52ed:3b3b with SMTP id z1-20020a4a8081000000b0033a52ed3b3bmr1777631oof.26.1650368786395; Tue, 19 Apr 2022 04:46:26 -0700 (PDT) MIME-Version: 1.0 References: <20220418090652.3156-1-Ping-lei.Lin@mediatek.com> In-Reply-To: <20220418090652.3156-1-Ping-lei.Lin@mediatek.com> From: Ricardo Ribalda Date: Tue, 19 Apr 2022 13:46:15 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3] media: usb: uvc: Add UVC_GUID_FORMAT_H265 To: James_Lin Cc: linux-kernel@vger.kernel.org, Laurent Pinchart , Mauro Carvalho Chehab , Matthias Brugger , Hans Verkuil , Ezequiel Garcia , Arnd Bergmann , Sergey Senozhatsky , Alexandre Courbot , Sakari Ailus , linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, sherlock.chang@mediatek.com, lecopzer.chen@mediatek.com, max.yan@mediatek.com, tm.wu@mediatek.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220419_044629_686352_75B632CE X-CRM114-Status: GOOD ( 25.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi James Thanks for your patch On Mon, 18 Apr 2022 at 11:07, James_Lin wrote: > > This patch aims to add UVC_GUID_FORMAT_H265 > High Efficiency Video Coding (HEVC), also known as H.265 and MPEG-H Part 2. > They describe the same video encoding method. > So for handling their behavior is the same. > However, when external camera device describes this encoding method, > some use hevc, some use h265. > There is no uniform specification to describe this encoding method. > So if an external camera device use h265 to describe this encoding method, > driver will not recognize it. > Therefore, this patch is to enable driver to read HEVC/H265 > and convert it to V4L2_PIX_FMT_HEVC. > > Signed-off-by: James_Lin Reviewed-by: Ricardo Ribalda > --- > drivers/media/usb/uvc/uvc_driver.c | 5 +++++ > drivers/media/usb/uvc/uvcvideo.h | 3 +++ > 2 files changed, 8 insertions(+) > > diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c > index dda0f0aa78b8..e437e9f95890 100644 > --- a/drivers/media/usb/uvc/uvc_driver.c > +++ b/drivers/media/usb/uvc/uvc_driver.c > @@ -154,6 +154,11 @@ static struct uvc_format_desc uvc_fmts[] = { > .guid = UVC_GUID_FORMAT_H264, > .fcc = V4L2_PIX_FMT_H264, > }, Maybe I would add a comment here saying that some cameras represent hevc as h265. > + { > + .name = "H.265", > + .guid = UVC_GUID_FORMAT_H265, > + .fcc = V4L2_PIX_FMT_HEVC, > + }, > { > .name = "Greyscale 8 L/R (Y8I)", > .guid = UVC_GUID_FORMAT_Y8I, > diff --git a/drivers/media/usb/uvc/uvcvideo.h b/drivers/media/usb/uvc/uvcvideo.h > index 143230b3275b..41f4d8c33f2a 100644 > --- a/drivers/media/usb/uvc/uvcvideo.h > +++ b/drivers/media/usb/uvc/uvcvideo.h > @@ -139,6 +139,9 @@ > #define UVC_GUID_FORMAT_H264 \ > { 'H', '2', '6', '4', 0x00, 0x00, 0x10, 0x00, \ > 0x80, 0x00, 0x00, 0xaa, 0x00, 0x38, 0x9b, 0x71} > +#define UVC_GUID_FORMAT_H265 \ > + { 'H', '2', '6', '5', 0x00, 0x00, 0x10, 0x00, \ > + 0x80, 0x00, 0x00, 0xaa, 0x00, 0x38, 0x9b, 0x71} > #define UVC_GUID_FORMAT_Y8I \ > { 'Y', '8', 'I', ' ', 0x00, 0x00, 0x10, 0x00, \ > 0x80, 0x00, 0x00, 0xaa, 0x00, 0x38, 0x9b, 0x71} > -- > 2.18.0 > -- Ricardo Ribalda _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0911EC433F5 for ; Tue, 19 Apr 2022 13:10:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3i7cSS5OqE2RayrygpF6NAfn2I+DEjyhJoSs3l4CIV4=; b=Z6cxrnCWbMAoAB zeCOTbWLfXs2AsIWbTI6gBdhKJI0bafVElDZnEIT/87CQuit3vm4aWBlCYg+gE5jCoxthU5MfUqMH dCKMKCPGA+JBtVTzTMpe2r+/hpCUKwQEipMlxOxTydo5Li6g++IM8nDi4r+Oxas2ZTwvhtrkIOQNq LMSDnzeyhPNNx5iW3VtAX9hA/9IjRhJArBgv/mxeAioUE8ThDfGcNf9YJpewQsr1t0OoJMg7GgFQP 78aNWmN5LUhT0jxsxZZQsWcdjMeBJynhxJINCfcgWZ5N/a9IawRYSDJxJWk+I79VucEJk8ge3Wv6k QEdCymOFBcmQ1r2vJhvg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ngncJ-003jDw-W3; Tue, 19 Apr 2022 13:10:04 +0000 Received: from mail-oa1-x30.google.com ([2001:4860:4864:20::30]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ngmR0-003HB1-1I for linux-mediatek@lists.infradead.org; Tue, 19 Apr 2022 11:54:20 +0000 Received: by mail-oa1-x30.google.com with SMTP id 586e51a60fabf-e5e8523fcbso5623804fac.10 for ; Tue, 19 Apr 2022 04:54:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=zr+VGX0mhBp9NZinaclK39Iaheyjh+GcxufQM98q2T4=; b=TaPVENVs6UeX/0wd28BijzB9+2vH3hkykLfAx6Z+TianLJL/RErxbAX9zvCD+siM/Z uLqmKaIs6I21/BZuoX5aH54xHpMduMGKHjQmyllRJaUuuBA2culEnlxqKuir7uxiFapV 3KrFAo/2ggciJwo9Etg/qeEu5hsSc4fTqlm8c= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zr+VGX0mhBp9NZinaclK39Iaheyjh+GcxufQM98q2T4=; b=mqqLfdJXBx2SaUmsjn8LqC6RJ7FCe6w1/5x4UsaBbsgd2juCDPTHjHChQuyAvtp9GA 9qHmzPa+4KzsvmchdGt/tSR96/hDpMGsYizPZgBo/hcjsL5WBzK4jfX6mqaUC89eEZZj WgKPh9MshCNWxh9VtUlxg4iRabDoQtaHUqFTn/E/UC8kjzyeBIlv02zI6tvtAmO35kU2 n1CPiyCkjSmZJXiatZXFOElV9r2w4rnjmideDVHPWgoWLwP2thlnfcTvSPLM0yOda0ZU pjFsbJhSj3zNR0PQIuJT9YeJnHdteluDD/QqObmc1SpQByROPS98FJlRUiml3/bdla6U N/Gw== X-Gm-Message-State: AOAM5310Cn8Kr3vtGCkKrG6Q1TPO8Xf5EKeWc0pUNvomV1lec+BDLiRc QVLja/3Y13GlAUdCdxvEWmS9kdYY3xB26A== X-Google-Smtp-Source: ABdhPJwR36N39A3FS7xYdfd2lNdkSlMfrvZQto2NgYWev6XDi9dliqpFywz+lH2hZhiH2FbNgFPkNw== X-Received: by 2002:a05:6870:1710:b0:e5:bd83:fa8 with SMTP id h16-20020a056870171000b000e5bd830fa8mr5818865oae.124.1650369254502; Tue, 19 Apr 2022 04:54:14 -0700 (PDT) Received: from mail-ot1-f44.google.com (mail-ot1-f44.google.com. [209.85.210.44]) by smtp.gmail.com with ESMTPSA id 17-20020a056870121100b000e296227c9bsm4990440oan.9.2022.04.19.04.54.14 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 19 Apr 2022 04:54:14 -0700 (PDT) Received: by mail-ot1-f44.google.com with SMTP id l9-20020a056830268900b006054381dd35so5582821otu.4 for ; Tue, 19 Apr 2022 04:54:14 -0700 (PDT) X-Received: by 2002:a4a:8081:0:b0:33a:52ed:3b3b with SMTP id z1-20020a4a8081000000b0033a52ed3b3bmr1777631oof.26.1650368786395; Tue, 19 Apr 2022 04:46:26 -0700 (PDT) MIME-Version: 1.0 References: <20220418090652.3156-1-Ping-lei.Lin@mediatek.com> In-Reply-To: <20220418090652.3156-1-Ping-lei.Lin@mediatek.com> From: Ricardo Ribalda Date: Tue, 19 Apr 2022 13:46:15 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3] media: usb: uvc: Add UVC_GUID_FORMAT_H265 To: James_Lin Cc: linux-kernel@vger.kernel.org, Laurent Pinchart , Mauro Carvalho Chehab , Matthias Brugger , Hans Verkuil , Ezequiel Garcia , Arnd Bergmann , Sergey Senozhatsky , Alexandre Courbot , Sakari Ailus , linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, sherlock.chang@mediatek.com, lecopzer.chen@mediatek.com, max.yan@mediatek.com, tm.wu@mediatek.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220419_045418_178192_8DEDE9D9 X-CRM114-Status: GOOD ( 23.98 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Hi James Thanks for your patch On Mon, 18 Apr 2022 at 11:07, James_Lin wrote: > > This patch aims to add UVC_GUID_FORMAT_H265 > High Efficiency Video Coding (HEVC), also known as H.265 and MPEG-H Part 2. > They describe the same video encoding method. > So for handling their behavior is the same. > However, when external camera device describes this encoding method, > some use hevc, some use h265. > There is no uniform specification to describe this encoding method. > So if an external camera device use h265 to describe this encoding method, > driver will not recognize it. > Therefore, this patch is to enable driver to read HEVC/H265 > and convert it to V4L2_PIX_FMT_HEVC. > > Signed-off-by: James_Lin Reviewed-by: Ricardo Ribalda > --- > drivers/media/usb/uvc/uvc_driver.c | 5 +++++ > drivers/media/usb/uvc/uvcvideo.h | 3 +++ > 2 files changed, 8 insertions(+) > > diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c > index dda0f0aa78b8..e437e9f95890 100644 > --- a/drivers/media/usb/uvc/uvc_driver.c > +++ b/drivers/media/usb/uvc/uvc_driver.c > @@ -154,6 +154,11 @@ static struct uvc_format_desc uvc_fmts[] = { > .guid = UVC_GUID_FORMAT_H264, > .fcc = V4L2_PIX_FMT_H264, > }, Maybe I would add a comment here saying that some cameras represent hevc as h265. > + { > + .name = "H.265", > + .guid = UVC_GUID_FORMAT_H265, > + .fcc = V4L2_PIX_FMT_HEVC, > + }, > { > .name = "Greyscale 8 L/R (Y8I)", > .guid = UVC_GUID_FORMAT_Y8I, > diff --git a/drivers/media/usb/uvc/uvcvideo.h b/drivers/media/usb/uvc/uvcvideo.h > index 143230b3275b..41f4d8c33f2a 100644 > --- a/drivers/media/usb/uvc/uvcvideo.h > +++ b/drivers/media/usb/uvc/uvcvideo.h > @@ -139,6 +139,9 @@ > #define UVC_GUID_FORMAT_H264 \ > { 'H', '2', '6', '4', 0x00, 0x00, 0x10, 0x00, \ > 0x80, 0x00, 0x00, 0xaa, 0x00, 0x38, 0x9b, 0x71} > +#define UVC_GUID_FORMAT_H265 \ > + { 'H', '2', '6', '5', 0x00, 0x00, 0x10, 0x00, \ > + 0x80, 0x00, 0x00, 0xaa, 0x00, 0x38, 0x9b, 0x71} > #define UVC_GUID_FORMAT_Y8I \ > { 'Y', '8', 'I', ' ', 0x00, 0x00, 0x10, 0x00, \ > 0x80, 0x00, 0x00, 0xaa, 0x00, 0x38, 0x9b, 0x71} > -- > 2.18.0 > -- Ricardo Ribalda _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek