All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] treewide: remove editor modelines and cruft
Date: Wed, 24 Mar 2021 11:59:47 +0100	[thread overview]
Message-ID: <CANiq72kb6sVQXVx6a5NwjFfrfJVZ35KVpj0xV8E7DU1SRV3AuA@mail.gmail.com> (raw)
In-Reply-To: <20210324054457.1477489-1-masahiroy@kernel.org>

Hi Masahiro,

On Wed, Mar 24, 2021 at 10:57 AM Masahiro Yamada <masahiroy@kernel.org> wrote:
>
> The section "19) Editor modelines and other cruft" in
> Documentation/process/coding-style.rst clearly says,
> "Do not include any of these in source files."
>
> I recently receive a patch to explicitly add a new one.
>
> Let's do treewide cleanups, otherwise some people follow the existing
> code and attempt to upstream their favoriate editor setups.
>
> It is even nicer if scripts/checkpatch.pl can check it.
>
> If we like to impose coding style in an editor-independent manner,
> I think editorconfig (patch [1]) is a saner solution.
>
> [1] https://lore.kernel.org/lkml/20200703073143.423557-1-danny@kdrag0n.dev/
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>

+1 It is great to get rid of those.

For auxdisplay:

    Reviewed-by: Miguel Ojeda <ojeda@kernel.org>

For the rest, I did a quick visual inspection and didn't see anything wrong.

Cheers,
Miguel

      parent reply	other threads:[~2021-03-24 11:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-24  5:44 [PATCH] treewide: remove editor modelines and cruft Masahiro Yamada
2021-03-24 10:04 ` Geert Uytterhoeven
2021-03-24 10:59 ` Miguel Ojeda [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CANiq72kb6sVQXVx6a5NwjFfrfJVZ35KVpj0xV8E7DU1SRV3AuA@mail.gmail.com \
    --to=miguel.ojeda.sandonis@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=masahiroy@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.