From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65B35C56201 for ; Wed, 21 Oct 2020 19:27:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E593424171 for ; Wed, 21 Oct 2020 19:27:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="uqNbSPg2" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2504936AbgJUT11 (ORCPT ); Wed, 21 Oct 2020 15:27:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54990 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2410912AbgJUT10 (ORCPT ); Wed, 21 Oct 2020 15:27:26 -0400 Received: from mail-yb1-xb35.google.com (mail-yb1-xb35.google.com [IPv6:2607:f8b0:4864:20::b35]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 75787C0613CE; Wed, 21 Oct 2020 12:27:26 -0700 (PDT) Received: by mail-yb1-xb35.google.com with SMTP id s89so2726769ybi.12; Wed, 21 Oct 2020 12:27:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=E5bP6XIkGVul48ky/KDK8Sf+FXg+duJpCHq4dGdE0Uc=; b=uqNbSPg2N+D4M2VYaciAM0hkRnUBai1TE0HHRw4tO+V1T6pN0WL+8A+o1HNVVBFG7y f69nrXiryg627GNoDJNnsCo7bwLIBFHmWJZkH7Vr+cbjwoZNsBc8ZQGWBFUE+PTsmVhR ytFRs5vstUD5vzKl9bGsDYo9FWn432XKW8tjz3LXmep4PgqlFqXB7LvbU8aK/9A0dBuj WEvDBqMbRvdgyVlo62RcrFKK/1Kii1kwQ1hCnLYC/yciZS4+pIa8hysvm90mrlbYK1Bc eMFfQ3VQAVq2eEBAgD4d8CIoVxSZchh6MCCqP9py589vIhG+qmhB5cK+YAfNC0PhaKHN xAdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=E5bP6XIkGVul48ky/KDK8Sf+FXg+duJpCHq4dGdE0Uc=; b=SJn4DzzoRoNDcV3Q+FUcLhXEXPrxc21sI1rLd+0lorqlDR3QoR5ABIdKuwRIX5vk+H /+/QT3ep614947NveWr5IFv+Q26F93z+sDtGCa4SdGZ/Os/plaVgPSilDQQX1Sp5IWCx Ux7CAIdyoGVAmCi8MJJhyIAjrBoKU7UvESz2ZJEhhXIFQtzlo2UC0o0ln8+6h83/VkFd hI/FPJPDCUVI8tHdcI89BVWU7891N5He/j+sGoQwZIZqV3pN0WhjatG3fNw59+MsfK3k dE1iDcgy3SPaFJAFO3kyGCYk33wmSeh0IhDDLjmYtSPHDi4zcGETkIwM3b1lVldgz759 RSQA== X-Gm-Message-State: AOAM531RInEwv+zHqrBkuyv0gl21FxTB01AF0GGI03Sw08EU49+bvmBz Q9Ij+IMa1/UOKPsZ99qTAnuuzZnkXZEcziMSMJA= X-Google-Smtp-Source: ABdhPJwQ6oGRTDWlUSCRHr+DJeqvZ2WuZgEP28Ztn/Hrj9Fa0J0N+ETgyk0HLKGxwill/jIORyeZV9VzqnCqlk4nHQo= X-Received: by 2002:a25:d441:: with SMTP id m62mr7622555ybf.422.1603308445783; Wed, 21 Oct 2020 12:27:25 -0700 (PDT) MIME-Version: 1.0 References: <20200629003127.GB5535@shao2-debian> <20200630124628.GV4817@hirez.programming.kicks-ass.net> <20200630144905.GX4817@hirez.programming.kicks-ass.net> <58ff47cc-dc55-e383-7a5b-37008d145aba@gmail.com> <20201021080031.GY2628@hirez.programming.kicks-ass.net> <20201021131806.GA2176@tucnak> <20201021134436.GJ2628@hirez.programming.kicks-ass.net> <3ec15b41754b01666d94b76ce51b9832c2dd577a.camel@perches.com> In-Reply-To: <3ec15b41754b01666d94b76ce51b9832c2dd577a.camel@perches.com> From: Miguel Ojeda Date: Wed, 21 Oct 2020 21:27:15 +0200 Message-ID: Subject: Re: GCC section alignment, and GCC-4.9 being a weird one To: Joe Perches Cc: Nick Desaulniers , Lukas Bulwahn , linux-kernel-mentees@lists.linuxfoundation.org, dwaipayanray1@gmail.com, Aditya , Peter Zijlstra , Jakub Jelinek , Florian Fainelli , kernel test robot , Steven Rostedt , LKML , "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , LKP , Kees Cook , "H.J. Lu" , Rasmus Villemoes , linux-toolchains@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 21, 2020 at 8:35 PM Joe Perches wrote: > > Perhaps something to add as a generic test in checkpatch. Agreed! It would be nice to check all of them. Even checking for `attribute` and `__attribute__` could be potentially reasonable (i.e. so that people are reminded to consider adding whatever attributes they need into `compiler_attributes.h`), although perhaps too annoying/noisy for some (e.g. for `arch/*` devs...). Cheers, Miguel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80F37C4363A for ; Wed, 21 Oct 2020 22:14:12 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B65AD2419B for ; Wed, 21 Oct 2020 22:14:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="uqNbSPg2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B65AD2419B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-kernel-mentees-bounces@lists.linuxfoundation.org Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id F215E2010F; Wed, 21 Oct 2020 22:14:10 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id zdaWNBma6V8q; Wed, 21 Oct 2020 22:14:09 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by silver.osuosl.org (Postfix) with ESMTP id 8F5C62EA22; Wed, 21 Oct 2020 19:27:28 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 801AAC088B; Wed, 21 Oct 2020 19:27:28 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists.linuxfoundation.org (Postfix) with ESMTP id 5AFCBC0051 for ; Wed, 21 Oct 2020 19:27:27 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 47244875AD for ; Wed, 21 Oct 2020 19:27:27 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id WQYaR54CoEWA for ; Wed, 21 Oct 2020 19:27:26 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-yb1-f179.google.com (mail-yb1-f179.google.com [209.85.219.179]) by hemlock.osuosl.org (Postfix) with ESMTPS id 9B3578492B for ; Wed, 21 Oct 2020 19:27:26 +0000 (UTC) Received: by mail-yb1-f179.google.com with SMTP id b138so2752843yba.5 for ; Wed, 21 Oct 2020 12:27:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=E5bP6XIkGVul48ky/KDK8Sf+FXg+duJpCHq4dGdE0Uc=; b=uqNbSPg2N+D4M2VYaciAM0hkRnUBai1TE0HHRw4tO+V1T6pN0WL+8A+o1HNVVBFG7y f69nrXiryg627GNoDJNnsCo7bwLIBFHmWJZkH7Vr+cbjwoZNsBc8ZQGWBFUE+PTsmVhR ytFRs5vstUD5vzKl9bGsDYo9FWn432XKW8tjz3LXmep4PgqlFqXB7LvbU8aK/9A0dBuj WEvDBqMbRvdgyVlo62RcrFKK/1Kii1kwQ1hCnLYC/yciZS4+pIa8hysvm90mrlbYK1Bc eMFfQ3VQAVq2eEBAgD4d8CIoVxSZchh6MCCqP9py589vIhG+qmhB5cK+YAfNC0PhaKHN xAdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=E5bP6XIkGVul48ky/KDK8Sf+FXg+duJpCHq4dGdE0Uc=; b=YTztK+w0IcckG4EEUIP0KwdMr9uYoqjqahQfu83FAa2fD1sdAJFJBJQYiUFcC6o0KB AcxJJvo/cwd+Badt8PjhTyPBFNNxHfizaygFZ9WuUXH9F3dJY0dLYGpVPxVyv5omGwby mzUU75nwP5d4/8an8RgIX+iw0UGrESm3vJ1UlzPbE85MnlcVBOaiEqEgsJIImbAQqpKF 4TYlmH/E63GaOcaUWlQczqvzXcvNND5QRJph/0jM5xGxRgYiq6HfzDO0EE1rPHqerLit Tc6FBNGHEDuXZszHBnVBUPHlsHoEVIRHWeVGMh3EQXD57wOodlUT2DBTBMhnUYd21wOt xsbA== X-Gm-Message-State: AOAM532GJm2uX0kQ1UcD5iXLe+dqfAWOeR/fkjZAs6y2N/0vu4ONSjGk Tn7mkrTkorO4atHi9D0jTLX+Obbcl835Gd6xBiA= X-Google-Smtp-Source: ABdhPJwQ6oGRTDWlUSCRHr+DJeqvZ2WuZgEP28Ztn/Hrj9Fa0J0N+ETgyk0HLKGxwill/jIORyeZV9VzqnCqlk4nHQo= X-Received: by 2002:a25:d441:: with SMTP id m62mr7622555ybf.422.1603308445783; Wed, 21 Oct 2020 12:27:25 -0700 (PDT) MIME-Version: 1.0 References: <20200629003127.GB5535@shao2-debian> <20200630124628.GV4817@hirez.programming.kicks-ass.net> <20200630144905.GX4817@hirez.programming.kicks-ass.net> <58ff47cc-dc55-e383-7a5b-37008d145aba@gmail.com> <20201021080031.GY2628@hirez.programming.kicks-ass.net> <20201021131806.GA2176@tucnak> <20201021134436.GJ2628@hirez.programming.kicks-ass.net> <3ec15b41754b01666d94b76ce51b9832c2dd577a.camel@perches.com> In-Reply-To: <3ec15b41754b01666d94b76ce51b9832c2dd577a.camel@perches.com> From: Miguel Ojeda Date: Wed, 21 Oct 2020 21:27:15 +0200 Message-ID: To: Joe Perches Cc: Jakub Jelinek , "H.J. Lu" , Florian Fainelli , kernel test robot , Rasmus Villemoes , Aditya , Peter Zijlstra , dwaipayanray1@gmail.com, "maintainer:X86 ARCHITECTURE \(32-BIT AND 64-BIT\)" , Nick Desaulniers , LKML , Steven Rostedt , LKP , linux-toolchains@vger.kernel.org, linux-kernel-mentees@lists.linuxfoundation.org, Kees Cook Subject: Re: [Linux-kernel-mentees] GCC section alignment, and GCC-4.9 being a weird one X-BeenThere: linux-kernel-mentees@lists.linuxfoundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-kernel-mentees-bounces@lists.linuxfoundation.org Sender: "Linux-kernel-mentees" On Wed, Oct 21, 2020 at 8:35 PM Joe Perches wrote: > > Perhaps something to add as a generic test in checkpatch. Agreed! It would be nice to check all of them. Even checking for `attribute` and `__attribute__` could be potentially reasonable (i.e. so that people are reminded to consider adding whatever attributes they need into `compiler_attributes.h`), although perhaps too annoying/noisy for some (e.g. for `arch/*` devs...). Cheers, Miguel _______________________________________________ Linux-kernel-mentees mailing list Linux-kernel-mentees@lists.linuxfoundation.org https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees