From: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
To: Nick Desaulniers <ndesaulniers@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Jakub Jelinek <jakub@redhat.com>,
Florian Fainelli <f.fainelli@gmail.com>,
kernel test robot <lkp@intel.com>,
Steven Rostedt <rostedt@goodmis.org>,
LKML <linux-kernel@vger.kernel.org>,
"maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)"
<x86@kernel.org>, LKP <lkp@lists.01.org>,
Kees Cook <keescook@chromium.org>,
"H.J. Lu" <hjl.tools@gmail.com>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
linux-toolchains@vger.kernel.org
Subject: Re: GCC section alignment, and GCC-4.9 being a weird one
Date: Wed, 21 Oct 2020 19:54:11 +0200 [thread overview]
Message-ID: <CANiq72m+_QYtn_1gyrjXFs6yeDdiMoS4DVcWqYcTgyCFnSFXbw@mail.gmail.com> (raw)
In-Reply-To: <CAKwvOd=qi63We=6rLapb565giCVe-8a6d=-=3VZL6RWzhwAeZg@mail.gmail.com>
On Wed, Oct 21, 2020 at 7:42 PM Nick Desaulniers
<ndesaulniers@google.com> wrote:
>
> If you used some of the macros from
> include/linux/compiler_attributes.h like __section and __aligned, I
> would prefer it. Please consider spelling out __attribute__(()) an
> antipattern.
+1, the shorthands should be used unless there is a reason not to (and
please write the reason in a comment in that case).
Cheers,
Miguel
next prev parent reply other threads:[~2020-10-21 17:54 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-29 0:31 [sched] c3a340f7e7: invalid_opcode:#[##] kernel test robot
2020-06-29 0:31 ` kernel test robot
2020-06-30 12:46 ` Peter Zijlstra
2020-06-30 12:46 ` Peter Zijlstra
2020-06-30 13:55 ` Rasmus Villemoes
2020-06-30 13:55 ` Rasmus Villemoes
2020-06-30 14:02 ` Peter Zijlstra
2020-06-30 14:02 ` Peter Zijlstra
2020-06-30 14:11 ` Peter Zijlstra
2020-06-30 14:11 ` Peter Zijlstra
2020-06-30 14:35 ` Peter Zijlstra
2020-06-30 14:35 ` Peter Zijlstra
2020-06-30 14:49 ` Peter Zijlstra
2020-06-30 14:49 ` Peter Zijlstra
2020-07-09 8:45 ` [tip: sched/core] sched, vmlinux.lds: Increase STRUCT_ALIGNMENT to 64 bytes for GCC-4.9 tip-bot2 for Peter Zijlstra
2020-10-20 23:39 ` [sched] c3a340f7e7: invalid_opcode:#[##] Florian Fainelli
2020-10-21 8:00 ` GCC section alignment, and GCC-4.9 being a weird one Peter Zijlstra
2020-10-21 13:18 ` Jakub Jelinek
2020-10-21 13:44 ` Peter Zijlstra
2020-10-21 17:42 ` Nick Desaulniers
2020-10-21 17:54 ` Miguel Ojeda [this message]
2020-10-21 18:35 ` Joe Perches
2020-10-21 18:35 ` [Linux-kernel-mentees] " Joe Perches
2020-10-21 19:27 ` Miguel Ojeda
2020-10-21 19:27 ` [Linux-kernel-mentees] " Miguel Ojeda
2020-10-22 7:38 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANiq72m+_QYtn_1gyrjXFs6yeDdiMoS4DVcWqYcTgyCFnSFXbw@mail.gmail.com \
--to=miguel.ojeda.sandonis@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=hjl.tools@gmail.com \
--cc=jakub@redhat.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-toolchains@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=lkp@intel.com \
--cc=lkp@lists.01.org \
--cc=ndesaulniers@google.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.