From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f174.google.com (mail-yw1-f174.google.com [209.85.128.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 67E1FA47 for ; Sat, 7 Jan 2023 21:02:50 +0000 (UTC) Received: by mail-yw1-f174.google.com with SMTP id 00721157ae682-4c7d35b37e2so9479797b3.2 for ; Sat, 07 Jan 2023 13:02:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=JmL5h/5f9ZKkHhV7ji7KKVGJQTUq0yPHfnhiMRhXed0=; b=IK5dGKTx88W2mfNkdSbqWACqkjubhVS9N14mCOb6xiNrTRTmnuplQafYC0im+wGspK eOYeaF0MULlk8xs1MhOKyABR+2n5mu7ywO33aNQ9VX4GMkdSdCVqflFNfkdkPvE907aV AbMRlhdfsnbXDXTGbNIAQfaGPRPsPMo8biAT31OQE9sPB82/31f0is5EfnCupoTz/Ke+ 5qPrTwyq0HpYK24udJ89pRlkE2Z5QaSlpexv9uCe2Y49IpPc0IVSTp5co8YZkKYLFYOl z+xqA+ASKB1ZQdTTr7sECFdnwcqnzJz4QBV2ycEBNoSYjk2aEYooKDaJopPZvE6w6Z6k Ar3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=JmL5h/5f9ZKkHhV7ji7KKVGJQTUq0yPHfnhiMRhXed0=; b=UytvHN9FD/6C+XdXXIYkNd0v8/gc2jxyAp/w2OhEeyLbxo8rnOn2k6fRh03rTI71zm FEg7Fdt9HdHKrOIzv3hRZPgF500rDPuyGoHpyMBR2ArOPNh6p9JsKNFGSz/bN1e60ahB FIqMpiCiKfh2ASj9gd2vtDyBHTtiq0b2a97w9k2jNdGiMbM3h+uLdN+hqh1aRlwPVWnR 1TXhYq3d3AnB6lnqdlatnYx/79Xb9uGIeLTfpBu9n7uybmvn+Krieugz6uOVtERRilil q6WU6tPIa7vD82Y/XsoQp/xr26QGM/k3c/d6pVbxgOZumSY8zcg7gRbz00WtFwwKb0E/ HAOg== X-Gm-Message-State: AFqh2kqTT9/18jNKPxtiQhx+To3SzFkaXLskm40o5M7fG0copdurs6NO 5yjGscpnYk3FpIhsB9JhCsg/3+WWp6+ZbRiE/6I= X-Google-Smtp-Source: AMrXdXvY/st+xuDrW4znKkHpZttsCvsZGZkx5Bw3ldG/KbixkSHtRzf/+VMAvkN/c9NxoWqjkDvGG4OpHXXkd75XJ3w= X-Received: by 2002:a81:484f:0:b0:3ed:90d2:2ab8 with SMTP id v76-20020a81484f000000b003ed90d22ab8mr582273ywa.67.1673125369382; Sat, 07 Jan 2023 13:02:49 -0800 (PST) Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20230107-sam-video-backlight-drop-fb_blank-v1-0-1bd9bafb351f@ravnborg.org> <20230107-sam-video-backlight-drop-fb_blank-v1-12-1bd9bafb351f@ravnborg.org> In-Reply-To: <20230107-sam-video-backlight-drop-fb_blank-v1-12-1bd9bafb351f@ravnborg.org> From: Miguel Ojeda Date: Sat, 7 Jan 2023 22:02:38 +0100 Message-ID: Subject: Re: [PATCH 12/15] auxdisplay: ht16k33: Introduce backlight_get_brightness() To: sam@ravnborg.org, Stephen Kitt Cc: Nicolas Ferre , Helge Deller , Alexandre Belloni , Claudiu Beznea , Antonino Daplas , Benjamin Herrenschmidt , Paul Mackerras , Greg Kroah-Hartman , Robin van der Gracht , Miguel Ojeda , Lee Jones , Daniel Thompson , Jingoo Han , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-staging@lists.linux.dev, linuxppc-dev@lists.ozlabs.org, Geert Uytterhoeven Content-Type: text/plain; charset="UTF-8" On Sat, Jan 7, 2023 at 7:26 PM Sam Ravnborg via B4 Submission Endpoint wrote: > > Introduce backlight_get_brightness() to simplify logic > and avoid direct access to backlight properties. Note: Stephen sent this one too a while ago (with some more details in the commit message, which is always nice); and then he sent yesterday v2 [1] (to mention the functional change with `BL_CORE_SUSPENDED` [2]). Anyway, if it goes via drm-misc, feel free to have my: Acked-by: Miguel Ojeda Though it would be nice to have Robin test the change. Thanks! [1] https://lore.kernel.org/lkml/20230106143002.1434266-1-steve@sk2.org/ [2] https://lore.kernel.org/lkml/CANiq72kRhmT37H1FAGYGny83ONYXeqJuO8ZPbym0ajQOWKY4Kw@mail.gmail.com/ Cheers, Miguel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 018DCC54EBC for ; Sat, 7 Jan 2023 21:03:50 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4NqCP11mS3z3cFd for ; Sun, 8 Jan 2023 08:03:49 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=IK5dGKTx; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:4864:20::112a; helo=mail-yw1-x112a.google.com; envelope-from=miguel.ojeda.sandonis@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=IK5dGKTx; dkim-atps=neutral Received: from mail-yw1-x112a.google.com (mail-yw1-x112a.google.com [IPv6:2607:f8b0:4864:20::112a]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4NqCN00rLMz2xHT for ; Sun, 8 Jan 2023 08:02:53 +1100 (AEDT) Received: by mail-yw1-x112a.google.com with SMTP id 00721157ae682-4a0d6cb12c5so65892357b3.7 for ; Sat, 07 Jan 2023 13:02:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=JmL5h/5f9ZKkHhV7ji7KKVGJQTUq0yPHfnhiMRhXed0=; b=IK5dGKTx88W2mfNkdSbqWACqkjubhVS9N14mCOb6xiNrTRTmnuplQafYC0im+wGspK eOYeaF0MULlk8xs1MhOKyABR+2n5mu7ywO33aNQ9VX4GMkdSdCVqflFNfkdkPvE907aV AbMRlhdfsnbXDXTGbNIAQfaGPRPsPMo8biAT31OQE9sPB82/31f0is5EfnCupoTz/Ke+ 5qPrTwyq0HpYK24udJ89pRlkE2Z5QaSlpexv9uCe2Y49IpPc0IVSTp5co8YZkKYLFYOl z+xqA+ASKB1ZQdTTr7sECFdnwcqnzJz4QBV2ycEBNoSYjk2aEYooKDaJopPZvE6w6Z6k Ar3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=JmL5h/5f9ZKkHhV7ji7KKVGJQTUq0yPHfnhiMRhXed0=; b=q1QQoQOAkgsoQYe0Jz4JGRw+1TpJ/6RyxUBT61C/nb9SxUN7pV2u9VXPjyfnV2VmCM 9BP+QdEmE2BOTGZALzx0ju3bkxgUi+/9ezs5amd5eNY5ISdKrKwXrV/NRePBGbbs69X3 pOkbHBo9LING2XF8k/6P0fvCm7UkKDavgenhO+EWriNcdn1b8/UF1+2CeOWrDdqJ1s7S IzvMqniWq/+LKLpj8scm2uxpJXBd4u+0wZLMXr2y5Qr1YEoC1nS8OAqb8T6VblGFV+HI 0XDUZ2gblAbiQ66t30K7tb8fo0Hq5n/8b6HDP8NUz5/9xWQ+UfdbV5vzd7klXihN6KzZ 0utQ== X-Gm-Message-State: AFqh2kqo3SN5ENehW2HBywzvmHjMsK4Wp2oZWnVJgTxDf9E+96uWhDhX 7kuQrAkqpvJqNXmO875eanS87pMFg0MsROuG2Os= X-Google-Smtp-Source: AMrXdXvY/st+xuDrW4znKkHpZttsCvsZGZkx5Bw3ldG/KbixkSHtRzf/+VMAvkN/c9NxoWqjkDvGG4OpHXXkd75XJ3w= X-Received: by 2002:a81:484f:0:b0:3ed:90d2:2ab8 with SMTP id v76-20020a81484f000000b003ed90d22ab8mr582273ywa.67.1673125369382; Sat, 07 Jan 2023 13:02:49 -0800 (PST) MIME-Version: 1.0 References: <20230107-sam-video-backlight-drop-fb_blank-v1-0-1bd9bafb351f@ravnborg.org> <20230107-sam-video-backlight-drop-fb_blank-v1-12-1bd9bafb351f@ravnborg.org> In-Reply-To: <20230107-sam-video-backlight-drop-fb_blank-v1-12-1bd9bafb351f@ravnborg.org> From: Miguel Ojeda Date: Sat, 7 Jan 2023 22:02:38 +0100 Message-ID: Subject: Re: [PATCH 12/15] auxdisplay: ht16k33: Introduce backlight_get_brightness() To: sam@ravnborg.org, Stephen Kitt Content-Type: text/plain; charset="UTF-8" X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexandre Belloni , linux-omap@vger.kernel.org, Antonino Daplas , Robin van der Gracht , Helge Deller , Lee Jones , linux-staging@lists.linux.dev, Nicolas Ferre , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Jingoo Han , Paul Mackerras , linux-fbdev@vger.kernel.org, Greg Kroah-Hartman , Miguel Ojeda , Geert Uytterhoeven , Daniel Thompson , linuxppc-dev@lists.ozlabs.org, Claudiu Beznea , linux-arm-kernel@lists.infradead.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Sat, Jan 7, 2023 at 7:26 PM Sam Ravnborg via B4 Submission Endpoint wrote: > > Introduce backlight_get_brightness() to simplify logic > and avoid direct access to backlight properties. Note: Stephen sent this one too a while ago (with some more details in the commit message, which is always nice); and then he sent yesterday v2 [1] (to mention the functional change with `BL_CORE_SUSPENDED` [2]). Anyway, if it goes via drm-misc, feel free to have my: Acked-by: Miguel Ojeda Though it would be nice to have Robin test the change. Thanks! [1] https://lore.kernel.org/lkml/20230106143002.1434266-1-steve@sk2.org/ [2] https://lore.kernel.org/lkml/CANiq72kRhmT37H1FAGYGny83ONYXeqJuO8ZPbym0ajQOWKY4Kw@mail.gmail.com/ Cheers, Miguel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9BC42C46467 for ; Sat, 7 Jan 2023 21:04:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=BRUCddFeVSNgMrLF5fjrzHVfyAXmwFPd5JJwbSfUqLY=; b=DlDBme9rlwsVIB hMWLUn/k8fKoGpwuV0oxgSn2lF2FD4eqdev5wTNsDPujcwbffmgxknvEFxTTCIORqDPVvjTTH+/qH TZiS35HSjuCMDbaWKd3FnRQxKXgNVzFZsZA5vUc2vqKEfQD/JxTj8xOBXud7+yxurbrcPEIYk/Cjr TuF23LkgyOT6sSFDuJuOFCUbQ0gUle0ryai1vsF+5OOnXQnYn7DOLbA7Mcgv0a35+sOylzPJyFpFb 06v0wyOJDHfCyoVWTewY02e+gixKjFOhCAknEkw7gYZ1LDwNX/ZWYVpE5OdAtsjlPEdqr4GilA8Tp 2WF4TQf5iX3DNBmEfslw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pEGLC-008Nil-1n; Sat, 07 Jan 2023 21:02:58 +0000 Received: from mail-yw1-x112f.google.com ([2607:f8b0:4864:20::112f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pEGL6-008Nhm-ID for linux-arm-kernel@lists.infradead.org; Sat, 07 Jan 2023 21:02:55 +0000 Received: by mail-yw1-x112f.google.com with SMTP id 00721157ae682-4a2f8ad29d5so65766517b3.8 for ; Sat, 07 Jan 2023 13:02:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=JmL5h/5f9ZKkHhV7ji7KKVGJQTUq0yPHfnhiMRhXed0=; b=IK5dGKTx88W2mfNkdSbqWACqkjubhVS9N14mCOb6xiNrTRTmnuplQafYC0im+wGspK eOYeaF0MULlk8xs1MhOKyABR+2n5mu7ywO33aNQ9VX4GMkdSdCVqflFNfkdkPvE907aV AbMRlhdfsnbXDXTGbNIAQfaGPRPsPMo8biAT31OQE9sPB82/31f0is5EfnCupoTz/Ke+ 5qPrTwyq0HpYK24udJ89pRlkE2Z5QaSlpexv9uCe2Y49IpPc0IVSTp5co8YZkKYLFYOl z+xqA+ASKB1ZQdTTr7sECFdnwcqnzJz4QBV2ycEBNoSYjk2aEYooKDaJopPZvE6w6Z6k Ar3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=JmL5h/5f9ZKkHhV7ji7KKVGJQTUq0yPHfnhiMRhXed0=; b=LBQIhUpHACi0o8+et//5+I8YWGHKA3AaRtj63SazRNx6GED2F3Tezq0iWYqhm40wmH XSYbWMJd+jAvzLza3gvmMFubzfy4jd3y67MAQsWwAySYJxFXqZf8QYBPlqhv/lWCiLV4 aOoMo2RWckFgNhiPDrsM5dvTqjx45HB6ERiN4YefJEvqWmeRj8RJA00tRvdlAJ2Harwv rnO0YdvVVVyhkgadogoxMAPh8btT2Y6mC/N4H9gO/jPpLTckSRZVATdJvp2KVVEH0LHk qSQIpXfANLf/8KzQwne7yBOIofurM1Rn3mZ7pXOZqDGWR31UTIQ7wM0OuPCNXCxQwYzV XHpw== X-Gm-Message-State: AFqh2kqkNVaxeCunEVvLIWvJ1b/jt+DA2/IJFsiczUuAXDQlnQzYeeVu 6ib0HKtGiK45BDY6ftEwkv498jFTA04z+P+vEFQ= X-Google-Smtp-Source: AMrXdXvY/st+xuDrW4znKkHpZttsCvsZGZkx5Bw3ldG/KbixkSHtRzf/+VMAvkN/c9NxoWqjkDvGG4OpHXXkd75XJ3w= X-Received: by 2002:a81:484f:0:b0:3ed:90d2:2ab8 with SMTP id v76-20020a81484f000000b003ed90d22ab8mr582273ywa.67.1673125369382; Sat, 07 Jan 2023 13:02:49 -0800 (PST) MIME-Version: 1.0 References: <20230107-sam-video-backlight-drop-fb_blank-v1-0-1bd9bafb351f@ravnborg.org> <20230107-sam-video-backlight-drop-fb_blank-v1-12-1bd9bafb351f@ravnborg.org> In-Reply-To: <20230107-sam-video-backlight-drop-fb_blank-v1-12-1bd9bafb351f@ravnborg.org> From: Miguel Ojeda Date: Sat, 7 Jan 2023 22:02:38 +0100 Message-ID: Subject: Re: [PATCH 12/15] auxdisplay: ht16k33: Introduce backlight_get_brightness() To: sam@ravnborg.org, Stephen Kitt X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230107_130254_089981_09E8583F X-CRM114-Status: UNSURE ( 8.81 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexandre Belloni , linux-omap@vger.kernel.org, Antonino Daplas , Robin van der Gracht , Benjamin Herrenschmidt , Helge Deller , Lee Jones , linux-staging@lists.linux.dev, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Jingoo Han , Paul Mackerras , linux-fbdev@vger.kernel.org, Greg Kroah-Hartman , Miguel Ojeda , Geert Uytterhoeven , Daniel Thompson , linuxppc-dev@lists.ozlabs.org, Claudiu Beznea , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Jan 7, 2023 at 7:26 PM Sam Ravnborg via B4 Submission Endpoint wrote: > > Introduce backlight_get_brightness() to simplify logic > and avoid direct access to backlight properties. Note: Stephen sent this one too a while ago (with some more details in the commit message, which is always nice); and then he sent yesterday v2 [1] (to mention the functional change with `BL_CORE_SUSPENDED` [2]). Anyway, if it goes via drm-misc, feel free to have my: Acked-by: Miguel Ojeda Though it would be nice to have Robin test the change. Thanks! [1] https://lore.kernel.org/lkml/20230106143002.1434266-1-steve@sk2.org/ [2] https://lore.kernel.org/lkml/CANiq72kRhmT37H1FAGYGny83ONYXeqJuO8ZPbym0ajQOWKY4Kw@mail.gmail.com/ Cheers, Miguel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel