From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15D9BCA9EA9 for ; Sat, 19 Oct 2019 00:22:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D093A222C2 for ; Sat, 19 Oct 2019 00:22:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SJhBGhz9" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391179AbfJSAV5 (ORCPT ); Fri, 18 Oct 2019 20:21:57 -0400 Received: from mail-lf1-f65.google.com ([209.85.167.65]:39262 "EHLO mail-lf1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729709AbfJSAV5 (ORCPT ); Fri, 18 Oct 2019 20:21:57 -0400 Received: by mail-lf1-f65.google.com with SMTP id 195so5927646lfj.6 for ; Fri, 18 Oct 2019 17:21:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ZqICylESWKf0IpOr+KHkluRNlL0wf5TguV6mXdP4QGA=; b=SJhBGhz9kYlPN0TADnvJp8G2Y17kwQLx8bFgEQxXC4oPBXVPQajIkOkF46KrnCk3Y+ SIhUxsEMZpo0mO71reWB5iYnGBSvSPpnlhJ7SOGmsAzO1r/eCW2htdVksbO0SI9DIYUV omVMOJI5aJQYPBTuWOcF+vN49kJ/Z38IZ5w69/IWpI0dZkus3V70HRJmjzixpNFSsrH7 zFdeP18no8PweXdELrMKy1nvLYeUemGKl7HG8j1bU8GRNXdqGvneSPtLFgWbG2ZCxBd6 JFKB+kpkVv5yQiadF2KjhDCmed79/Dn/ssCkl2cq1nYz+heSuFAzelrZNVV5W1OmMhq6 qcQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ZqICylESWKf0IpOr+KHkluRNlL0wf5TguV6mXdP4QGA=; b=hyBcVplsw+betlEz7hcXS3YcNuP1/FAFrqZPSqfLijkvqcXQ5SQ+P1J/L0WOWdm+gD jaCM9MhHV+XdSB7HjuXa/8k0cTMda11pktbUOjsSDnUg2yqm6CvyV2m+1MsONYae+6qp 8Sxqxcs35mZmbYAzfstyndpXWzL71i02O2MJpaa5MjloC18AUMnkrZ0ZVbHMAShApxPN EyQ+aghXUu1va3n0/gGXuiUu3dVpG7TQDL+H8QGyJVqAjoXsWkMki4fv2fXNS0uSpH7U oUSvJ1FYZkTyllry6kdkpAvskoNLQLtKKGHXuho3EdcrUnOdbsNppWdFfnUzRHNEmPAY Y5CA== X-Gm-Message-State: APjAAAUbe6JZlAojD62y8xf7GGarNv5vBHFecETrhqyqDYaOJ8NzvWBz unRkFC4vJ4uK1Wtf53v44rOvEvLGv6E8rcIb7sM= X-Google-Smtp-Source: APXvYqxT5yYNPjiMSlzwumlj8UjSOAfCmDmgAcpOZOM10R//Skv4aoDktplFaX7g2Ws72X/gbHtxdVXSSeajbRTRouQ= X-Received: by 2002:ac2:55b4:: with SMTP id y20mr7590271lfg.173.1571444515448; Fri, 18 Oct 2019 17:21:55 -0700 (PDT) MIME-Version: 1.0 References: <20191018161033.261971-1-samitolvanen@google.com> <20191018161033.261971-7-samitolvanen@google.com> In-Reply-To: From: Miguel Ojeda Date: Sat, 19 Oct 2019 02:21:44 +0200 Message-ID: Subject: Re: [PATCH 06/18] add support for Clang's Shadow Call Stack (SCS) To: Nick Desaulniers Cc: Sami Tolvanen , Will Deacon , Catalin Marinas , Steven Rostedt , Ard Biesheuvel , Dave Martin , Kees Cook , Laura Abbott , Mark Rutland , clang-built-linux , Kernel Hardening , Linux ARM , LKML Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 18, 2019 at 10:33 PM Nick Desaulniers wrote: > > Sami pointed out to me off thread that __has_attribute would only > check `no_sanitize`, not `shadow-call-stack`. So maybe best to keep > the definition here (include/linux/compiler-clang.h), but wrapped in a > `__has_feature` check so that Clang 6.0 doesn't start complaining. Ah, good point -- agreed! Cheers, Miguel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5573BCA9EA9 for ; Sat, 19 Oct 2019 00:22:06 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 238B9222CC for ; Sat, 19 Oct 2019 00:22:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Vgpk80wv"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SJhBGhz9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 238B9222CC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=dO8BrfdgZ4drphLBMuJunAKL5h5cy3RK6HLExVuv0Qg=; b=Vgpk80wvk+lc8f bx11qUpWysVjbkoqvjTpp/vkHh9K+EsBmFqZiFgvQ2oLnXQNejyDMR61PUySLs6hQjN++QjwmgdKM vj6o8HtdBHrUTFmCtpPYTDgFLodxPfrKh44+QWohseGjXWk2dPXX3bQyPqd+ndvtE7e3xS5ukwUNd gQljbs0QDXhM3/ototS1YQ7e7k9/rtFXSwqHLlywWQ1f2U/WMdJ7LNZ/i9eui1aI2IhDjfiSPtcSY mmE40bdB3/nIwR+mDOjiFMO6VzplSBSnFnFvuKZbXxiph7bZeH4tSTe8vdgx/ohwPVPx1tnulSt+C arTPAVb2tL4uREscqYYQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iLcVM-00020R-Rm; Sat, 19 Oct 2019 00:22:00 +0000 Received: from mail-lf1-x142.google.com ([2a00:1450:4864:20::142]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iLcVJ-0001zx-Jm for linux-arm-kernel@lists.infradead.org; Sat, 19 Oct 2019 00:21:58 +0000 Received: by mail-lf1-x142.google.com with SMTP id y127so5961659lfc.0 for ; Fri, 18 Oct 2019 17:21:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ZqICylESWKf0IpOr+KHkluRNlL0wf5TguV6mXdP4QGA=; b=SJhBGhz9kYlPN0TADnvJp8G2Y17kwQLx8bFgEQxXC4oPBXVPQajIkOkF46KrnCk3Y+ SIhUxsEMZpo0mO71reWB5iYnGBSvSPpnlhJ7SOGmsAzO1r/eCW2htdVksbO0SI9DIYUV omVMOJI5aJQYPBTuWOcF+vN49kJ/Z38IZ5w69/IWpI0dZkus3V70HRJmjzixpNFSsrH7 zFdeP18no8PweXdELrMKy1nvLYeUemGKl7HG8j1bU8GRNXdqGvneSPtLFgWbG2ZCxBd6 JFKB+kpkVv5yQiadF2KjhDCmed79/Dn/ssCkl2cq1nYz+heSuFAzelrZNVV5W1OmMhq6 qcQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ZqICylESWKf0IpOr+KHkluRNlL0wf5TguV6mXdP4QGA=; b=QofdKEO7hYlzuMpEDnte5SbAigXizOCVTwMD/Uuln/4smWDK0ydvkXMDqqH4bEia2j I+3ToWkDx+6ID/na57Irtt0wb8N3QEXTqoC8VlnXYUDV7hmIC1YLP1Qh2Pa9yftoRpIh ICTI8RSjsry1HwcIQhuAz7ZMrdhBU1vjxirRqTjOvkXmBX9tLtMntcaneufH63o//rf9 sWGars8QMwccCWgsAJCsAskyYmfI44zMZuxNwbE63lx+WfYBwzNqXbtyJXbDLfbwqn9/ xtHXYyphXXYQ+XfmWKT/EhqKW/ZfNBRXelwti0BQnb6lfvMYcuUBgtq2klDQHTI6xDVn hN2g== X-Gm-Message-State: APjAAAUd80XLi3DuPqEuU6IxJXLrE2yPfWbD6weTRKCNgxbcRkdqWNth HcXhkKQ7mlW9qSVhUBMcIg+ytRrAEGg2SP5Rkvs= X-Google-Smtp-Source: APXvYqxT5yYNPjiMSlzwumlj8UjSOAfCmDmgAcpOZOM10R//Skv4aoDktplFaX7g2Ws72X/gbHtxdVXSSeajbRTRouQ= X-Received: by 2002:ac2:55b4:: with SMTP id y20mr7590271lfg.173.1571444515448; Fri, 18 Oct 2019 17:21:55 -0700 (PDT) MIME-Version: 1.0 References: <20191018161033.261971-1-samitolvanen@google.com> <20191018161033.261971-7-samitolvanen@google.com> In-Reply-To: From: Miguel Ojeda Date: Sat, 19 Oct 2019 02:21:44 +0200 Message-ID: Subject: Re: [PATCH 06/18] add support for Clang's Shadow Call Stack (SCS) To: Nick Desaulniers X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191018_172157_678180_AE5312D7 X-CRM114-Status: UNSURE ( 8.56 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Kees Cook , Ard Biesheuvel , Catalin Marinas , Kernel Hardening , LKML , Steven Rostedt , clang-built-linux , Sami Tolvanen , Laura Abbott , Will Deacon , Dave Martin , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Oct 18, 2019 at 10:33 PM Nick Desaulniers wrote: > > Sami pointed out to me off thread that __has_attribute would only > check `no_sanitize`, not `shadow-call-stack`. So maybe best to keep > the definition here (include/linux/compiler-clang.h), but wrapped in a > `__has_feature` check so that Clang 6.0 doesn't start complaining. Ah, good point -- agreed! Cheers, Miguel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F35CCCA9EA9 for ; Sat, 19 Oct 2019 00:22:14 +0000 (UTC) Received: from mother.openwall.net (mother.openwall.net [195.42.179.200]) by mail.kernel.org (Postfix) with SMTP id 4680E222C2 for ; Sat, 19 Oct 2019 00:22:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SJhBGhz9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4680E222C2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kernel-hardening-return-17060-kernel-hardening=archiver.kernel.org@lists.openwall.com Received: (qmail 9268 invoked by uid 550); 19 Oct 2019 00:22:07 -0000 Mailing-List: contact kernel-hardening-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Received: (qmail 9250 invoked from network); 19 Oct 2019 00:22:06 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ZqICylESWKf0IpOr+KHkluRNlL0wf5TguV6mXdP4QGA=; b=SJhBGhz9kYlPN0TADnvJp8G2Y17kwQLx8bFgEQxXC4oPBXVPQajIkOkF46KrnCk3Y+ SIhUxsEMZpo0mO71reWB5iYnGBSvSPpnlhJ7SOGmsAzO1r/eCW2htdVksbO0SI9DIYUV omVMOJI5aJQYPBTuWOcF+vN49kJ/Z38IZ5w69/IWpI0dZkus3V70HRJmjzixpNFSsrH7 zFdeP18no8PweXdELrMKy1nvLYeUemGKl7HG8j1bU8GRNXdqGvneSPtLFgWbG2ZCxBd6 JFKB+kpkVv5yQiadF2KjhDCmed79/Dn/ssCkl2cq1nYz+heSuFAzelrZNVV5W1OmMhq6 qcQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ZqICylESWKf0IpOr+KHkluRNlL0wf5TguV6mXdP4QGA=; b=PsZxRNCdrNFL3oP5cq5texO90rTzFgvkiQ/qhzuOBRGwI93WZDfKlQxsvL5e8n4xph r0wInzEMDIcelMw0kn8L68qjsu13l8Fdm8HQzQQMQOjFQSsMEsR3MKZs7cxVdvj2KONl 4ciiB6tC03Vhy29HpNwUb6zINqKRxg/xZrA0DviQGd55ITXFMRv9nefynyrcX15LbgdP ptKaHMZ93k2PPNOp5zjpuRtm7InbsJv7urC+MonE7Kso+Sk4JYcD7I0ANzvfy3k+3ts5 i/ZslF3LcD7Enm56V2Ow568cZf7xksDIdVrRx7ljpj2IbUr8n4r0VQ7NNDI0glQLAFbF mBWw== X-Gm-Message-State: APjAAAVhKoCkM0E6MVell8uT+ovCeqMufOub2QN36SXw9fMzEQXBnY51 WQZboCD2mEjWJkIvZ2g30mpYrORwJg63KPYb64E= X-Google-Smtp-Source: APXvYqxT5yYNPjiMSlzwumlj8UjSOAfCmDmgAcpOZOM10R//Skv4aoDktplFaX7g2Ws72X/gbHtxdVXSSeajbRTRouQ= X-Received: by 2002:ac2:55b4:: with SMTP id y20mr7590271lfg.173.1571444515448; Fri, 18 Oct 2019 17:21:55 -0700 (PDT) MIME-Version: 1.0 References: <20191018161033.261971-1-samitolvanen@google.com> <20191018161033.261971-7-samitolvanen@google.com> In-Reply-To: From: Miguel Ojeda Date: Sat, 19 Oct 2019 02:21:44 +0200 Message-ID: Subject: Re: [PATCH 06/18] add support for Clang's Shadow Call Stack (SCS) To: Nick Desaulniers Cc: Sami Tolvanen , Will Deacon , Catalin Marinas , Steven Rostedt , Ard Biesheuvel , Dave Martin , Kees Cook , Laura Abbott , Mark Rutland , clang-built-linux , Kernel Hardening , Linux ARM , LKML Content-Type: text/plain; charset="UTF-8" On Fri, Oct 18, 2019 at 10:33 PM Nick Desaulniers wrote: > > Sami pointed out to me off thread that __has_attribute would only > check `no_sanitize`, not `shadow-call-stack`. So maybe best to keep > the definition here (include/linux/compiler-clang.h), but wrapped in a > `__has_feature` check so that Clang 6.0 doesn't start complaining. Ah, good point -- agreed! Cheers, Miguel