From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C5EBC46467 for ; Thu, 19 Jan 2023 19:21:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231493AbjASTVZ (ORCPT ); Thu, 19 Jan 2023 14:21:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60936 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229771AbjASTU6 (ORCPT ); Thu, 19 Jan 2023 14:20:58 -0500 Received: from mail-yw1-x112f.google.com (mail-yw1-x112f.google.com [IPv6:2607:f8b0:4864:20::112f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5388F9CBB5; Thu, 19 Jan 2023 11:20:08 -0800 (PST) Received: by mail-yw1-x112f.google.com with SMTP id 00721157ae682-4fda31c3351so12357377b3.11; Thu, 19 Jan 2023 11:20:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=2y96hSgZOdNiQi3iVUDGW1zmbq/2ZeqfDpIjbWl/+AM=; b=ReQBSuZnjQ/Hzn9MjrayyI00pkEWhj7Djpqlg/g38iGqjIo4Sq7re3LPR5NKsWo9Nm rmijSW7CCq1C2Qdp7/ky7GCkKbPD6xEDKXk305vsRjjmvhP21tX3QKgIjkm4F3ckbHnU 3rsLopUK6HQfuzAeTV8Gfeem6hCoLYXkKH10aIMTpV67Itec0/0QpXWGecCbZyWvBxWi HMb29GK2QtB8DekCsdq6oAVcEzk4KtxgxCvfmYU+Dt+rTUuSwLkYqHnEr/te+cjWSrxM NZ3B4MJ4fDhLb0uqTI/T9CcOhWI9zQWWGgQxqW0IustVc/+u90vkW/tlIPMHHewHNDmv Ynbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=2y96hSgZOdNiQi3iVUDGW1zmbq/2ZeqfDpIjbWl/+AM=; b=s47YwG/hj2TSxc9ceJNIXtcSGSptBOHvndYZieGB6XQmaQtL3z/iBAbCTWu1cWNkum dzmceLzNiNz7kJc40IwB8wp/olu7YWJq0RvM5dPbLrsa8V82ZlKln+i6PvA5k122KlMm 3LR62dN8D52KwrKalMlVe66mibNGcV6PyFalaPTLT26DvPW+iLxaGK3gpG8HB4cn7qnL sKDaOULv4x36GF4IYvmKHpXgpNx91IdVBowJ9uYuahtyhrYqCw+fnhGDlWfbGUSdz1NB Umw51BHSkdm7RhCb1X2waM0uS3dbnU63eHq0WaC5D6zlLk5IdD34c6QFVX8Qof+y6T3U KzlQ== X-Gm-Message-State: AFqh2kpnDO9Js3SdTficsXztiMDjDC+y7PGzoWHV4O8uHpI9K5PIciwP 7G/ZV0Jednc9CQukPTFuKMo9q1rMS09n0SViP1w= X-Google-Smtp-Source: AMrXdXuhMbeLfhMzO3dNO8FM0BS93W/XkG/FHlqBpBtG6GK7C62jMILFqgYHbTQjwIRvsrMCEslAihTwcRRHs+ouDnU= X-Received: by 2002:a81:5402:0:b0:3d8:8c0e:6d48 with SMTP id i2-20020a815402000000b003d88c0e6d48mr1018356ywb.462.1674156007567; Thu, 19 Jan 2023 11:20:07 -0800 (PST) MIME-Version: 1.0 References: <20230111161155.1349375-1-gary@garyguo.net> <20230112214059.o4vq474c47edjup6@ldmartin-desk2> <20230113181841.4d378a24.gary@garyguo.net> <20230117175144.GI16547@kitsune.suse.cz> <20230117192059.z5v5lfc2bzxk4ad2@ldmartin-desk2.lan> In-Reply-To: From: Miguel Ojeda Date: Thu, 19 Jan 2023 20:19:56 +0100 Message-ID: Subject: Re: [PATCH] modpost: support arbitrary symbol length in modversion To: Masahiro Yamada Cc: Lucas De Marchi , =?UTF-8?Q?Michal_Such=C3=A1nek?= , Gary Guo , Kees Cook , linux-kbuild@vger.kernel.org, Wedson Almeida Filho , Joel Stanley , Alex Gaynor , Miguel Ojeda , Wedson Almeida Filho , Nicolas Schier , rust-for-linux@vger.kernel.org, Guo Zhengkui , Boqun Feng , Nicholas Piggin , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= , Nathan Chancellor , Nick Desaulniers , linux-kernel@vger.kernel.org, Julia Lawall , Luis Chamberlain , linuxppc-dev@lists.ozlabs.org, linux-modules@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: On Wed, Jan 18, 2023 at 8:02 AM Masahiro Yamada wrote: > > - *.mod.c is kept human readable. On the topic of `.mod.c` readability: for approaches that may be less readable, we could improve that by adding some extra comments or rearrange things in a different way (it is a generated file, after all!). For instance, for the original approach: https://godbolt.org/z/6oh45axnc Cheers, Miguel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0E071C46467 for ; Thu, 19 Jan 2023 19:21:53 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4NyXYq2pvSz3fHs for ; Fri, 20 Jan 2023 06:21:51 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=ReQBSuZn; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:4864:20::112f; helo=mail-yw1-x112f.google.com; envelope-from=miguel.ojeda.sandonis@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=ReQBSuZn; dkim-atps=neutral Received: from mail-yw1-x112f.google.com (mail-yw1-x112f.google.com [IPv6:2607:f8b0:4864:20::112f]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4NyXWv50DPz3fGr for ; Fri, 20 Jan 2023 06:20:10 +1100 (AEDT) Received: by mail-yw1-x112f.google.com with SMTP id 00721157ae682-4e4a6af2d99so41836127b3.4 for ; Thu, 19 Jan 2023 11:20:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=2y96hSgZOdNiQi3iVUDGW1zmbq/2ZeqfDpIjbWl/+AM=; b=ReQBSuZnjQ/Hzn9MjrayyI00pkEWhj7Djpqlg/g38iGqjIo4Sq7re3LPR5NKsWo9Nm rmijSW7CCq1C2Qdp7/ky7GCkKbPD6xEDKXk305vsRjjmvhP21tX3QKgIjkm4F3ckbHnU 3rsLopUK6HQfuzAeTV8Gfeem6hCoLYXkKH10aIMTpV67Itec0/0QpXWGecCbZyWvBxWi HMb29GK2QtB8DekCsdq6oAVcEzk4KtxgxCvfmYU+Dt+rTUuSwLkYqHnEr/te+cjWSrxM NZ3B4MJ4fDhLb0uqTI/T9CcOhWI9zQWWGgQxqW0IustVc/+u90vkW/tlIPMHHewHNDmv Ynbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=2y96hSgZOdNiQi3iVUDGW1zmbq/2ZeqfDpIjbWl/+AM=; b=uU4c4xG+tzEiqwnzNy/yRFtJ9ZK2WoTNkxF7EA7ID8ZXL9o510fxBQzYdiLWeAJLso AhDvKCZtlrt8IR93muAIBWJBIqUR0L0RkuZxeno6fnKw+fTkds+KS+TgB5YY12ASg2pu snvsW40vVmnZkoVty2H+nO6IcXCct2l+kCglF1rVaNAS7wrVQCk3DUGThHtTJexUzRUw GsdI/gMiKKi7ZCqgkir+NIJI0edaU7vWXoGtcOZyBxAQ7zj7RWLSYosqRiGKm3NChc22 dpzFoKUHvUbQbXMdXLQWf2+hJmWGGwdrLFfeyl8g+92lRvY4e68p670Z1eJvDlPmAcU/ y59Q== X-Gm-Message-State: AFqh2kpZlFjaOihkQO1KWHP07s06lds5DZ8gcGGFpCqvP76Y7+6SWo1Q gZCXPtV/XMmRKWHJ7P1043zg2rM8FlvtXEwLjKE= X-Google-Smtp-Source: AMrXdXuhMbeLfhMzO3dNO8FM0BS93W/XkG/FHlqBpBtG6GK7C62jMILFqgYHbTQjwIRvsrMCEslAihTwcRRHs+ouDnU= X-Received: by 2002:a81:5402:0:b0:3d8:8c0e:6d48 with SMTP id i2-20020a815402000000b003d88c0e6d48mr1018356ywb.462.1674156007567; Thu, 19 Jan 2023 11:20:07 -0800 (PST) MIME-Version: 1.0 References: <20230111161155.1349375-1-gary@garyguo.net> <20230112214059.o4vq474c47edjup6@ldmartin-desk2> <20230113181841.4d378a24.gary@garyguo.net> <20230117175144.GI16547@kitsune.suse.cz> <20230117192059.z5v5lfc2bzxk4ad2@ldmartin-desk2.lan> In-Reply-To: From: Miguel Ojeda Date: Thu, 19 Jan 2023 20:19:56 +0100 Message-ID: Subject: Re: [PATCH] modpost: support arbitrary symbol length in modversion To: Masahiro Yamada Content-Type: text/plain; charset="UTF-8" X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Gary Guo , Nicolas Schier , Guo Zhengkui , Wedson Almeida Filho , Joel Stanley , Alex Gaynor , Miguel Ojeda , =?UTF-8?Q?Michal_Such=C3=A1nek?= , Wedson Almeida Filho , Kees Cook , rust-for-linux@vger.kernel.org, linux-kbuild@vger.kernel.org, Boqun Feng , Lucas De Marchi , Nicholas Piggin , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= , Nathan Chancellor , Nick Desaulniers , linux-kernel@vger.kernel.org, Julia Lawall , Luis Chamberlain , linuxppc-dev@lists.ozlabs.org, linux-modules@vger.kernel.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Wed, Jan 18, 2023 at 8:02 AM Masahiro Yamada wrote: > > - *.mod.c is kept human readable. On the topic of `.mod.c` readability: for approaches that may be less readable, we could improve that by adding some extra comments or rearrange things in a different way (it is a generated file, after all!). For instance, for the original approach: https://godbolt.org/z/6oh45axnc Cheers, Miguel