From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35DDDC4741F for ; Sat, 7 Nov 2020 08:07:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D73E920704 for ; Sat, 7 Nov 2020 08:07:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="O38GIhXc" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727886AbgKGIHY (ORCPT ); Sat, 7 Nov 2020 03:07:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39204 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727738AbgKGIHY (ORCPT ); Sat, 7 Nov 2020 03:07:24 -0500 Received: from mail-yb1-xb41.google.com (mail-yb1-xb41.google.com [IPv6:2607:f8b0:4864:20::b41]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BCC08C0613CF; Sat, 7 Nov 2020 00:07:22 -0800 (PST) Received: by mail-yb1-xb41.google.com with SMTP id i193so3272603yba.1; Sat, 07 Nov 2020 00:07:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=DgNGf+RA9SoGZaRjp5OXgwLSyznHa2UUlzJCET6v8AA=; b=O38GIhXcBf2HdGLhRLjlOOTeLDBwg+CNm39JWvLHSGPFLxyfghKE3bg0RPnafdb1Yk yK29hX3r3ShGcp9zVJm8wlfBWf8FKIk3m1/l+RYdmayMQx9Jhqc+mhvEayZQaeLZMm/H +oo68Rll9siX1nNpZosY01GO4naZ7WM/jQkOoLXzHRV8iwPw+8VylmfY4p84NQSMRoJx tFNX9QoU0ImQnRGFM5149VMbmVD0c1d+lFaA7xO/bU4AdDjte8ZBJueIvx35zUSuOjqd 1WW98b+lVxS+OIlwuExZ4pqh+fh5/BQM1iSQwMnTHwI+48BYZfT/W6WIxgSTmaKHScmd Nrag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=DgNGf+RA9SoGZaRjp5OXgwLSyznHa2UUlzJCET6v8AA=; b=co38XmTf7OemvM2YdelU5avN/FbYxjZDkdwUFRNYXoH8/3j0A8FjaRVILxuQJ3cyL8 6Ij120Z1OelO7p/oPXUKwpT4Nsjb2HdKASpphqD+LDv8tPW+RGDBC1ycPPeBhHHSVFbL BQBT81TVVTQzx2n+N0mrDzX8Re89Wwcl7UFsV0i1NXbHOw7CquBlY1cXLxUva42X5Emx k8kDeTL1vG3knGvYbm3QymIaFFKt/ZUQ84Nfv69lwtMfX2q81JChJ/u2w4ja8Ubd7zIs qCDl1RssDNc10lV5At8vAx+DbhKCLJzI22DJAcAtsiYZ1WhT3MTz+O24flwpJXVYrCzd g++A== X-Gm-Message-State: AOAM530rcfhNcoFfDWj5Rsa7QeIVOq9uFmav8J5TuJyPk4qjpcoqfZ5Q BFzsluSL+GDMkzLK0L3ctmUinKT+lh/ui6U/JeA= X-Google-Smtp-Source: ABdhPJwAsD9KWEca2UFL/18r5E4q6yIHvHsu0rt6EpEN1hYYyqt5VRwKJqi4kSh/qVBMmst64BvDkhBxRY4MG/2dA/s= X-Received: by 2002:a25:61c5:: with SMTP id v188mr2074359ybb.422.1604736442019; Sat, 07 Nov 2020 00:07:22 -0800 (PST) MIME-Version: 1.0 References: <20201107070744.1133811-1-ndesaulniers@google.com> In-Reply-To: <20201107070744.1133811-1-ndesaulniers@google.com> From: Miguel Ojeda Date: Sat, 7 Nov 2020 09:07:11 +0100 Message-ID: Subject: Re: [PATCH] Kbuild: enable -Wfallthrough for clang To: Nick Desaulniers Cc: Masahiro Yamada , "Gustavo A . R . Silva" , Joe Perches , Michal Marek , Nathan Chancellor , Linux Kbuild mailing list , linux-kernel , clang-built-linux Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Nov 7, 2020 at 8:08 AM Nick Desaulniers wrote: > > Partial revert of commit e2079e93f562 ("kbuild: Do not enable > -Wimplicit-fallthrough for clang for now") > > This has been fixed up over time thanks to the addition of "fallthrough" > pseudo-keyword in > commit 294f69e662d1 ("compiler_attributes.h: Add 'fallthrough' pseudo > keyword for switch/case use") I think the title is missing the "implicit"? Acked-by: Miguel Ojeda Cheers, Miguel