From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55AAAC1B08C for ; Wed, 14 Jul 2021 20:31:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 41EFF610CB for ; Wed, 14 Jul 2021 20:31:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234160AbhGNUeG (ORCPT ); Wed, 14 Jul 2021 16:34:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32862 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232185AbhGNUeG (ORCPT ); Wed, 14 Jul 2021 16:34:06 -0400 Received: from mail-il1-x12a.google.com (mail-il1-x12a.google.com [IPv6:2607:f8b0:4864:20::12a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C33A4C06175F; Wed, 14 Jul 2021 13:31:13 -0700 (PDT) Received: by mail-il1-x12a.google.com with SMTP id o8so2886860ilf.4; Wed, 14 Jul 2021 13:31:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=TyOypBduh8zc4oZxw1Jw5CWPkP+HxfVRfcAuq+y3WDE=; b=NjmbscF6kBEfjMCLAWg3FCYvsVhOz3ydft84M9pkQa+4/61QXFa0dZsCmD/t2invcV nA8oTdYCEXtKnBqGc1wxQIYzg0Hd9IfrjR4DVkPKIe8dn21RL/H2GdsfoQqG9X2tpNM0 E+kQJ7lPYFI63nkGDUj1qkE+222CIr47m76IO4nNuVkIFSiCNm5gmS2Xao9tV1f+95I/ PWUKww46Xwygs/0sm2M21vz12wp4alF3ncG87lkxwzZbKJ9gV9PT7kswFUB3OgRyinEj uMbHIXYknS5MLCFr2RcOfjTAGubHPKSdFBtfDCKQreYagoBOG5/sC8JfL+aERwge2Rwm KZ+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=TyOypBduh8zc4oZxw1Jw5CWPkP+HxfVRfcAuq+y3WDE=; b=SHhW05PliNzJxp6/xWWloXzVytdTSgtCqYfXoG9mq6JNkt7UELdvamfbwFfvyWu5Th 3dxDD9ZlFm6D5r5vGeFh0U0E3LhgPfgvmQHpDS2hgSCbV/cPDSEkwUSEtDxS0laqSCbg irno04vW8/m9kBZU7Hfk99rwkAeiyHqoTLFcRMR7vGx0aLyyDMXsEZMpV5Xjac8WNwW/ ShM9LxWw0VDauHevwr6vbsYJeyZNS+kOzEyLarU8g4uaqP/qMHHYldV+fA3jzQTIEvyx VnyBMAA/+JTjNsZ4tJLYpLj2Ze3BU1/fAGtMIf6qrkpErHusILMwPBqLfhFKv9GRj76g nKLw== X-Gm-Message-State: AOAM532EOhGvN+RY7ZkCkrF9pxfWjiJhgBmfdeER3lnAvc7cQEPgmhaZ EisQOEn/3NesgZn5Fw148o67RtKXm3u80s0vzPU= X-Google-Smtp-Source: ABdhPJwAE54QtGjk6wjdMpERVvuoGiexA+ZndhhjqLbavlG69FKpSkNdz0lq9rT6inmUt/bcgrTgVXYMaogwEQSrnvU= X-Received: by 2002:a05:6e02:de6:: with SMTP id m6mr7931159ilj.203.1626294673267; Wed, 14 Jul 2021 13:31:13 -0700 (PDT) MIME-Version: 1.0 References: <20210704202756.29107-1-ojeda@kernel.org> <20210704202756.29107-4-ojeda@kernel.org> In-Reply-To: From: Miguel Ojeda Date: Wed, 14 Jul 2021 22:31:02 +0200 Message-ID: Subject: Re: [PATCH 03/17] Makefile: generate `CLANG_FLAGS` even in GCC builds To: Nick Desaulniers Cc: Miguel Ojeda , Linus Torvalds , Greg Kroah-Hartman , rust-for-linux , Linux Kbuild mailing list , Linux Doc Mailing List , linux-kernel , Alex Gaynor , Geoffrey Thomas , Finn Behrens , Adam Bratschi-Kaye , Wedson Almeida Filho , clang-built-linux , Nathan Chancellor Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: rust-for-linux@vger.kernel.org On Wed, Jul 14, 2021 at 8:14 PM Nick Desaulniers wrote: > > Patch LGTM; please keep an eye on the series: > https://lore.kernel.org/lkml/20210707224310.1403944-2-ndesaulniers@google.com/ > > If that lands in kbuild before this, this patch will need to be > rebased to avoid a conflict in linux-next. > > So (tentatively :-P): > Reviewed-by: Nick Desaulniers Thanks for the heads up! Given how fast `rustc_codegen_gcc` is progressing, we may need to prioritize getting https://github.com/rust-lang/rust-bindgen/issues/1949 fixed so that we can drop this hack altogether and go for proper, full GCC support. > If the patch needs to be rebased on the series linked above, please > drop my reviewed by tag and I will re-review. Perhaps putting me > explicitly on Cc: in the commit message will help notify me if there > are successive versions? Ack -- will do that. Cheers, Miguel