All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
To: Joe Perches <joe@perches.com>
Cc: Kees Cook <keescook@chromium.org>,
	Peter Zijlstra <peterz@infradead.org>,
	"H. Peter Anvin" <hpa@zytor.com>, Pavel Machek <pavel@ucw.cz>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Borislav Petkov <bp@alien8.de>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	"Gustavo A . R . Silva" <gustavo@embeddedor.com>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Kan Liang <kan.liang@linux.intel.com>,
	Namhyung Kim <namhyung@kernel.org>, Jiri Olsa <jolsa@redhat.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Shawn Landden <shawn@git.icu>,
	"maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)"
	<x86@kernel.org>, linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH] compiler_attributes.h: Add 'fallthrough' pseudo keyword for switch/case use
Date: Thu, 1 Aug 2019 02:00:41 +0200	[thread overview]
Message-ID: <CANiq72nhw5tmd7zCAyAA32ekW01GYPqcJbTMCVeUpaeb7dWTKA@mail.gmail.com> (raw)
In-Reply-To: <beb1762387a4132a2bb4c47397b737d77dd88742.camel@perches.com>

On Thu, Aug 1, 2019 at 12:07 AM Joe Perches <joe@perches.com> wrote:
>
> Note also that this doesn't actually _use_ fallthrough
> it just reserves it.

If we are reserving it, we should be giving a compile error instead. I
don't see how users will understand they shouldn't use it just yet (it
is the same as adding it, which actually looks more like
encouragement!).

Cheers,
Miguel

  reply	other threads:[~2019-08-01  0:00 UTC|newest]

Thread overview: 69+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-31  5:04 [PATCH] net: sctp: Rename fallthrough label to unhandled Joe Perches
2019-07-31  5:04 ` Joe Perches
2019-07-31  5:35 ` [RFC PATCH] compiler_attributes.h: Add 'fallthrough' pseudo keyword for switch/case use Joe Perches
2019-07-31  9:02   ` Peter Zijlstra
2019-07-31  9:34     ` Joe Perches
2019-07-31 17:14   ` Pavel Machek
2019-07-31 17:51     ` Joe Perches
2019-07-31 18:24       ` hpa
2019-07-31 18:48         ` Peter Zijlstra
2019-07-31 20:02           ` Kees Cook
2019-07-31 20:59             ` Miguel Ojeda
2019-07-31 22:07               ` Joe Perches
2019-08-01  0:00                 ` Miguel Ojeda [this message]
2019-08-01 12:25             ` Peter Zijlstra
2019-08-15 18:15             ` Kees Cook
2019-08-15 22:31               ` Kees Cook
2019-09-16 22:19               ` treewide replacement of fallthrough comments with "fallthrough" macro (was Re: [RFC PATCH] compiler_attributes.h: Add 'fallthrough' pseudo keyword for switch/case use) Kees Cook
2019-09-17 22:26                 ` Joe Perches
2019-09-17 23:38                   ` Kees Cook
2019-07-31 21:01           ` [RFC PATCH] compiler_attributes.h: Add 'fallthrough' pseudo keyword for switch/case use hpa
2019-07-31 23:55             ` Miguel Ojeda
2019-08-01  6:10               ` hpa
2019-08-01  7:52                 ` Joe Perches
2019-08-01 12:24                 ` Peter Zijlstra
2019-08-01 20:09                   ` hpa
2019-08-01 20:26                     ` Miguel Ojeda
2019-08-01 20:47                       ` Joe Perches
2019-08-02 11:00                       ` Neil Horman
2019-08-02 12:34                         ` Pavel Machek
2019-08-02 16:09                           ` Kees Cook
2019-08-02 16:16                             ` Joe Perches
2019-08-04 18:01   ` Joe Perches
2019-08-04 18:09     ` Linus Torvalds
2019-08-04 19:38       ` Miguel Ojeda
2019-08-05  0:39       ` Joe Perches
2019-08-05  1:18         ` Nathan Chancellor
2019-08-05  2:01           ` Joe Perches
2019-07-31 11:19 ` [PATCH] net: sctp: Rename fallthrough label to unhandled Neil Horman
2019-07-31 11:19   ` Neil Horman
2019-07-31 11:32   ` Joe Perches
2019-07-31 11:32     ` Joe Perches
2019-07-31 12:16     ` Neil Horman
2019-07-31 12:16       ` Neil Horman
2019-07-31 16:35       ` Joe Perches
2019-07-31 16:35         ` Joe Perches
2019-07-31 20:58         ` Neil Horman
2019-07-31 20:58           ` Neil Horman
2019-07-31 22:23           ` Joe Perches
2019-07-31 22:23             ` Joe Perches
2019-08-01 10:50             ` Neil Horman
2019-08-01 10:50               ` Neil Horman
2019-08-01 17:42               ` Joe Perches
2019-08-01 17:42                 ` Joe Perches
2019-08-01 20:48                 ` Neil Horman
2019-08-01 20:48                   ` Neil Horman
2019-08-05 11:49                 ` David Laight
2019-08-05 11:49                   ` David Laight
2019-08-02 17:47       ` Joe Perches
2019-08-02 17:47         ` Joe Perches
2019-08-02 23:19         ` David Miller
2019-08-02 23:19           ` David Miller
2019-08-02 23:26           ` Joe Perches
2019-08-02 23:26             ` Joe Perches
2019-08-03 18:01           ` Joe Perches
2019-08-03 18:01             ` Joe Perches
2019-08-04 19:26           ` Neil Horman
2019-08-04 19:26             ` Neil Horman
2019-08-02 17:50 ` Neil Horman
2019-08-02 17:50   ` Neil Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CANiq72nhw5tmd7zCAyAA32ekW01GYPqcJbTMCVeUpaeb7dWTKA@mail.gmail.com \
    --to=miguel.ojeda.sandonis@gmail.com \
    --cc=acme@kernel.org \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=bp@alien8.de \
    --cc=gustavo@embeddedor.com \
    --cc=hpa@zytor.com \
    --cc=joe@perches.com \
    --cc=jolsa@redhat.com \
    --cc=kan.liang@linux.intel.com \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=pavel@ucw.cz \
    --cc=peterz@infradead.org \
    --cc=shawn@git.icu \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.