From mboxrd@z Thu Jan 1 00:00:00 1970 From: Devesh Sharma Subject: Re: [PATCH 23/26] IB/ocrdma: Delete an unnecessary variable in ocrdma_dealloc_pd() Date: Wed, 8 Mar 2017 20:46:50 +0530 Message-ID: References: <0e667a69-3afa-6122-ed3b-d313bc5909ad@users.sourceforge.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <0e667a69-3afa-6122-ed3b-d313bc5909ad@users.sourceforge.net> Sender: linux-kernel-owner@vger.kernel.org To: SF Markus Elfring Cc: linux-rdma , Devesh Sharma , Doug Ledford , Hal Rosenstock , Sean Hefty , Selvin Xavier , LKML , kernel-janitors@vger.kernel.org List-Id: linux-rdma@vger.kernel.org Acked-By: Devesh Sharma On Wed, Mar 8, 2017 at 6:58 PM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Wed, 8 Mar 2017 10:58:34 +0100 > > 1. Return zero in one case directly. > > 2. Return the value from a call of the function "_ocrdma_dealloc_pd" > without using an extra assignment for the local variable. > > 3. Remove the variable "status" in this function then. > > Signed-off-by: Markus Elfring > --- > drivers/infiniband/hw/ocrdma/ocrdma_verbs.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c b/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c > index 1d25512416f5..ae0d343d1731 100644 > --- a/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c > +++ b/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c > @@ -755,7 +755,6 @@ int ocrdma_dealloc_pd(struct ib_pd *ibpd) > struct ocrdma_pd *pd = get_ocrdma_pd(ibpd); > struct ocrdma_dev *dev = get_ocrdma_dev(ibpd->device); > struct ocrdma_ucontext *uctx = NULL; > - int status = 0; > u64 usr_db; > > uctx = pd->uctx; > @@ -769,11 +768,10 @@ int ocrdma_dealloc_pd(struct ib_pd *ibpd) > > if (is_ucontext_pd(uctx, pd)) { > ocrdma_release_ucontext_pd(uctx); > - return status; > + return 0; > } > } > - status = _ocrdma_dealloc_pd(dev, pd); > - return status; > + return _ocrdma_dealloc_pd(dev, pd); > } > > static int ocrdma_alloc_lkey(struct ocrdma_dev *dev, struct ocrdma_mr *mr, > -- > 2.12.0 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: Devesh Sharma Date: Wed, 08 Mar 2017 15:28:50 +0000 Subject: Re: [PATCH 23/26] IB/ocrdma: Delete an unnecessary variable in ocrdma_dealloc_pd() Message-Id: List-Id: References: <0e667a69-3afa-6122-ed3b-d313bc5909ad@users.sourceforge.net> In-Reply-To: <0e667a69-3afa-6122-ed3b-d313bc5909ad@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: SF Markus Elfring Cc: linux-rdma , Devesh Sharma , Doug Ledford , Hal Rosenstock , Sean Hefty , Selvin Xavier , LKML , kernel-janitors@vger.kernel.org Acked-By: Devesh Sharma On Wed, Mar 8, 2017 at 6:58 PM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Wed, 8 Mar 2017 10:58:34 +0100 > > 1. Return zero in one case directly. > > 2. Return the value from a call of the function "_ocrdma_dealloc_pd" > without using an extra assignment for the local variable. > > 3. Remove the variable "status" in this function then. > > Signed-off-by: Markus Elfring > --- > drivers/infiniband/hw/ocrdma/ocrdma_verbs.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c b/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c > index 1d25512416f5..ae0d343d1731 100644 > --- a/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c > +++ b/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c > @@ -755,7 +755,6 @@ int ocrdma_dealloc_pd(struct ib_pd *ibpd) > struct ocrdma_pd *pd = get_ocrdma_pd(ibpd); > struct ocrdma_dev *dev = get_ocrdma_dev(ibpd->device); > struct ocrdma_ucontext *uctx = NULL; > - int status = 0; > u64 usr_db; > > uctx = pd->uctx; > @@ -769,11 +768,10 @@ int ocrdma_dealloc_pd(struct ib_pd *ibpd) > > if (is_ucontext_pd(uctx, pd)) { > ocrdma_release_ucontext_pd(uctx); > - return status; > + return 0; > } > } > - status = _ocrdma_dealloc_pd(dev, pd); > - return status; > + return _ocrdma_dealloc_pd(dev, pd); > } > > static int ocrdma_alloc_lkey(struct ocrdma_dev *dev, struct ocrdma_mr *mr, > -- > 2.12.0 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html