From: Devesh Sharma <devesh.sharma@broadcom.com>
To: Jason Gunthorpe <jgg@mellanox.com>
Cc: linux-rdma <linux-rdma@vger.kernel.org>,
Doug Ledford <dledford@redhat.com>,
Leon Romanovsky <leon@kernel.org>
Subject: Re: [PATCH for-next 0/2]: Broadcom's driver update
Date: Wed, 27 May 2020 11:06:11 +0530 [thread overview]
Message-ID: <CANjDDBh9o1VM9-4tS1tpXj23Euyhu-JWsB76p94q4aNs79R5uA@mail.gmail.com> (raw)
In-Reply-To: <20200526193141.GT24561@mellanox.com>
On Wed, May 27, 2020 at 1:01 AM Jason Gunthorpe <jgg@mellanox.com> wrote:
>
> On Tue, May 26, 2020 at 01:20:00AM -0400, Devesh Sharma wrote:
> > This series is mainly focused on adding driver fast path
> > changes to support variable sized wqe support. There are
> > two patches.
> >
> > The first patch is a big patch and contain core changes to
> > support the feature. Since the change is related to fast
> > path, the patch is not splitted into multiple patches.
> > We want to push all related changes in one go.
>
> That makes no sense, everyone else splits their patches.
I agree with both you and Leon about the size of the patch and there
is a guideline of sending smaller patches. I will have to see which
all parts I can split and re-send. I was not sure about the
functionality of the driver wrt each patch which comes out as a result
of split. These changes are quite closely woven. I will try though and
send a V2. Thanks
>
> > The second patch is relatively few lines and changes the
> > ABI.
> >
> > The corresponding library changes will follow short after
> > this patch series.
>
> You have to open a PR on rdma-core before any uapi changes should be
> merged.
Yeah sure, I will open that.
>
> Jason
prev parent reply other threads:[~2020-05-27 5:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-26 5:20 [PATCH for-next 0/2]: Broadcom's driver update Devesh Sharma
2020-05-26 5:20 ` [PATCH for-next 1/2] RDMA/bnxt_re: change sq and rq to be indexed with 16B stride Devesh Sharma
2020-05-26 5:20 ` [PATCH for-next 2/2] RDMA/bnxt_re: update ABI to pass wqe-mode to user space Devesh Sharma
2020-05-26 6:03 ` [PATCH for-next 0/2]: Broadcom's driver update Leon Romanovsky
2020-05-26 19:31 ` Jason Gunthorpe
2020-05-27 5:36 ` Devesh Sharma [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANjDDBh9o1VM9-4tS1tpXj23Euyhu-JWsB76p94q4aNs79R5uA@mail.gmail.com \
--to=devesh.sharma@broadcom.com \
--cc=dledford@redhat.com \
--cc=jgg@mellanox.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.