From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9765C33C9E for ; Mon, 3 Feb 2020 05:35:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C1B612080D for ; Mon, 3 Feb 2020 05:35:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="NYjKcGPJ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727210AbgBCFf3 (ORCPT ); Mon, 3 Feb 2020 00:35:29 -0500 Received: from mail-il1-f193.google.com ([209.85.166.193]:33483 "EHLO mail-il1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727368AbgBCFf2 (ORCPT ); Mon, 3 Feb 2020 00:35:28 -0500 Received: by mail-il1-f193.google.com with SMTP id s18so11561341iln.0 for ; Sun, 02 Feb 2020 21:35:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=0SHVnZMjrX3Jw9PKxItgQ/VRvGaJfmaxIMFbc3BTqm8=; b=NYjKcGPJ2fx7ndiVntNjBXOCtwLP9qH06gHtOGeTVJ46k6a5T1lWOFMkVKiMAuYIyZ xfQuibpcJkkEwwignFrWTdX6MhqgO8f5nw6Ef1+sC4RfTyZ98dwPBX1mtjAz9m/CF/ud lspgW6mSMFHWOov9/V75MyIrHAG/b87S1zV+c= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0SHVnZMjrX3Jw9PKxItgQ/VRvGaJfmaxIMFbc3BTqm8=; b=T27KKdwAuVz5VW+l4n5tC8nbAb9Yz8YN+1AqgylvquzJmvlN3QLcqfDLV01sPA3DoI 8gOLzz2jGz7uUyP5U0F/gwcraLv3oNEf2EaclcNuF+Bmilp9FoPG1nFJ7QWSKhrfmN0r bHRmIZl4sUKI+uU/1r28kZiYQgRtJiaecDISJL4aXxfrkLvNNG5T4vhskr5fCOWgf3Sk rXRI8Mlna3EC0bNqTpj4Frk2ypjU7bwG59/hsJdyalCxJ18tc2fJBT5/Pun1Tvn5Yo2m s8S3vwQg1LyZ8K/G0iIQIELQ/9gYTD7m4Wf3eC2ugX/xZo+Med+WNIztLHy8tIn0wkJH hRAw== X-Gm-Message-State: APjAAAWNwjIOqzuKwrxDxowVmPdQG5kEZZOwXcFXj7GjaMrvVYuKgmOA 9T0MGuHQlefRweAaw1Yl5+vd+NwJ+qtLuHZlHIAi7zcH X-Google-Smtp-Source: APXvYqzANtcXXoyCKSW85ErhMsmzCscxM8gckDsoVLJD0DWPjq5A4EzTaLO3Vcmgm34+YWuiNiqiFFtYv2QmPKlxVG8= X-Received: by 2002:a92:9ac5:: with SMTP id c66mr21560752ill.232.1580708127988; Sun, 02 Feb 2020 21:35:27 -0800 (PST) MIME-Version: 1.0 References: <1580493621-31006-1-git-send-email-devesh.sharma@broadcom.com> In-Reply-To: <1580493621-31006-1-git-send-email-devesh.sharma@broadcom.com> From: Devesh Sharma Date: Mon, 3 Feb 2020 11:04:51 +0530 Message-ID: Subject: Re: [PATCH v2] rdma-core/libibverbs: display gid type in ibv_devinfo To: linux-rdma Cc: Jason Gunthorpe , Leon Romanovsky Content-Type: text/plain; charset="UTF-8" Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Fri, Jan 31, 2020 at 11:30 PM Devesh Sharma wrote: > > It becomes difficult to make out from the output of ibv_devinfo > if a particular gid index is RoCE v2 or not. > > Adding a string to the output of ibv_devinfo -v to display the > gid type at the end of gid. > > Signed-off-by: Devesh Sharma > --- > libibverbs/examples/devinfo.c | 24 ++++++++++++++++++++++-- > 1 file changed, 22 insertions(+), 2 deletions(-) > > diff --git a/libibverbs/examples/devinfo.c b/libibverbs/examples/devinfo.c > index bf53eac..4094ea0 100644 > --- a/libibverbs/examples/devinfo.c > +++ b/libibverbs/examples/devinfo.c > @@ -162,8 +162,18 @@ static const char *vl_str(uint8_t vl_num) > } > } > > +static const char *gid_type_str(enum ibv_gid_type type) > +{ > + switch (type) { > + case 0: return "IB/RoCE v1"; > + case 1: return "RoCE v2"; > + default: return "invalid value"; > + } > +} > + > static int print_all_port_gids(struct ibv_context *ctx, uint8_t port_num, int tbl_len) > { > + enum ibv_gid_type type; > union ibv_gid gid; > int rc = 0; > int i; > @@ -175,8 +185,17 @@ static int print_all_port_gids(struct ibv_context *ctx, uint8_t port_num, int tb > port_num, i); > return rc; > } > + > + rc = ibv_query_gid_type(ctx, port_num, i, &type); > + if (rc) { > + rc = 0; > + type = 0x2; > + fprintf(stderr, "Failed to query gid type to port %d, index %d\n", > + port_num, i); > + } > + > if (!null_gid(&gid)) > - printf("\t\t\tGID[%3d]:\t\t%02x%02x:%02x%02x:%02x%02x:%02x%02x:%02x%02x:%02x%02x:%02x%02x:%02x%02x\n", > + printf("\t\t\tGID[%3d]:\t\t%02x%02x:%02x%02x:%02x%02x:%02x%02x:%02x%02x:%02x%02x:%02x%02x:%02x%02x, %s\n", > i, > gid.raw[ 0], gid.raw[ 1], > gid.raw[ 2], gid.raw[ 3], > @@ -185,7 +204,8 @@ static int print_all_port_gids(struct ibv_context *ctx, uint8_t port_num, int tb > gid.raw[ 8], gid.raw[ 9], > gid.raw[10], gid.raw[11], > gid.raw[12], gid.raw[13], > - gid.raw[14], gid.raw[15]); > + gid.raw[14], gid.raw[15], > + gid_type_str(type)); > } > return rc; > } > -- > 1.8.3.1 I will send out v3 as one more change is requested by Parav. >