From mboxrd@z Thu Jan 1 00:00:00 1970 From: Devesh Sharma Subject: Re: [PATCH 11/26] IB/ocrdma: Delete unnecessary braces Date: Wed, 8 Mar 2017 20:29:19 +0530 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: SF Markus Elfring Cc: linux-rdma , Devesh Sharma , Doug Ledford , Hal Rosenstock , Sean Hefty , Selvin Xavier , LKML , kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-rdma@vger.kernel.org On Wed, Mar 8, 2017 at 6:34 PM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Tue, 7 Mar 2017 21:12:56 +0100 > > Do not use curly brackets at some source code places > where a single statement should be sufficient. > > Signed-off-by: Markus Elfring > --- > drivers/infiniband/hw/ocrdma/ocrdma_hw.c | 17 ++++++++--------- > 1 file changed, 8 insertions(+), 9 deletions(-) > > diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_hw.c b/drivers/infiniband/hw/ocrdma/ocrdma_hw.c > index aa32bc9f323d..d5b988b011d1 100644 > --- a/drivers/infiniband/hw/ocrdma/ocrdma_hw.c > +++ b/drivers/infiniband/hw/ocrdma/ocrdma_hw.c > @@ -1092,14 +1092,14 @@ static int ocrdma_mbx_cmd(struct ocrdma_dev *dev, struct ocrdma_mqe *mqe) > if (cqe_status || ext_status) { > pr_err("%s() cqe_status=0x%x, ext_status=0x%x,", > __func__, cqe_status, ext_status); > - if (rsp) { > + if (rsp) > /* This is for embedded cmds. */ > pr_err("opcode=0x%x, subsystem=0x%x\n", > (rsp->subsys_op & OCRDMA_MBX_RSP_OPCODE_MASK) >> > OCRDMA_MBX_RSP_OPCODE_SHIFT, > (rsp->subsys_op & OCRDMA_MBX_RSP_SUBSYS_MASK) >> > OCRDMA_MBX_RSP_SUBSYS_SHIFT); > - } > + > status = ocrdma_get_mbx_cqe_errno(cqe_status); > goto mbx_err; > } > @@ -1600,10 +1600,9 @@ void ocrdma_alloc_pd_pool(struct ocrdma_dev *dev) > return; > > status = ocrdma_mbx_alloc_pd_range(dev); > - if (status) { > + if (status) > pr_err("%s(%d) Unable to initialize PD pool, using default.\n", > __func__, dev->id); > - } > } > > static void ocrdma_free_pd_pool(struct ocrdma_dev *dev) > @@ -2997,11 +2996,10 @@ static int ocrdma_parse_dcbxcfg_rsp(struct ocrdma_dev *dev, int ptype, > goto out; > } > } > - if (slindx == OCRDMA_MAX_SERVICE_LEVEL_INDEX) { > + if (slindx == OCRDMA_MAX_SERVICE_LEVEL_INDEX) > pr_info("%s ocrdma%d application priority not set for 0x%x protocol\n", > dev_name(&dev->nic_info.pdev->dev), > dev->id, proto); > - } > } > } > > @@ -3158,16 +3156,17 @@ static int ocrdma_modify_eqd(struct ocrdma_dev *dev, struct ocrdma_eq *eq, > int num) > { > int num_eqs, i = 0; > - if (num > 8) { > + > + if (num > 8) > while (num) { > num_eqs = min(num, 8); > ocrdma_mbx_modify_eqd(dev, &eq[i], num_eqs); > i += num_eqs; > num -= num_eqs; > } May be compiler would give you a warning here, could you check once? > - } else { > + else > ocrdma_mbx_modify_eqd(dev, eq, num); > - } > + > return 0; > } > > -- > 2.12.0 > -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752000AbdCHPHs (ORCPT ); Wed, 8 Mar 2017 10:07:48 -0500 Received: from mail-wr0-f180.google.com ([209.85.128.180]:36313 "EHLO mail-wr0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751657AbdCHPH2 (ORCPT ); Wed, 8 Mar 2017 10:07:28 -0500 MIME-Version: 1.0 In-Reply-To: References: From: Devesh Sharma Date: Wed, 8 Mar 2017 20:29:19 +0530 Message-ID: Subject: Re: [PATCH 11/26] IB/ocrdma: Delete unnecessary braces To: SF Markus Elfring Cc: linux-rdma , Devesh Sharma , Doug Ledford , Hal Rosenstock , Sean Hefty , Selvin Xavier , LKML , kernel-janitors@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 8, 2017 at 6:34 PM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Tue, 7 Mar 2017 21:12:56 +0100 > > Do not use curly brackets at some source code places > where a single statement should be sufficient. > > Signed-off-by: Markus Elfring > --- > drivers/infiniband/hw/ocrdma/ocrdma_hw.c | 17 ++++++++--------- > 1 file changed, 8 insertions(+), 9 deletions(-) > > diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_hw.c b/drivers/infiniband/hw/ocrdma/ocrdma_hw.c > index aa32bc9f323d..d5b988b011d1 100644 > --- a/drivers/infiniband/hw/ocrdma/ocrdma_hw.c > +++ b/drivers/infiniband/hw/ocrdma/ocrdma_hw.c > @@ -1092,14 +1092,14 @@ static int ocrdma_mbx_cmd(struct ocrdma_dev *dev, struct ocrdma_mqe *mqe) > if (cqe_status || ext_status) { > pr_err("%s() cqe_status=0x%x, ext_status=0x%x,", > __func__, cqe_status, ext_status); > - if (rsp) { > + if (rsp) > /* This is for embedded cmds. */ > pr_err("opcode=0x%x, subsystem=0x%x\n", > (rsp->subsys_op & OCRDMA_MBX_RSP_OPCODE_MASK) >> > OCRDMA_MBX_RSP_OPCODE_SHIFT, > (rsp->subsys_op & OCRDMA_MBX_RSP_SUBSYS_MASK) >> > OCRDMA_MBX_RSP_SUBSYS_SHIFT); > - } > + > status = ocrdma_get_mbx_cqe_errno(cqe_status); > goto mbx_err; > } > @@ -1600,10 +1600,9 @@ void ocrdma_alloc_pd_pool(struct ocrdma_dev *dev) > return; > > status = ocrdma_mbx_alloc_pd_range(dev); > - if (status) { > + if (status) > pr_err("%s(%d) Unable to initialize PD pool, using default.\n", > __func__, dev->id); > - } > } > > static void ocrdma_free_pd_pool(struct ocrdma_dev *dev) > @@ -2997,11 +2996,10 @@ static int ocrdma_parse_dcbxcfg_rsp(struct ocrdma_dev *dev, int ptype, > goto out; > } > } > - if (slindx == OCRDMA_MAX_SERVICE_LEVEL_INDEX) { > + if (slindx == OCRDMA_MAX_SERVICE_LEVEL_INDEX) > pr_info("%s ocrdma%d application priority not set for 0x%x protocol\n", > dev_name(&dev->nic_info.pdev->dev), > dev->id, proto); > - } > } > } > > @@ -3158,16 +3156,17 @@ static int ocrdma_modify_eqd(struct ocrdma_dev *dev, struct ocrdma_eq *eq, > int num) > { > int num_eqs, i = 0; > - if (num > 8) { > + > + if (num > 8) > while (num) { > num_eqs = min(num, 8); > ocrdma_mbx_modify_eqd(dev, &eq[i], num_eqs); > i += num_eqs; > num -= num_eqs; > } May be compiler would give you a warning here, could you check once? > - } else { > + else > ocrdma_mbx_modify_eqd(dev, eq, num); > - } > + > return 0; > } > > -- > 2.12.0 > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Devesh Sharma Date: Wed, 08 Mar 2017 15:11:19 +0000 Subject: Re: [PATCH 11/26] IB/ocrdma: Delete unnecessary braces Message-Id: List-Id: References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: SF Markus Elfring Cc: linux-rdma , Devesh Sharma , Doug Ledford , Hal Rosenstock , Sean Hefty , Selvin Xavier , LKML , kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org On Wed, Mar 8, 2017 at 6:34 PM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Tue, 7 Mar 2017 21:12:56 +0100 > > Do not use curly brackets at some source code places > where a single statement should be sufficient. > > Signed-off-by: Markus Elfring > --- > drivers/infiniband/hw/ocrdma/ocrdma_hw.c | 17 ++++++++--------- > 1 file changed, 8 insertions(+), 9 deletions(-) > > diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_hw.c b/drivers/infiniband/hw/ocrdma/ocrdma_hw.c > index aa32bc9f323d..d5b988b011d1 100644 > --- a/drivers/infiniband/hw/ocrdma/ocrdma_hw.c > +++ b/drivers/infiniband/hw/ocrdma/ocrdma_hw.c > @@ -1092,14 +1092,14 @@ static int ocrdma_mbx_cmd(struct ocrdma_dev *dev, struct ocrdma_mqe *mqe) > if (cqe_status || ext_status) { > pr_err("%s() cqe_status=0x%x, ext_status=0x%x,", > __func__, cqe_status, ext_status); > - if (rsp) { > + if (rsp) > /* This is for embedded cmds. */ > pr_err("opcode=0x%x, subsystem=0x%x\n", > (rsp->subsys_op & OCRDMA_MBX_RSP_OPCODE_MASK) >> > OCRDMA_MBX_RSP_OPCODE_SHIFT, > (rsp->subsys_op & OCRDMA_MBX_RSP_SUBSYS_MASK) >> > OCRDMA_MBX_RSP_SUBSYS_SHIFT); > - } > + > status = ocrdma_get_mbx_cqe_errno(cqe_status); > goto mbx_err; > } > @@ -1600,10 +1600,9 @@ void ocrdma_alloc_pd_pool(struct ocrdma_dev *dev) > return; > > status = ocrdma_mbx_alloc_pd_range(dev); > - if (status) { > + if (status) > pr_err("%s(%d) Unable to initialize PD pool, using default.\n", > __func__, dev->id); > - } > } > > static void ocrdma_free_pd_pool(struct ocrdma_dev *dev) > @@ -2997,11 +2996,10 @@ static int ocrdma_parse_dcbxcfg_rsp(struct ocrdma_dev *dev, int ptype, > goto out; > } > } > - if (slindx = OCRDMA_MAX_SERVICE_LEVEL_INDEX) { > + if (slindx = OCRDMA_MAX_SERVICE_LEVEL_INDEX) > pr_info("%s ocrdma%d application priority not set for 0x%x protocol\n", > dev_name(&dev->nic_info.pdev->dev), > dev->id, proto); > - } > } > } > > @@ -3158,16 +3156,17 @@ static int ocrdma_modify_eqd(struct ocrdma_dev *dev, struct ocrdma_eq *eq, > int num) > { > int num_eqs, i = 0; > - if (num > 8) { > + > + if (num > 8) > while (num) { > num_eqs = min(num, 8); > ocrdma_mbx_modify_eqd(dev, &eq[i], num_eqs); > i += num_eqs; > num -= num_eqs; > } May be compiler would give you a warning here, could you check once? > - } else { > + else > ocrdma_mbx_modify_eqd(dev, eq, num); > - } > + > return 0; > } > > -- > 2.12.0 >