From mboxrd@z Thu Jan 1 00:00:00 1970 From: Devesh Sharma Subject: Re: [PATCH v8 00/23] IB/Verbs: IB Management Helpers Date: Fri, 8 May 2015 21:58:47 +0530 Message-ID: References: <1430830240-32389-1-git-send-email-yun.wang@profitbricks.com> <5548D0CD.3080400@mellanox.com> <5548D645.5070707@profitbricks.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Return-path: In-Reply-To: <5548D645.5070707@profitbricks.com> Sender: linux-kernel-owner@vger.kernel.org To: Michael Wang Cc: Or Gerlitz , Sean Hefty , Hal Rosenstock , Doug Ledford , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, Tom Tucker , Steve Wise , Hoang-Nam Nguyen , Christoph Raisch , Mike Marciniszyn , Eli Cohen , Faisal Latif , Jack Morgenstein , Haggai Eran , Ira Weiny , Tom Talpey , Jason Gunthorpe , Devesh Sharma , Liran Liss , Dave Goodell List-Id: linux-rdma@vger.kernel.org Reviewed-by: Devesh Sharma On Tue, May 5, 2015 at 8:10 PM, Michael Wang wrote: > > > On 05/05/2015 04:16 PM, Or Gerlitz wrote: >> On 5/5/2015 3:50 PM, Michael Wang wrote: >>> Since v7: >>> * Thanks to Doug, Ira, Devesh for the testing:-) >>> * Thanks for the comments from or, Doug, Ira, Jason:-) >>> Please remind me if anything missed:-P >>> * Use rdma_cap_XX() instead of cap_XX() for readability >>> * Remove CC list in git log for maintainability >>> * Use bool as return value >>> * Updated github repository to v8 >> >> Didn't you see that patches 15~23 will be squashed into one? > > I missed the conversation on that, you mentioned to remove the > CC list but don't want to merge the patches, correct? > >> >> >> Also, when you post version N you need not only to list the changes since version N-1 but rather also to keep the full changes since Vx for x=1...N-2, reviewers needs not chase your previous cover letters and see if/whatwent wrong, specifically with a sensitive series like this one. > > That maybe too long and with some outdated info, I can reserve > the log since this version if it was preferred by folks. > >> >> So if/when there's V9, use that practice, and for the time being, reply on the V8 cover letter with the full listing of changes > > I'm using git send-mail which reply on the cover of each version, > not sure how to reply on a prev cover? and that won't start a new > thread for the new version, isn't it? > > Regards, > Michael Wang > >> >> Or. >> >> > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- -Regards Devesh