From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06546C11F64 for ; Mon, 28 Jun 2021 22:40:10 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7F54561CF8 for ; Mon, 28 Jun 2021 22:40:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7F54561CF8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:46174 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lxzvE-0000Dt-CY for qemu-devel@archiver.kernel.org; Mon, 28 Jun 2021 18:40:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55266) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lxzuW-00080r-Iq for qemu-devel@nongnu.org; Mon, 28 Jun 2021 18:39:24 -0400 Received: from mail-wm1-x330.google.com ([2a00:1450:4864:20::330]:50801) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lxzuT-0000S4-Gp for qemu-devel@nongnu.org; Mon, 28 Jun 2021 18:39:24 -0400 Received: by mail-wm1-x330.google.com with SMTP id o22so11562533wms.0 for ; Mon, 28 Jun 2021 15:39:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=cIO3ojpdUKG/KYeTQaaHtNzqKrPmFXvl8dIlZ5z69+A=; b=M2YQs3BStCpWiFasKTcLGNBjcYzREQQdcrc7kphucp9hQIJmdfYpUwxA1MI7Ra7l08 bXdGuINCmpb8z9lMtvFo6NQOxoQGukoEj3m2l6eHSckZpfx0JaK0V+SG2B4/pp1WKP6G e379jeDgkJtJXxOP1wAj+C3uzsUKHrFJvZW50pAyyXgL2PjHU/amuKk0foYPXYch8iXD IhfUsJ6y6opDWfl+51XI2uHyRcZhAN6/SSMGp8cx2GxLlJJmeTvlH+qnKzueeVui9s9Z gZdw3Sx0MS8haY8rUmzCbyRJPOwTPld6RlVJ1/e/Emtan5N5zSloHRSe2U6z/C7Uwu+v 7Rjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=cIO3ojpdUKG/KYeTQaaHtNzqKrPmFXvl8dIlZ5z69+A=; b=G68m0nCkj6QmkcsPuCCD2xrJBqM4ErLG2mMcB+2QiO+J79ehs4dd+Ez2CSvZjjY4IB XuWBgANzHYUKyvXe22LSzCwKx6c8cXtXamwQG2vLWuaB/0aSeKz04GAZTdApvbNu4I6p 7kxiFDsNa6IOMiPcTuiMltwuqQxu0Z5g1bxgdHq8ad5cHo4YHGyQDYUsoc72ZGGOoN5B RfLv8Z2tcrlk/hyIpB9HGCqu08guPAUh0tN0NB+Op09uN9uJ9AURXpMOG+xnESihAowz Y+pZjNaITDuzii94CDALWPSSEPYY9+J2XNtPI5f6l8jh5SBi6+tQEbsx473R8bDepQzW FfVQ== X-Gm-Message-State: AOAM533etI6tSaWNDIo17SM/dDjoF1V8oseBfGQDhLqxegZBBya+0wcy jxNQQvoOUiAuAhPgrN3BiOPOGfBxsEVVJCeGc3A= X-Google-Smtp-Source: ABdhPJxFBpXmZG/iJNoH+ILLufGQuQPWnXJZJxbR4Lo16iITZqdHo89CQSor56adJRbdn+MGY4c1mOHO3gqq2zNmuJA= X-Received: by 2002:a05:600c:1d23:: with SMTP id l35mr27534869wms.134.1624919959080; Mon, 28 Jun 2021 15:39:19 -0700 (PDT) MIME-Version: 1.0 References: <20210619093713.1845446-1-ale.qemu@rev.ng> <20210619093713.1845446-14-ale.qemu@rev.ng> In-Reply-To: From: Taylor Simpson Date: Mon, 28 Jun 2021 17:39:08 -0500 Message-ID: Subject: Re: [PATCH v5 13/14] target/hexagon: import additional tests To: Alessandro Di Federico Content-Type: multipart/alternative; boundary="000000000000f310ea05c5db28d4" Received-SPF: pass client-ip=2a00:1450:4864:20::330; envelope-from=taylor.qemu@gmail.com; helo=mail-wm1-x330.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alessandro Di Federico , bcain@quicinc.com, richard.henderson@linaro.org, qemu-devel@nongnu.org, babush@rev.ng, tsimpson@quicinc.com, nizzo@rev.ng, philmd@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --000000000000f310ea05c5db28d4 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Jun 25, 2021 at 6:56 PM Taylor Simpson wrote: > > > On Sat, Jun 19, 2021 at 4:49 AM Alessandro Di Federico via < > qemu-devel@nongnu.org> wrote: > >> From: Niccol=C3=B2 Izzo >> >> Signed-off-by: Alessandro Di Federico >> Signed-off-by: Niccol=C3=B2 Izzo >> --- >> > > > > + .text >> + .globl _start >> + >> +_start: >> + { >> + call init >> + } >> + { >> + r0=3D#1 >> + memw(sp+#0)=3Dr0.new >> + } >> > > You haven't set up the stack, so you shouldn't use sp. Even if the stack > were set up, you should allocframe first. > > My apologies - the stack *is* set up in linux-user mode. So, it is OK to reference sp after you do an allocframe. You can disregard the other comments in the review about setting up the stack. Thanks, Taylor --000000000000f310ea05c5db28d4 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable



On Fri, Jun 25, 2021 at 6:56 PM Taylor Simpson <taylor.qemu@gmail.com> wro= te:


On Sat, Jun 19, 2021 at 4:49 AM Alessandro Di Fed= erico via <qe= mu-devel@nongnu.org> wrote:
From: Niccol=C3=B2 Izzo <nizzo@rev.ng>

Signed-off-by: Alessandro Di Federico <ale@rev.ng>
Signed-off-by: Niccol=C3=B2 Izzo <nizzo@rev.ng>
---
=C2=A0


+=C2=A0 =C2=A0 .text
+=C2=A0 =C2=A0 .globl _start
+
+_start:
+=C2=A0 =C2=A0 {
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 call init
+=C2=A0 =C2=A0 }
+=C2=A0 =C2=A0 {
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 r0=3D#1
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 memw(sp+#0)=3Dr0.new
+=C2=A0 =C2=A0 }

You haven't set up= the stack, so you shouldn't use sp.=C2=A0 Even if the stack were set u= p, you should allocframe first.

=
My apologies - the stack *is* set up in linux-user mode.=C2= =A0 So, it is OK to reference sp after you do an allocframe.

=
You can disregard the other comments in the review about setting= up the stack.


Thanks,
Ta= ylor

--000000000000f310ea05c5db28d4--