All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alan Tull <delicious.quinoa@gmail.com>
To: Moritz Fischer <moritz.fischer@ettus.com>
Cc: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
	matthew.gerlach@linux.intel.com,
	linux-kernel <linux-kernel@vger.kernel.org>,
	linux-fpga@vger.kernel.org
Subject: Re: [RFC 7/8] fpga-region: add sysfs interface
Date: Thu, 16 Feb 2017 11:47:08 -0600	[thread overview]
Message-ID: <CANk1AXQmcUO4YpWq9qVg6_MQdpWWQ+94NM0Y0pcd__ZwfV91OQ@mail.gmail.com> (raw)
In-Reply-To: <CAAtXAHdG9GP_0LffHMyJ9T=cVuZMJrR8JNTwXXVuYQGj1y=3KQ@mail.gmail.com>

On Wed, Feb 15, 2017 at 6:16 PM, Moritz Fischer
<moritz.fischer@ettus.com> wrote:
> On Wed, Feb 15, 2017 at 2:42 PM, Alan Tull <delicious.quinoa@gmail.com> wrote:
>> On Wed, Feb 15, 2017 at 3:36 PM, Moritz Fischer
>> <moritz.fischer@ettus.com> wrote:
>>> Jason,
>>>
>>> On Wed, Feb 15, 2017 at 1:15 PM, Jason Gunthorpe
>>> <jgunthorpe@obsidianresearch.com> wrote:
>>>> On Wed, Feb 15, 2017 at 12:54:27PM -0800, Moritz Fischer wrote:
>>>>
>>>>> Well I don't know ;-) With something fdt based we already have
>>>>> parsers there,
>>>>
>>>> Not sure.. How does incbin work in DTB?
>>>>
>>>> We have the FPGA in a s/g list so we cannot pass the entire file to
>>>> libfdt - is that consistent with incbin?
>>>
>>> Well you could attach the (for lack of better word) blob to the beginning,
>>> instead of doing incbin
>>>
>>>> Can we force a specific alignment for the included data?
>>>
>>> I'd say probably, but haven't checked.
>>>
>>>> How complex will the userspace tool be to make the image?
>>>
>>> Userspace can be as complex as it needs to be, imho, if it makes
>>> kernel space easier & safer.
>>>
>>> I'll need to do some more reading over the weekend before I can make
>>> more sensible comments :)
>>>
>>> Thanks,
>>>
>>> Moritz
>>
>> Another thought I have about this is that adding the header to
>> bitstreams can be a piece of independence from DT for systems that
>> aren't already using DT.  This includes x86 in Linux.  It also
>> includes other OS's that aren't using DT, they can reuse the same
>> image files without having to add dtc.  As much as I like DT, it is
>> something I'm having to think about.
>
> Just to clarify:
> I was proposing using the binary format of dts, not actually requiring
> devicetree
> for it to work. There's plenty of people running u-boot on x86 using FIT images
> to boot.

The FPGA images should not be required to have OS specific parts.
Some ahem non-Linux OS's that use FPGAs don't use device tree, so that
adds an extra complication for them unnecessarily.

>
> W.r.t to Jason's script, it's there. Almost any company dealing with
> Xilinx FPGAs
> will have one of those. We have one, too. I recall having seen another one made
> and shared by Mike @ topic.
>
> While it's a good starting point ,I *really* don't like the idea
> parsing user-land
> provided strings in kernel space in a parser that we open-code.

Why do you not like about it?  Jason posted some very clear practices
on how to do that properly and safely.

>
> Good discussion ;-)

Yes, I like it. :)

Alan

>
> Cheers,
> Moritz

  reply	other threads:[~2017-02-16 17:47 UTC|newest]

Thread overview: 63+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-15 16:14 FPGA Region enhancements and fixes Alan Tull
2017-02-15 16:14 ` [RFC 1/8] fpga-mgr: add a single function for fpga loading methods Alan Tull
2017-02-16  0:36   ` matthew.gerlach
2017-02-15 16:14 ` [RFC 2/8] fpga-region: support more than one overlay per FPGA region Alan Tull
2017-02-16 16:50   ` matthew.gerlach
2017-02-16 17:35     ` Alan Tull
2017-02-15 16:14 ` [RFC 3/8] fpga-bridge: add non-dt support Alan Tull
2017-02-15 16:14 ` [RFC 4/8] doc: fpga-mgr: separate getting/locking FPGA manager Alan Tull
2017-02-17 17:14   ` Li, Yi
2017-02-17 21:55     ` Alan Tull
2017-02-17 17:52   ` Moritz Fischer
2017-02-17 22:02     ` Alan Tull
2017-02-15 16:14 ` [RFC 5/8] " Alan Tull
2017-02-15 16:14 ` [RFC 6/8] fpga-region: separate out common code to allow non-dt support Alan Tull
2017-02-15 16:14 ` [RFC 7/8] fpga-region: add sysfs interface Alan Tull
2017-02-15 17:21   ` Jason Gunthorpe
2017-02-15 17:46     ` Alan Tull
2017-02-15 17:55       ` Moritz Fischer
2017-02-15 18:06       ` Jason Gunthorpe
2017-02-15 18:23         ` Alan Tull
2017-02-15 18:31           ` Moritz Fischer
2017-02-15 19:49           ` Jason Gunthorpe
2017-02-15 22:49             ` Alan Tull
2017-02-15 23:07               ` Jason Gunthorpe
2017-02-15 20:07           ` matthew.gerlach
2017-02-15 20:37             ` Jason Gunthorpe
2017-02-15 20:54               ` Moritz Fischer
2017-02-15 21:15                 ` Jason Gunthorpe
2017-02-15 21:36                   ` Moritz Fischer
2017-02-15 22:42                     ` Alan Tull
2017-02-16  0:16                       ` Moritz Fischer
2017-02-16 17:47                         ` Alan Tull [this message]
2017-02-16 17:56                           ` Jason Gunthorpe
2017-02-16 18:11                             ` Moritz Fischer
2017-02-17 22:28                 ` Yves Vandervennet
2017-02-18  2:30                   ` Moritz Fischer
2017-02-18 12:45                     ` Nadathur, Sundar
2017-02-18 20:10                       ` Alan Tull
2017-02-18 20:45                         ` Moritz Fischer
2017-02-19 15:00                           ` Alan Tull
2017-02-19 23:16                             ` Alan Tull
2017-02-20 23:49                               ` Moritz Fischer
2017-02-21 18:33                                 ` Alan Tull
2017-02-22  3:13                                   ` Nadathur, Sundar
2017-02-22  3:49                                     ` Moritz Fischer
2017-02-22  5:12                                       ` Jason Gunthorpe
2017-02-22  5:38                                         ` Moritz Fischer
2017-02-22  5:46                                           ` Nadathur, Sundar
2017-02-22  6:05                                             ` Moritz Fischer
2017-02-22 16:44                                               ` Jason Gunthorpe
2017-02-22 17:50                                                 ` Moritz Fischer
2017-02-22 17:54                                                   ` Jason Gunthorpe
2017-02-22 17:57                                                     ` Moritz Fischer
2017-02-22 16:33                                           ` Alan Tull
2017-02-22 16:44                                             ` Moritz Fischer
2017-02-22 16:52                                               ` Alan Tull
2017-02-27 20:09                                   ` Alan Tull
2017-02-27 22:49                                     ` Moritz Fischer
2017-02-28  0:04                                       ` matthew.gerlach
2017-02-15 21:20         ` Anatolij Gustschin
2017-02-15 16:14 ` [RFC 8/8] doc: fpga: add sysfs document for fpga region Alan Tull
2017-02-28 17:35 ` FPGA Region enhancements and fixes Alan Tull
2017-02-28 22:03   ` Alan Tull

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CANk1AXQmcUO4YpWq9qVg6_MQdpWWQ+94NM0Y0pcd__ZwfV91OQ@mail.gmail.com \
    --to=delicious.quinoa@gmail.com \
    --cc=jgunthorpe@obsidianresearch.com \
    --cc=linux-fpga@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matthew.gerlach@linux.intel.com \
    --cc=moritz.fischer@ettus.com \
    --subject='Re: [RFC 7/8] fpga-region: add sysfs interface' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.