From: Alan Tull <atull@kernel.org>
To: Anatolij Gustschin <agust@denx.de>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>,
linux-fpga@vger.kernel.org,
Alan Tull <atull@opensource.altera.com>,
Moritz Fischer <moritz.fischer@ettus.com>,
matthew.gerlach@linux.intel.com, "Li,
Yi" <yi1.li@linux.intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4] fpga manager: Add Altera CvP driver
Date: Wed, 3 May 2017 09:19:40 -0500 [thread overview]
Message-ID: <CANk1AXRW2GUd+BbM6mSZwXtf9fNPus81QbV0YZWPtjpCGwtXyw@mail.gmail.com> (raw)
In-Reply-To: <20170503021439.6d812223@crub>
On Tue, May 2, 2017 at 7:14 PM, Anatolij Gustschin <agust@denx.de> wrote:
> On Wed, 3 May 2017 00:28:17 +0300
> Andy Shevchenko andy.shevchenko@gmail.com wrote:
> ...
>>>>Is 0xff a mask here? (Btw, you missed spaces around <<)
>>>
>>> yes, it is. Will add spaces (checkpatch didn't warn here).
>>
>>Then it makes sense to add _MASK and use GENMASK() instead of direct value.
>
> ok, will do.
>
>>>>Why do we need that?!
>>>>In new drivers we try to avoid new module parameters. We have enough
>>>>interfaces nowadays to let driver know some details (quirks).
>>>
>>> Which interface is preffered here? Do you suggest sysfs? Won't be able
>>> to pass the parameter on kernel command line, then.
>>
>>Yes, my question here is to understand what so important that driver
>>needs module parameter.
>>Can you elaborate?
>
> the driver doesn't need this parameter, but it could help testing
> the loading of compressed or encrypted images.
Loading encrypted or compressed images can be keyed off of flags in
fpga_image_info. Currently we have FPGA_MGR_ENCRYPTED_BITSTREAM Will
need to add one for compressed such as FPGA_MGR_COMPRESSED_BITSTREAM
Alan
next prev parent reply other threads:[~2017-05-03 14:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-30 19:08 [PATCH v4] fpga manager: Add Altera CvP driver Anatolij Gustschin
2017-05-01 14:58 ` Alan Tull
2017-05-01 20:06 ` Andy Shevchenko
2017-05-02 9:53 ` Anatolij Gustschin
2017-05-02 21:28 ` Andy Shevchenko
2017-05-03 0:14 ` Anatolij Gustschin
2017-05-03 14:19 ` Alan Tull [this message]
2017-05-03 15:01 ` Andy Shevchenko
2017-05-14 8:38 ` Anatolij Gustschin
2017-05-02 23:36 ` Joe Perches
2017-05-03 0:22 ` Anatolij Gustschin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANk1AXRW2GUd+BbM6mSZwXtf9fNPus81QbV0YZWPtjpCGwtXyw@mail.gmail.com \
--to=atull@kernel.org \
--cc=agust@denx.de \
--cc=andy.shevchenko@gmail.com \
--cc=atull@opensource.altera.com \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.gerlach@linux.intel.com \
--cc=moritz.fischer@ettus.com \
--cc=yi1.li@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.