From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751864AbdIUOn3 (ORCPT ); Thu, 21 Sep 2017 10:43:29 -0400 Received: from mail.kernel.org ([198.145.29.99]:54910 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751387AbdIUOn2 (ORCPT ); Thu, 21 Sep 2017 10:43:28 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8296022A9A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=atull@kernel.org X-Google-Smtp-Source: AOwi7QDQh2tAv75rz6mESR9vML3RiDJKdW15jpiSk6g33/3BrAazCseqrnPK9uZ6UzPFUb2wu2xboNGIhFPl0VlGcdY= MIME-Version: 1.0 In-Reply-To: References: <1503941531-17977-1-git-send-email-bhumirks@gmail.com> <78e2ed1d-ea20-eb68-b6b4-d993a98984a6@xilinx.com> From: Alan Tull Date: Thu, 21 Sep 2017 09:42:46 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] fpga: make xlnx_pr_decoupler_br_ops const To: Moritz Fischer Cc: Michal Simek , Bhumika Goyal , julia.lawall@lip6.fr, =?UTF-8?Q?S=C3=B6ren_Brinkmann?= , linux-fpga@vger.kernel.org, linux-arm-kernel , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 29, 2017 at 11:09 AM, Moritz Fischer wrote: > On Tue, Aug 29, 2017 at 12:00 AM, Michal Simek wrote: >> On 28.8.2017 19:32, Bhumika Goyal wrote: >>> Make this const as it is only passed to a const argument of the function >>> fpga_bridge_register. >>> >>> Signed-off-by: Bhumika Goyal > > Acked-by: Moritz Fischer >>> --- >>> drivers/fpga/xilinx-pr-decoupler.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/fpga/xilinx-pr-decoupler.c b/drivers/fpga/xilinx-pr-decoupler.c >>> index e359930..0d77430 100644 >>> --- a/drivers/fpga/xilinx-pr-decoupler.c >>> +++ b/drivers/fpga/xilinx-pr-decoupler.c >>> @@ -79,7 +79,7 @@ static int xlnx_pr_decoupler_enable_show(struct fpga_bridge *bridge) >>> return !status; >>> } >>> >>> -static struct fpga_bridge_ops xlnx_pr_decoupler_br_ops = { >>> +static const struct fpga_bridge_ops xlnx_pr_decoupler_br_ops = { >>> .enable_set = xlnx_pr_decoupler_enable_set, >>> .enable_show = xlnx_pr_decoupler_enable_show, >>> }; > > Must've been a leftover from when I worked on integrating a simple > GPIO based one. > I'll have to rebase that and submit it. >>> >> >> Acked-by: Michal Simek Signed-off-by: Alan Tull >> >> Thanks, >> Michal >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-fpga" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html > > Thanks, > Moritz From mboxrd@z Thu Jan 1 00:00:00 1970 From: atull@kernel.org (Alan Tull) Date: Thu, 21 Sep 2017 09:42:46 -0500 Subject: [PATCH] fpga: make xlnx_pr_decoupler_br_ops const In-Reply-To: References: <1503941531-17977-1-git-send-email-bhumirks@gmail.com> <78e2ed1d-ea20-eb68-b6b4-d993a98984a6@xilinx.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Aug 29, 2017 at 11:09 AM, Moritz Fischer wrote: > On Tue, Aug 29, 2017 at 12:00 AM, Michal Simek wrote: >> On 28.8.2017 19:32, Bhumika Goyal wrote: >>> Make this const as it is only passed to a const argument of the function >>> fpga_bridge_register. >>> >>> Signed-off-by: Bhumika Goyal > > Acked-by: Moritz Fischer >>> --- >>> drivers/fpga/xilinx-pr-decoupler.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/fpga/xilinx-pr-decoupler.c b/drivers/fpga/xilinx-pr-decoupler.c >>> index e359930..0d77430 100644 >>> --- a/drivers/fpga/xilinx-pr-decoupler.c >>> +++ b/drivers/fpga/xilinx-pr-decoupler.c >>> @@ -79,7 +79,7 @@ static int xlnx_pr_decoupler_enable_show(struct fpga_bridge *bridge) >>> return !status; >>> } >>> >>> -static struct fpga_bridge_ops xlnx_pr_decoupler_br_ops = { >>> +static const struct fpga_bridge_ops xlnx_pr_decoupler_br_ops = { >>> .enable_set = xlnx_pr_decoupler_enable_set, >>> .enable_show = xlnx_pr_decoupler_enable_show, >>> }; > > Must've been a leftover from when I worked on integrating a simple > GPIO based one. > I'll have to rebase that and submit it. >>> >> >> Acked-by: Michal Simek Signed-off-by: Alan Tull >> >> Thanks, >> Michal >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-fpga" in >> the body of a message to majordomo at vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html > > Thanks, > Moritz