All of lore.kernel.org
 help / color / mirror / Atom feed
From: delicious quinoa <delicious.quinoa@gmail.com>
To: Josh Cartwright <joshc@codeaurora.org>
Cc: Linus Walleij <linus.walleij@linaro.com>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
	"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
	Jamie Iles <jamie@jamieiles.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Grant Likely <grant.likely@secretlab.ca>,
	Mark Rutland <mark.rutland@arm.com>,
	Steffen Trumtrar <s.trumtrar@pengutronix.de>,
	Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
	Heiko Stuebner <heiko@sntech.de>, Alan Tull <atull@altera.com>,
	Dinh Nguyen <dinguyen@altera.com>,
	Yves Vandervennet <rocket.yvanderv@gmail.com>
Subject: Re: [PATCH v12] gpio: add a driver for the Synopsys DesignWare APB GPIO block
Date: Thu, 6 Mar 2014 09:58:28 -0600	[thread overview]
Message-ID: <CANk1AXTZFKH45qmGip8sc5KYxHNwfZqogrPfXOzz+sz-xyuosw@mail.gmail.com> (raw)
In-Reply-To: <20140306135019.GF18529@joshc.qualcomm.com>

On Thu, Mar 6, 2014 at 7:50 AM, Josh Cartwright <joshc@codeaurora.org> wrote:
> On Tue, Feb 25, 2014 at 05:01:01PM -0600, Alan Tull wrote:
>> From: Jamie Iles <jamie@jamieiles.com>
>>
>> The Synopsys DesignWare block is used in some ARM devices (picoxcell)
>> and can be configured to provide multiple banks of GPIO pins.
>>
>> Signed-off-by: Jamie Iles <jamie@jamieiles.com>
>> Signed-off-by: Alan Tull <atull@altera.com>
>> Reviewed-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
> [..]
>> --- a/drivers/gpio/Kconfig
>> +++ b/drivers/gpio/Kconfig
>> @@ -128,6 +128,15 @@ config GPIO_GENERIC_PLATFORM
>>       help
>>         Say yes here to support basic platform_device memory-mapped GPIO controllers.
>>
>> +config GPIO_DWAPB
>> +     tristate "Synopsys DesignWare APB GPIO driver"
>> +     select GPIO_GENERIC
>> +     select GENERIC_IRQ_CHIP
>> +     depends on OF_GPIO && IRQ_DOMAIN
>> +     help
>> +       Say Y or M here to build support for the Synopsys DesignWare APB
>> +       GPIO block.
>> +
>
> Looks like this hit next-20140306, when just doing a simple 'make defconfig', I get:
>
> kernel/irq/Kconfig:41:error: recursive dependency detected!
> kernel/irq/Kconfig:41:  symbol GENERIC_IRQ_CHIP is selected by GPIO_DWAPB
> drivers/gpio/Kconfig:131:       symbol GPIO_DWAPB depends on IRQ_DOMAIN
> kernel/irq/Kconfig:46:  symbol IRQ_DOMAIN is selected by GENERIC_IRQ_CHIP
>
> Not sure the best course of action here..
>
> --
> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
> hosted by The Linux Foundation

The fix is:

diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
index 9979017..0e524d7 100644
--- a/drivers/gpio/Kconfig
+++ b/drivers/gpio/Kconfig
@@ -132,7 +132,7 @@ config GPIO_DWAPB
        tristate "Synopsys DesignWare APB GPIO driver"
        select GPIO_GENERIC
        select GENERIC_IRQ_CHIP
-       depends on OF_GPIO && IRQ_DOMAIN
+       depends on OF_GPIO
        help
          Say Y or M here to build support for the Synopsys DesignWare APB
          GPIO block.

Apologies for missing this.

Alan Tull
aka
delicious quinoa

  reply	other threads:[~2014-03-06 15:58 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-25 23:01 [PATCH v12] gpio: add a driver for the Synopsys DesignWare APB GPIO block Alan Tull
2014-02-25 23:01 ` Alan Tull
2014-02-26 15:53 ` delicious quinoa
2014-02-26 16:02   ` Dinh Nguyen
2014-03-05  1:01 ` Linus Walleij
2014-03-05 15:30   ` delicious quinoa
2014-03-06 13:50 ` Josh Cartwright
2014-03-06 15:58   ` delicious quinoa [this message]
2014-03-07  1:18     ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CANk1AXTZFKH45qmGip8sc5KYxHNwfZqogrPfXOzz+sz-xyuosw@mail.gmail.com \
    --to=delicious.quinoa@gmail.com \
    --cc=atull@altera.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dinguyen@altera.com \
    --cc=grant.likely@secretlab.ca \
    --cc=heiko@sntech.de \
    --cc=jamie@jamieiles.com \
    --cc=joshc@codeaurora.org \
    --cc=linus.walleij@linaro.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=rocket.yvanderv@gmail.com \
    --cc=s.trumtrar@pengutronix.de \
    --cc=sebastian.hesselbarth@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.