From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Wood Subject: Re: [PATCH i-g-t 2/4] lib: add the ability to set an EDID data block on a connector Date: Wed, 18 Jun 2014 15:03:25 +0100 Message-ID: References: <1403099053-31243-1-git-send-email-thomas.wood@intel.com> <1403099053-31243-3-git-send-email-thomas.wood@intel.com> <20140618135717.GH5821@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-yk0-f170.google.com (mail-yk0-f170.google.com [209.85.160.170]) by gabe.freedesktop.org (Postfix) with ESMTP id 3D9486E5AE for ; Wed, 18 Jun 2014 07:03:26 -0700 (PDT) Received: by mail-yk0-f170.google.com with SMTP id q9so604551ykb.1 for ; Wed, 18 Jun 2014 07:03:25 -0700 (PDT) In-Reply-To: <20140618135717.GH5821@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter Cc: Intel Graphics Development List-Id: intel-gfx@lists.freedesktop.org On 18 June 2014 14:57, Daniel Vetter wrote: > On Wed, Jun 18, 2014 at 02:44:11PM +0100, Thomas Wood wrote: >> +/** >> + * kmstest_generic_edid: >> + * @EDID_XGA: 1024x768 >> + * @EDID_SXGA: 1280x1024 >> + * @EDID_UXGA: 1600x1200 >> + * @EDID_WSXGA: 1680x1050 >> + * @EDID_FHD: 1920x1080 >> + * @MAX_EDIDS: Size of #generic_edid array >> + */ >> +enum kmstest_generic_edid { >> + EDID_XGA, /* 1024x768 */ >> + EDID_SXGA, /* 1280x1024 */ >> + EDID_UXGA, /* 1600x1200 */ >> + EDID_WSXGA, /* 1680x1050 */ >> + EDID_FHD, /* 1920x1080 */ > > Hm, can't we have just one full hd edid which supports all the above > modes? Yes, although for kms_force_connector I actually wanted two different EDIDs to make sure overwriting the value worked correctly. > -Daniel > -- > Daniel Vetter > Software Engineer, Intel Corporation > +41 (0) 79 365 57 48 - http://blog.ffwll.ch