From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C86CC433F5 for ; Fri, 17 Sep 2021 16:41:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 27E3061152 for ; Fri, 17 Sep 2021 16:41:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238584AbhIQQnM (ORCPT ); Fri, 17 Sep 2021 12:43:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39390 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229456AbhIQQnL (ORCPT ); Fri, 17 Sep 2021 12:43:11 -0400 Received: from mail-qk1-x734.google.com (mail-qk1-x734.google.com [IPv6:2607:f8b0:4864:20::734]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 572A8C061574 for ; Fri, 17 Sep 2021 09:41:49 -0700 (PDT) Received: by mail-qk1-x734.google.com with SMTP id y144so19302639qkb.6 for ; Fri, 17 Sep 2021 09:41:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=aBN/qteeDyWq3TS58wIG7jkerkKlW6l9HEuk/o/IJuw=; b=r5mpIFNZvGulvdrw3rSLgYXpkDniFlpqk5vIULMa+KB0DSjC28smVp6qRCp2hx55KZ C4sTR9D7nkm8LoE9ZXEqyiL7m2oIlikhWrHvuPrW8t73lOOGv29onrZwgMYuDfgG6G51 QUnP3bJlu6rxqfxLYJVgkB1SdeBqcNVzWBUooCooS2O+eVHQat+mW4JxvG36gYoGErEK AulBCrYlpJTodeN2Z9BvVIB24MYOZnJv36Kcns6HJWf3FDP5iUYcae97ZrJ2j6liyXp7 YpSVbh+ZLL8UK4jj+BK4JmxMhc09hMRnUzTvpLwtnsVSRD+PW3axVnyOSV1/ekEg4ud2 M/dA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=aBN/qteeDyWq3TS58wIG7jkerkKlW6l9HEuk/o/IJuw=; b=Xwu+/hqJq5pRA1acifLrVCVoROU2t1Upu1xgtGukUZ6LyXM8n2IF5rGWgVEePY7i1T kKiaFgsrDiNb56I6yByp1y5Aa+ehgkTinPIAmAFBBte6ZAQaY/A56aw4LaHNJSbIfdiB iyiGjLyJZzDtqFgsZQvLhgZ3duhaSE0E/INdQ5pOVC0isP+pr+A6IUxsZWtL8aXrGj/p 9P9Oeamogl7LsOfqKLNfqUdgaxJAYs1D+Iho/lQU0wl3CXaFjsYu62BBHH8+WD0/fNIg 7J4Ndx9qo9JzTSQade+4SQKsd09TJ/FSqKZo7n+DDpdGOd8rJA6rJePoMiTrQ5bUoHVL AVGA== X-Gm-Message-State: AOAM531zJd8ZH6cxVqvGvAqlIWsMcIi3AS1dq6sPhRmkGMLm/3CJTPiY mxq+bKfd6dZUsq2lxqk6hc1SJd7KV527IM0NrWrCOA== X-Google-Smtp-Source: ABdhPJx8xbbL5om+QcGPAEAT3lJo4fDv/2nif/i01ZdnYHpFl6YANYMunB9IPePN6HRZD/WUU4luVE20BYE6hg38u5A= X-Received: by 2002:a25:c011:: with SMTP id c17mr14015458ybf.291.1631896908105; Fri, 17 Sep 2021 09:41:48 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Eric Dumazet Date: Fri, 17 Sep 2021 09:41:36 -0700 Message-ID: Subject: Re: [RFC PATCH 4/5] Partially revert "tcp: factor out tcp_build_frag()" To: Paolo Abeni Cc: netdev , "David S. Miller" , Jakub Kicinski , Mat Martineau , Ayush Sawal , MPTCP Upstream Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Sep 17, 2021 at 8:39 AM Paolo Abeni wrote: > > This is a partial revert for commit b796d04bd014 ("tcp: > factor out tcp_build_frag()"). > > MPTCP was the only user of the tcp_build_frag helper, and after > the previous patch MPTCP does not use the mentioned helper anymore. > Let's avoid exposing TCP internals. > > The revert is partial, as tcp_remove_empty_skb(), exposed > by the same commit is still required. > I would simply remove the extern in include, and make this nice helper static ? This would avoid code churn, and keep a clean code. Thanks ! From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f180.google.com (mail-qk1-f180.google.com [209.85.222.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 844623FC3 for ; Fri, 17 Sep 2021 16:41:49 +0000 (UTC) Received: by mail-qk1-f180.google.com with SMTP id 73so14237061qki.4 for ; Fri, 17 Sep 2021 09:41:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=aBN/qteeDyWq3TS58wIG7jkerkKlW6l9HEuk/o/IJuw=; b=r5mpIFNZvGulvdrw3rSLgYXpkDniFlpqk5vIULMa+KB0DSjC28smVp6qRCp2hx55KZ C4sTR9D7nkm8LoE9ZXEqyiL7m2oIlikhWrHvuPrW8t73lOOGv29onrZwgMYuDfgG6G51 QUnP3bJlu6rxqfxLYJVgkB1SdeBqcNVzWBUooCooS2O+eVHQat+mW4JxvG36gYoGErEK AulBCrYlpJTodeN2Z9BvVIB24MYOZnJv36Kcns6HJWf3FDP5iUYcae97ZrJ2j6liyXp7 YpSVbh+ZLL8UK4jj+BK4JmxMhc09hMRnUzTvpLwtnsVSRD+PW3axVnyOSV1/ekEg4ud2 M/dA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=aBN/qteeDyWq3TS58wIG7jkerkKlW6l9HEuk/o/IJuw=; b=TDKdY0q3EwrriJp5ehlKbZrfuuLwvgd/Tl2pbIaKL2kIPwkvTIKROjeGYfsBrmabTg bA1g8TPg560Zv30npzdLCGiC9QCziyn/L/RXIsQn0sk9HrBSru8MwCPgy+PHdXn5gZic xoqb3tGEQUtWO2B/cyChi5Pr4P5l2Y0z4nwu06Gc8PH+YGuXemtgUFgzSPkTiYFjEMC+ xQ2dGAh/l1ydn+LSAue+NkjIV8PXPw4aAawKwI0AVweBVyU+Zu8PvVtnXZnKwieK8q9S irLIsMaFWSRKn/h56OuaPmzsf5NSfM08fiCsqpj+m0ntmIt/jaq1Zx/ZTH1fw7KPrc8M av+A== X-Gm-Message-State: AOAM5319mIKo2WqcVHhhGcYGxnLHc4NjEFXx3gESqBxQg1xmuzaJu5ZR M+z8U+fe1CE1OQ5r6qfIpJoolhZ7RGZBpsfkrr8Frg== X-Google-Smtp-Source: ABdhPJx8xbbL5om+QcGPAEAT3lJo4fDv/2nif/i01ZdnYHpFl6YANYMunB9IPePN6HRZD/WUU4luVE20BYE6hg38u5A= X-Received: by 2002:a25:c011:: with SMTP id c17mr14015458ybf.291.1631896908105; Fri, 17 Sep 2021 09:41:48 -0700 (PDT) Precedence: bulk X-Mailing-List: mptcp@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: In-Reply-To: From: Eric Dumazet Date: Fri, 17 Sep 2021 09:41:36 -0700 Message-ID: Subject: Re: [RFC PATCH 4/5] Partially revert "tcp: factor out tcp_build_frag()" To: Paolo Abeni Cc: netdev , "David S. Miller" , Jakub Kicinski , Mat Martineau , Ayush Sawal , MPTCP Upstream Content-Type: text/plain; charset="UTF-8" On Fri, Sep 17, 2021 at 8:39 AM Paolo Abeni wrote: > > This is a partial revert for commit b796d04bd014 ("tcp: > factor out tcp_build_frag()"). > > MPTCP was the only user of the tcp_build_frag helper, and after > the previous patch MPTCP does not use the mentioned helper anymore. > Let's avoid exposing TCP internals. > > The revert is partial, as tcp_remove_empty_skb(), exposed > by the same commit is still required. > I would simply remove the extern in include, and make this nice helper static ? This would avoid code churn, and keep a clean code. Thanks !