From: Eric Dumazet <edumazet@google.com>
To: Kuniyuki Iwashima <kuniyu@amazon.com>
Cc: "David S. Miller" <davem@davemloft.net>,
David Ahern <dsahern@kernel.org>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Lorenzo Colitti <lorenzo@google.com>,
Benjamin Herrenschmidt <benh@amazon.com>,
Ayushman Dutta <ayudutta@amazon.com>,
netdev <netdev@vger.kernel.org>,
syzbot+a8430774139ec3ab7176@syzkaller.appspotmail.com
Subject: Re: [PATCH v2 net] net: ping6: Fix memleak in ipv6_renew_options().
Date: Thu, 28 Jul 2022 18:50:01 +0200 [thread overview]
Message-ID: <CANn89i+fRjiD91PZ1cXkhUingdr8p6nXdkTS=NVXSRK3zqjDxw@mail.gmail.com> (raw)
In-Reply-To: <20220728012220.46918-1-kuniyu@amazon.com>
On Thu, Jul 28, 2022 at 3:22 AM Kuniyuki Iwashima <kuniyu@amazon.com> wrote:
>
> When we close ping6 sockets, some resources are left unfreed because
> pingv6_prot is missing sk->sk_prot->destroy(). As reported by
> syzbot [0], just three syscalls leak 96 bytes and easily cause OOM.
>
>
> Fixes: 6d0bfe226116 ("net: ipv6: Add IPv6 support to the ping socket.")
> Reported-by: syzbot+a8430774139ec3ab7176@syzkaller.appspotmail.com
> Reported-by: Ayushman Dutta <ayudutta@amazon.com>
> Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com>
> ---
> v2:
> - Remove ip6_flush_pending_frames() (Jakub Kicinski)
Nice catch, thanks.
Reviewed-by: Eric Dumazet <edumazet@google.com>
next prev parent reply other threads:[~2022-07-28 16:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-28 1:22 [PATCH v2 net] net: ping6: Fix memleak in ipv6_renew_options() Kuniyuki Iwashima
2022-07-28 3:11 ` Jakub Kicinski
2022-07-28 16:13 ` David Ahern
2022-07-28 16:50 ` Eric Dumazet [this message]
2022-07-28 18:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANn89i+fRjiD91PZ1cXkhUingdr8p6nXdkTS=NVXSRK3zqjDxw@mail.gmail.com' \
--to=edumazet@google.com \
--cc=ayudutta@amazon.com \
--cc=benh@amazon.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=kuba@kernel.org \
--cc=kuniyu@amazon.com \
--cc=lorenzo@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=syzbot+a8430774139ec3ab7176@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.