From: Eric Dumazet <edumazet@google.com>
To: Yuchung Cheng <ycheng@google.com>
Cc: "Neal Cardwell" <ncardwell@google.com>,
"Eric Dumazet" <eric.dumazet@gmail.com>,
"David Miller" <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>,
"Toke Høiland-Jørgensen" <toke@toke.dk>,
"Soheil Hassas Yeganeh" <soheil@google.com>,
"Christoph Paasch" <cpaasch@apple.com>
Subject: Re: [PATCH net-next 3/4] tcp: add SACK compression
Date: Thu, 17 May 2018 10:15:16 -0700 [thread overview]
Message-ID: <CANn89i+kSB9WCNVFyJsdS3wvf=wVHPCFx=D3ZopNAxs4vEcSEg@mail.gmail.com> (raw)
In-Reply-To: <CAK6E8=e=L3oDLwAJze0Af_YXYBOBvpWTZHpBSPcGjUmuvLCKXQ@mail.gmail.com>
On Thu, May 17, 2018 at 9:59 AM Yuchung Cheng <ycheng@google.com> wrote:
> >
> > Thanks for implementing this! Overall this patch seems nice to me.
> >
> > Acked-by: Neal Cardwell <ncardwell@google.com>
> >
> > BTW, I guess we should spread the word to maintainers of other major TCP
> > stacks that they need to be prepared for what may be a much higher
degree
> > of compression/aggregation in the SACK stream. Linux stacks going back
many
> > years should be fine with this, but I'm not sure about the other major
OSes
> > (they may only allow sending one MSS per ACK-with-SACKs received).
> Patch looks really good but Neal's comment just reminds me a potential
> legacy issue.
> I recall at least Apple and Windows TCP stacks still need 3+ DUPACKs
> (!= a SACK covering 3+ packets) to trigger fast recovery. Will we have
> an issue there interacting w/ these stacks?
Then we should revert GRO :)
Really it is time for these stacks to catch up, or give up to QUIC :/
next prev parent reply other threads:[~2018-05-17 17:15 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-17 12:12 [PATCH net-next 0/4] tcp: implement SACK compression Eric Dumazet
2018-05-17 12:12 ` [PATCH net-next 1/4] tcp: use __sock_put() instead of sock_put() in tcp_clear_xmit_timers() Eric Dumazet
2018-05-17 14:53 ` Neal Cardwell
2018-05-17 12:12 ` [PATCH net-next 2/4] tcp: do not force quickack when receiving out-of-order packets Eric Dumazet
2018-05-17 14:55 ` Neal Cardwell
2018-05-17 17:14 ` Soheil Hassas Yeganeh
2018-05-17 12:12 ` [PATCH net-next 3/4] tcp: add SACK compression Eric Dumazet
2018-05-17 15:14 ` Neal Cardwell
2018-05-17 15:40 ` Eric Dumazet
2018-05-17 15:46 ` Eric Dumazet
2018-05-17 16:41 ` Neal Cardwell
2018-05-17 16:59 ` Yuchung Cheng
2018-05-17 17:15 ` Yuchung Cheng
2018-05-17 17:15 ` Eric Dumazet [this message]
2018-05-17 12:12 ` [PATCH net-next 4/4] tcp: add TCPAckCompressed SNMP counter Eric Dumazet
2018-05-17 14:55 ` Neal Cardwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANn89i+kSB9WCNVFyJsdS3wvf=wVHPCFx=D3ZopNAxs4vEcSEg@mail.gmail.com' \
--to=edumazet@google.com \
--cc=cpaasch@apple.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=soheil@google.com \
--cc=toke@toke.dk \
--cc=ycheng@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.