All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Dumazet <edumazet@google.com>
To: Muchun Song <songmuchun@bytedance.com>
Cc: David Miller <davem@davemloft.net>,
	Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
	David Ahern <dsahern@kernel.org>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	netdev <netdev@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>, Willy Tarreau <w@1wt.eu>
Subject: Re: [PATCH v2] tcp: use alloc_large_system_hash() to allocate table_perturb
Date: Wed, 8 Jun 2022 21:03:31 -0700	[thread overview]
Message-ID: <CANn89i+wqVnfwOcpvnBwoF4ZvjZL-RcsqdT5khu-3CHpCcoKTQ@mail.gmail.com> (raw)
In-Reply-To: <20220607070214.94443-1-songmuchun@bytedance.com>

On Tue, Jun 7, 2022 at 12:02 AM Muchun Song <songmuchun@bytedance.com> wrote:
>
> In our server, there may be no high order (>= 6) memory since we reserve
> lots of HugeTLB pages when booting.  Then the system panic.  So use
> alloc_large_system_hash() to allocate table_perturb.
>
> Fixes: e9261476184b ("tcp: dynamically allocate the perturb table used by source ports")
> Signed-off-by: Muchun Song <songmuchun@bytedance.com>
> ---
> v2:
>  - Add Fixes tag and replace kvmalloc_array with alloc_large_system_hash suggested
>    by Eric Dumazet.
>

Reviewed-by: Eric Dumazet <edumazet@google.com>

Thanks.

  reply	other threads:[~2022-06-09  4:03 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-07  7:02 [PATCH v2] tcp: use alloc_large_system_hash() to allocate table_perturb Muchun Song
2022-06-09  4:03 ` Eric Dumazet [this message]
2022-06-09  4:20 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CANn89i+wqVnfwOcpvnBwoF4ZvjZL-RcsqdT5khu-3CHpCcoKTQ@mail.gmail.com \
    --to=edumazet@google.com \
    --cc=davem@davemloft.net \
    --cc=dsahern@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=songmuchun@bytedance.com \
    --cc=w@1wt.eu \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.