From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id BE424C433EF
	for <linux-kernel@archiver.kernel.org>; Thu, 12 May 2022 23:53:42 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1359663AbiELXxj (ORCPT
        <rfc822;linux-kernel@archiver.kernel.org>);
        Thu, 12 May 2022 19:53:39 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47784 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1359655AbiELXxe (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 12 May 2022 19:53:34 -0400
Received: from mail-yw1-x112e.google.com (mail-yw1-x112e.google.com [IPv6:2607:f8b0:4864:20::112e])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E691B289BED
        for <linux-kernel@vger.kernel.org>; Thu, 12 May 2022 16:53:32 -0700 (PDT)
Received: by mail-yw1-x112e.google.com with SMTP id 00721157ae682-2f7bb893309so73908007b3.12
        for <linux-kernel@vger.kernel.org>; Thu, 12 May 2022 16:53:32 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=google.com; s=20210112;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=uhq4ya9xMklJArQ5M6XpMXqCdudCMNIUXQuFqsQyCsQ=;
        b=UTGN2VdZXEMXwGEbxJjf++SztOH2q/oKnmHmg/ErIIRsbJjLFtK1MZ4QXV8vh70YST
         LMr7FpE1WZxhV2l7fvcdX5/+kj9QQTyOE5LaBE4AV4cq1CkyEA1JFITNyRyUN7hh3uVO
         PvrfM5Fd6RNp5S2OkRnCm9seRmC3Haq01sKHHga2x9Tp2sotZl6tHpV9vbi3r9qhAc63
         7gesz/BZ02SgkNVcDWNR3ITkWqxV+ADQZfICJsmkYB74fb15L1GQBDjOA/ozTxflqLx8
         QsVmczy/yx1AppjC3JvEPRP13FptT6SqXl1MNEMWHuyL6wb5ok9eNMNAILNToaJyljia
         4mew==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=uhq4ya9xMklJArQ5M6XpMXqCdudCMNIUXQuFqsQyCsQ=;
        b=IiL7BfO3Wq4SkWUsk+2FtgMAgF7joo8fETLgkwfnj/ixV4pQTFhfBqOW20UfLffeDF
         VXalU/FcJcdBfFNLyDlzihZ1TZjRlUaOEUxp+PoVnnw+r8L3upNHlWsP73W+m0iCqEFs
         UKvFq9uWRIYBm4cH0iba63IuYlV2rdtMfmtf0KOPlIrEKpl04Vc1jYPH7rvZY5SpN5qo
         1KKzueWaCzSE7+kPZuRNjU+I9BQJXdPCGAF3dJGKPOTetFuu3BYMN8WeQEfvNyMmJTG7
         TIGQRNrFBm+zFEHEvwK7JXTiBXXp5clX9ou8/Knxy5B/EiuKhmwDAKkegE/y8ZUm6PNs
         XX8g==
X-Gm-Message-State: AOAM533F8aFXgPuEjO5VlqBf4DLOWpewRq/f26zjgMPT05oP4QP2ikhg
        NwiWCJMVYgs++QF1sCUWmbrci0qUuchGk0vAUecY4A==
X-Google-Smtp-Source: ABdhPJxoK2lh3f0jskM3unr9zg4jpxpAXX2hXYSWdYU7TuB+VAnDEoW2oM6/cBBvO4ZKyecZDL+/x/UQzutiRIfdQLo=
X-Received: by 2002:a81:5603:0:b0:2f8:3187:f37a with SMTP id
 k3-20020a815603000000b002f83187f37amr2712263ywb.255.1652399611138; Thu, 12
 May 2022 16:53:31 -0700 (PDT)
MIME-Version: 1.0
References: <0000000000005f1a8805ded719cc@google.com> <CANn89i+XHh1An6fDA0CH1Fb2k_-G8_CCzEmXGKqB4tRAMH9s4w@mail.gmail.com>
 <20220512155136.70554388@kernel.org>
In-Reply-To: <20220512155136.70554388@kernel.org>
From:   Eric Dumazet <edumazet@google.com>
Date:   Thu, 12 May 2022 16:53:19 -0700
Message-ID: <CANn89i+xqQafpRrF7=G0FqJNZkQUBCt_sKsSbhG64bq0iCnztQ@mail.gmail.com>
Subject: Re: [syzbot] UBSAN: shift-out-of-bounds in tcf_pedit_init
To:     Jakub Kicinski <kuba@kernel.org>
Cc:     syzbot <syzbot+8ed8fc4c57e9dcf23ca6@syzkaller.appspotmail.com>,
        David Miller <davem@davemloft.net>,
        Jamal Hadi Salim <jhs@mojatatu.com>,
        Jiri Pirko <jiri@resnulli.us>,
        LKML <linux-kernel@vger.kernel.org>,
        netdev <netdev@vger.kernel.org>, Paolo Abeni <pabeni@redhat.com>,
        syzkaller-bugs <syzkaller-bugs@googlegroups.com>,
        Cong Wang <xiyou.wangcong@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, May 12, 2022 at 3:51 PM Jakub Kicinski <kuba@kernel.org> wrote:
>
> On Thu, 12 May 2022 14:19:51 -0700 Eric Dumazet wrote:
> > On Thu, May 12, 2022 at 2:18 PM syzbot
> > > This report is generated by a bot. It may contain errors.
> > > See https://goo.gl/tpsmEJ for more information about syzbot.
> > > syzbot engineers can be reached at syzkaller@googlegroups.com.
> > >
> > > syzbot will keep track of this issue. See:
> > > https://goo.gl/tpsmEJ#status for how to communicate with syzbot.
> > > syzbot can test patches for this issue, for details see:
> > > https://goo.gl/tpsmEJ#testing-patches
> >
> > As mentioned earlier, this came with
> >
> > commit 8b796475fd7882663a870456466a4fb315cc1bd6
> > Author: Paolo Abeni <pabeni@redhat.com>
> > Date:   Tue May 10 16:57:34 2022 +0200
> >
> >     net/sched: act_pedit: really ensure the skb is writable
>
> Came in as in new stack trace for an old/existing bug, right?
> Nothing checks the shift so it'd have already tripped UBSAN
> later on in tcf_pedit_act(), anyway.

Maybe a prior syzbot was reported, and nobody cared.

Or maybe syzbot got its way into this path only recently.