From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3823AC433EF for ; Thu, 21 Apr 2022 02:00:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1383759AbiDUCDI (ORCPT ); Wed, 20 Apr 2022 22:03:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42926 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1383776AbiDUCDC (ORCPT ); Wed, 20 Apr 2022 22:03:02 -0400 Received: from mail-yw1-x112f.google.com (mail-yw1-x112f.google.com [IPv6:2607:f8b0:4864:20::112f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A5A91101D1 for ; Wed, 20 Apr 2022 19:00:13 -0700 (PDT) Received: by mail-yw1-x112f.google.com with SMTP id 00721157ae682-2ec42eae76bso37480217b3.10 for ; Wed, 20 Apr 2022 19:00:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=AE7l3U3Ok/l/ma4wVBxTAWhqFVPfRK/mIEy0ba9HyK0=; b=mZ9Ge9eiHVANFgD4+KOUXL1r2F71/Kiyi5Ioyx/BT61bDLjjP95WftDAMJrBH//GBC kV63YgO+r6UptKN1T3M+prV/q4e1QlwHPXiwAuPcyrYzA/F1hQbLYtN1JgyS55X3OimJ eOBuVnNJg4CnBIZLypL2m4P06HJxTDCet3rYw5r1EAw/FPMrPwUF2xXOTRWKVcVet2Lq S/uQ6UisWZiXssiKxQJ7aiN30BdjW6+ETRI0pR5fQmWbIt+FzLk1ZBLDUx6HmxEkmfT/ 7WSh2BNHOP5jm4tR7JnBcG55if9Tr9Ri4sRI97AEOydNb3VDhfC5keLovEe+sLJlHw0F 9lGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=AE7l3U3Ok/l/ma4wVBxTAWhqFVPfRK/mIEy0ba9HyK0=; b=q8iMi3mIsktCPtR0v3h3lr8mPlAvmStJedFIqHtL42QdanuZ1HFDUA08AAoeywMEWb LwM406H2OfbJN/qUKDbLlA1xaijJBAdOV7d0Te9+WADr6TGu3O4gAaVobMaqkzDXwSZh bRleHxx4PFFJZOmOSzl1r5XLoYQ4WDYzwf/Sl+J0MDQeERhGliad282YwMrLml9db/GT uV636K5uE94QT+/vLRKdhPZx0Y4wbwnLei6E8OkjlAq5nLXXxjLhPWbsEmAMMfRoX6oK IqrYg1W2HoVB0gyAvCspLEB6WPJotRDSyMnnzJE8G9tDQTUA9VfT7Fcm81ho5MsX2tP/ MJZQ== X-Gm-Message-State: AOAM533cWuuBcps3U8LII6uGjKojW3mrx++pdVyQDshRmi5mQeucVQSe h5SfMFkatE89asleLGaXlndEyxFORj3a24dGfJZjijBFgH9EAw== X-Google-Smtp-Source: ABdhPJxY/JAVTGMP2eoLuvovfMVq8brdmJ26/zPXma9LAq3yXWvRIrK3lcHo514gkcUIfT8zyY3+9TvhKloqfqWgcQs= X-Received: by 2002:a0d:cb07:0:b0:2f1:c718:b273 with SMTP id n7-20020a0dcb07000000b002f1c718b273mr11764955ywd.467.1650506412639; Wed, 20 Apr 2022 19:00:12 -0700 (PDT) MIME-Version: 1.0 References: <20220421005026.686A45EC01F2@us226.sjc.aristanetworks.com> In-Reply-To: <20220421005026.686A45EC01F2@us226.sjc.aristanetworks.com> From: Eric Dumazet Date: Wed, 20 Apr 2022 19:00:01 -0700 Message-ID: Subject: Re: [PATCH v2 net] tcp: md5: incorrect tcp_header_len for incoming connections To: Francesco Ruggeri Cc: Paolo Abeni , Jakub Kicinski , David Ahern , Hideaki YOSHIFUJI , David Miller , LKML , netdev Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 20, 2022 at 5:50 PM Francesco Ruggeri wrote: > > In tcp_create_openreq_child we adjust tcp_header_len for md5 using the > remote address in newsk. But that address is still 0 in newsk at this > point, and it is only set later by the callers (tcp_v[46]_syn_recv_sock). > Use the address from the request socket instead. > > > > Fixes: cfb6eeb4c860 ("[TCP]: MD5 Signature Option (RFC2385) support.") > Signed-off-by: Francesco Ruggeri Thanks for fixing this Francesco. Reviewed-by: Eric Dumazet