All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Dumazet <edumazet@google.com>
To: Pietro Borrello <borrello@diag.uniroma1.it>
Cc: Kuniyuki Iwashima <kuniyu@amazon.com>,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
	David Ahern <dsahern@kernel.org>,
	Cristiano Giuffrida <c.giuffrida@vu.nl>,
	"Bos, H.J." <h.j.bos@vu.nl>, Jakob Koschel <jkl820.git@gmail.com>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] inet: fix fast path in __inet_hash_connect()
Date: Sat, 14 Jan 2023 13:21:36 +0100	[thread overview]
Message-ID: <CANn89iJCphvKBWcV1iGdTe9OXWiv1gQCTub60b1v2qi=pYLoSw@mail.gmail.com> (raw)
In-Reply-To: <CAEih1qWQf1JK4vbdzcTb1yXADxTV4+AqtJkvnK1T895obUTtOQ@mail.gmail.com>

On Sat, Jan 14, 2023 at 1:18 PM Pietro Borrello
<borrello@diag.uniroma1.it> wrote:
>
> On Fri, 13 Jan 2023 at 13:16, Eric Dumazet <edumazet@google.com> wrote:
> > 1) Given this path was never really used, we have no coverage.
> >
> > 2) Given that we do not check inet_ehash_nolisten() return code here.
>
> It seems there are a bunch of call sites where inet_ehash_nolisten() return
> code is not checked, thus I didn't think of it to be a problem.
>
> >
> > I would recommend _not_ adding the Fixes: tag, and target net-next tree
> >
> > In fact, I would remove this dead code, and reduce complexity.
> >
>
> This makes a lot of sense. I can post a v3 patch completely removing
> the fast path.
>
> However, this patch's v1 was already reviewed by
> Kuniyuki Iwashima <kuniyu@amazon.com>, v2 is a nit, if posting a v3
> I think I should remove the Reviewed-by: since it would completely
> change the patch, but what is the preferred fix?
>

Yes, remove it, and Kuniyuki will review it again, thanks.

      reply	other threads:[~2023-01-14 12:21 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-13 11:39 [PATCH v2] inet: fix fast path in __inet_hash_connect() Pietro Borrello
2023-01-13 12:16 ` Eric Dumazet
2023-01-14 12:17   ` Pietro Borrello
2023-01-14 12:21     ` Eric Dumazet [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CANn89iJCphvKBWcV1iGdTe9OXWiv1gQCTub60b1v2qi=pYLoSw@mail.gmail.com' \
    --to=edumazet@google.com \
    --cc=borrello@diag.uniroma1.it \
    --cc=c.giuffrida@vu.nl \
    --cc=davem@davemloft.net \
    --cc=dsahern@kernel.org \
    --cc=h.j.bos@vu.nl \
    --cc=jkl820.git@gmail.com \
    --cc=kuba@kernel.org \
    --cc=kuniyu@amazon.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.