From: Eric Dumazet <edumazet@google.com>
To: Tariq Toukan <tariqt@mellanox.com>
Cc: David Miller <davem@davemloft.net>,
Tal Gilboa <talgi@mellanox.com>, netdev <netdev@vger.kernel.org>,
Michael Wenig <mwenig@vmware.com>,
Eric Dumazet <eric.dumazet@gmail.com>
Subject: Re: [PATCH net] tcp: restore autocorking
Date: Thu, 03 May 2018 13:55:46 +0000 [thread overview]
Message-ID: <CANn89iJZRezHOL4y+_hPegxLTbosN8fVzHTCcw_8Yh+sHpZOoA@mail.gmail.com> (raw)
In-Reply-To: <298c3b30-d3d3-6069-dd46-bcf0ce315126@mellanox.com>
On Thu, May 3, 2018 at 4:06 AM Tariq Toukan <tariqt@mellanox.com> wrote:
> On 03/05/2018 6:25 AM, Eric Dumazet wrote:
> > When adding rb-tree for TCP retransmit queue, we inadvertently broke
> > TCP autocorking.
> >
> > tcp_should_autocork() should really check if the rtx queue is not empty.
> >
> Hi Eric,
> We are glad to see that the issue that Tal investigated and reported [1]
> is now addressed.
> Thanks for doing that!
> Tal, let’s perf test to see the effect of this fix.
> Best,
> Tariq
> [1] https://patchwork.ozlabs.org/cover/822218/
Yes, but you never really gave any insights of what exact tests you were
running :/
Sometimes the crystal ball is silent, sometimes it gives a hint :)
next prev parent reply other threads:[~2018-05-03 13:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-03 3:25 [PATCH net] tcp: restore autocorking Eric Dumazet
2018-05-03 11:06 ` Tariq Toukan
2018-05-03 13:55 ` Eric Dumazet [this message]
2018-05-03 14:27 ` Michael Wenig
2018-05-03 14:48 ` Neal Cardwell
2018-05-03 14:52 ` Soheil Hassas Yeganeh
2018-05-03 15:29 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANn89iJZRezHOL4y+_hPegxLTbosN8fVzHTCcw_8Yh+sHpZOoA@mail.gmail.com \
--to=edumazet@google.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=mwenig@vmware.com \
--cc=netdev@vger.kernel.org \
--cc=talgi@mellanox.com \
--cc=tariqt@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.