From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74FA6C433F5 for ; Thu, 17 Feb 2022 15:25:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242417AbiBQPZl (ORCPT ); Thu, 17 Feb 2022 10:25:41 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:56988 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232108AbiBQPZi (ORCPT ); Thu, 17 Feb 2022 10:25:38 -0500 Received: from mail-yb1-xb2d.google.com (mail-yb1-xb2d.google.com [IPv6:2607:f8b0:4864:20::b2d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A11E62B048B for ; Thu, 17 Feb 2022 07:25:24 -0800 (PST) Received: by mail-yb1-xb2d.google.com with SMTP id bt13so13809510ybb.2 for ; Thu, 17 Feb 2022 07:25:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=MQP46pb+DPsuzuoL3BGGcclWodDFs0G/3Es7HjdxUCo=; b=cMfVnVTpouxlUm+jaYnytrgpG4TUi9DLUb+yI8qFyskWkAnXv+M6au1/maKPGNtmO8 GcaWRklihf6L8yh393NfKIPLun4OQl9mYY1jRZzl8G0dxaxR37h911mKIPqAbIPKz/v+ 6NHpGj21rf8gWajcLnxmDL3+gi1yzfX/0r5GsyQNm0G3ZDxFDCyEhP0ciU9iVcvUP+7O O/wtUSIJGcfT+Ts4VAKp3Aryl+D1ZEsXMiVhErXbkzytbGDcWRcL5hG4Z9uexhoyPRc9 FH+/+Hlyt8N+opqaLI0HBwUBgEOZ3cX4lZaeTqsxqLys+lkPUrmtmR1F+dIq1tL4rZGb Yk0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=MQP46pb+DPsuzuoL3BGGcclWodDFs0G/3Es7HjdxUCo=; b=xKoZ7uQz2WNeDgQFlZ9NRwZKvTVjSiOER4EEGgRYB6Rry7BazRQJc0egt+iDmkH2Hr 7zAA8VTGiN8XjwArmaOn1QTW7QwkcW9W9A4ZyhSWH39W6EMc+g2B3MpqB2WH68cqmd5j PfaciHh5bJEMb612oFpB6KBtM/89EnhQWASABe5PwXFcdh9qOcl6vg7KiX7yE0MLx4N7 pVPmVi3ZFB/ngn97EDkNNYgMh2agfwABQW63xeIEpia1oDas3SWIAEqbFjqYF6EgWOXH YDhnhvuyCO2kyaYgxR0VCzxoXODaPkqdk97knDGPyFOgL7P5MIbs58tmutP+r/P5G/fK M2KQ== X-Gm-Message-State: AOAM530tGCRowsAQ0EANLLDBnI1+4y9qTUMJ5vjamkSFPl8gTO2Ra1fq /q2f6wlvU3XH4YUTTNcfqfI0JlgYcLtJxl+g95HJaA== X-Google-Smtp-Source: ABdhPJyRTktloudhS4FEJQohjippofIbUD6G2axzL1w3brFImkJhKhl9UwTpCXgO94Cef378CE+W+AWSzkPuQK6S+cM= X-Received: by 2002:a5b:7c6:0:b0:60b:a0ce:19b with SMTP id t6-20020a5b07c6000000b0060ba0ce019bmr2751275ybq.407.1645111523530; Thu, 17 Feb 2022 07:25:23 -0800 (PST) MIME-Version: 1.0 References: <20220217140441.1218045-1-andrzej.hajda@intel.com> <20220217140441.1218045-3-andrzej.hajda@intel.com> In-Reply-To: From: Eric Dumazet Date: Thu, 17 Feb 2022 07:25:12 -0800 Message-ID: Subject: Re: [PATCH 2/9] lib/ref_tracker: compact stacktraces before printing To: Andrzej Hajda Cc: LKML , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, netdev , Jani Nikula , Daniel Vetter , Lucas De Marchi , Chris Wilson , Dmitry Vyukov , Jakub Kicinski Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 17, 2022 at 7:23 AM Eric Dumazet wrote: > Then, iterating the list and update the array (that you can keep > sorted by ->stack_handle) The 'sorted' part might be unnecessary, if all callers keep @display_limits small enough. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 031D3C433EF for ; Fri, 18 Feb 2022 11:29:26 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2F06210EC4B; Fri, 18 Feb 2022 11:29:22 +0000 (UTC) Received: from mail-yb1-xb2b.google.com (mail-yb1-xb2b.google.com [IPv6:2607:f8b0:4864:20::b2b]) by gabe.freedesktop.org (Postfix) with ESMTPS id B8BCD10ED10 for ; Thu, 17 Feb 2022 15:25:24 +0000 (UTC) Received: by mail-yb1-xb2b.google.com with SMTP id p5so13664183ybd.13 for ; Thu, 17 Feb 2022 07:25:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=MQP46pb+DPsuzuoL3BGGcclWodDFs0G/3Es7HjdxUCo=; b=cMfVnVTpouxlUm+jaYnytrgpG4TUi9DLUb+yI8qFyskWkAnXv+M6au1/maKPGNtmO8 GcaWRklihf6L8yh393NfKIPLun4OQl9mYY1jRZzl8G0dxaxR37h911mKIPqAbIPKz/v+ 6NHpGj21rf8gWajcLnxmDL3+gi1yzfX/0r5GsyQNm0G3ZDxFDCyEhP0ciU9iVcvUP+7O O/wtUSIJGcfT+Ts4VAKp3Aryl+D1ZEsXMiVhErXbkzytbGDcWRcL5hG4Z9uexhoyPRc9 FH+/+Hlyt8N+opqaLI0HBwUBgEOZ3cX4lZaeTqsxqLys+lkPUrmtmR1F+dIq1tL4rZGb Yk0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=MQP46pb+DPsuzuoL3BGGcclWodDFs0G/3Es7HjdxUCo=; b=U72DGkmswCqAN/6jeWvSuzFaB9eBr4BrxV3jQRKJ4kNZpMm3YtZo+eCf27C3HmcLCx yV2AosIhzvHgFO+ja1qN4wtqK3+ajHR+ZvOnDVPIoMfLHRKHVmKqXGG1LRLn7hGeWYqS D0bW3BWGStrdDpi6rm2PWacR7MHQRdR+FApyFUbs89Y0mm6O4cNlYfTC4RxBiXtBZiFh TI+yB/maJE4TCwkMzTrRLo7aezeoN1U0Z/PseybG6I1hdVR13rqB38McXO7reJ+Q7HVt X5IYVEXqCXQ+mZT09zPsslDT9qb/Op7rcP2uGPHWngJ20A1AmTEH8RuUI1SaJw3p9wuA vwjg== X-Gm-Message-State: AOAM530F8jkCTuHhoW6YI4BeYD3Pz7l7iaJMsrUWUYCo5447wIOOodp5 +L4cs0tj+vzQAQEGWaMbqJd3HAyFkx9oMlyvmw/1sA== X-Google-Smtp-Source: ABdhPJyRTktloudhS4FEJQohjippofIbUD6G2axzL1w3brFImkJhKhl9UwTpCXgO94Cef378CE+W+AWSzkPuQK6S+cM= X-Received: by 2002:a5b:7c6:0:b0:60b:a0ce:19b with SMTP id t6-20020a5b07c6000000b0060ba0ce019bmr2751275ybq.407.1645111523530; Thu, 17 Feb 2022 07:25:23 -0800 (PST) MIME-Version: 1.0 References: <20220217140441.1218045-1-andrzej.hajda@intel.com> <20220217140441.1218045-3-andrzej.hajda@intel.com> In-Reply-To: From: Eric Dumazet Date: Thu, 17 Feb 2022 07:25:12 -0800 Message-ID: To: Andrzej Hajda Content-Type: text/plain; charset="UTF-8" X-Mailman-Approved-At: Fri, 18 Feb 2022 11:29:20 +0000 Subject: Re: [Intel-gfx] [PATCH 2/9] lib/ref_tracker: compact stacktraces before printing X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Chris Wilson , netdev , intel-gfx@lists.freedesktop.org, Lucas De Marchi , LKML , dri-devel@lists.freedesktop.org, Jakub Kicinski , Dmitry Vyukov Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Thu, Feb 17, 2022 at 7:23 AM Eric Dumazet wrote: > Then, iterating the list and update the array (that you can keep > sorted by ->stack_handle) The 'sorted' part might be unnecessary, if all callers keep @display_limits small enough. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D774CC433EF for ; Sat, 19 Feb 2022 10:02:14 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5F5D510F66A; Sat, 19 Feb 2022 10:01:57 +0000 (UTC) Received: from mail-yb1-xb36.google.com (mail-yb1-xb36.google.com [IPv6:2607:f8b0:4864:20::b36]) by gabe.freedesktop.org (Postfix) with ESMTPS id AA25410ED0E for ; Thu, 17 Feb 2022 15:25:24 +0000 (UTC) Received: by mail-yb1-xb36.google.com with SMTP id j12so13746804ybh.8 for ; Thu, 17 Feb 2022 07:25:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=MQP46pb+DPsuzuoL3BGGcclWodDFs0G/3Es7HjdxUCo=; b=cMfVnVTpouxlUm+jaYnytrgpG4TUi9DLUb+yI8qFyskWkAnXv+M6au1/maKPGNtmO8 GcaWRklihf6L8yh393NfKIPLun4OQl9mYY1jRZzl8G0dxaxR37h911mKIPqAbIPKz/v+ 6NHpGj21rf8gWajcLnxmDL3+gi1yzfX/0r5GsyQNm0G3ZDxFDCyEhP0ciU9iVcvUP+7O O/wtUSIJGcfT+Ts4VAKp3Aryl+D1ZEsXMiVhErXbkzytbGDcWRcL5hG4Z9uexhoyPRc9 FH+/+Hlyt8N+opqaLI0HBwUBgEOZ3cX4lZaeTqsxqLys+lkPUrmtmR1F+dIq1tL4rZGb Yk0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=MQP46pb+DPsuzuoL3BGGcclWodDFs0G/3Es7HjdxUCo=; b=oxYpmG5Ws/8k8WvP2pFhjRZQyKoC3CxNwGdrTowY7LdsurwW15DThJuT6Y0DQJ1S5s Xu+XMof+9XJ0/QzCVNmIwhxrmBI3AORJODLu64agEKyCr/ukc/ZA9QWJspxISxg1I1Qt XJyssaGIUvyqt+hQq0W+vKMmdbQqDbyC4Gmqn4YBqMj7wi18BW0oPpup2qtutVoN/+DC FNXcaTwIZ3RA4gBYVCX6yrHwwSXx6+2mKuitZhQgbPAWj60neSDuDfM0XTXqXLvNMC49 +QcltupyJTMitmenM8b9pg+ZxvKhngZ+0yeawGHSg8WRJiR4EimkM02YgFSB8nHj9bLS pRuw== X-Gm-Message-State: AOAM532ZcCSsBaqaPB7tWB4Yo326LcUFq/GHayJ6ySWhrEtkHbqdcHfD H0SkWRT3G9AZCebL4IUAs5Vwv7CD/p4QELUOFmXUGA== X-Google-Smtp-Source: ABdhPJyRTktloudhS4FEJQohjippofIbUD6G2axzL1w3brFImkJhKhl9UwTpCXgO94Cef378CE+W+AWSzkPuQK6S+cM= X-Received: by 2002:a5b:7c6:0:b0:60b:a0ce:19b with SMTP id t6-20020a5b07c6000000b0060ba0ce019bmr2751275ybq.407.1645111523530; Thu, 17 Feb 2022 07:25:23 -0800 (PST) MIME-Version: 1.0 References: <20220217140441.1218045-1-andrzej.hajda@intel.com> <20220217140441.1218045-3-andrzej.hajda@intel.com> In-Reply-To: From: Eric Dumazet Date: Thu, 17 Feb 2022 07:25:12 -0800 Message-ID: Subject: Re: [PATCH 2/9] lib/ref_tracker: compact stacktraces before printing To: Andrzej Hajda Content-Type: text/plain; charset="UTF-8" X-Mailman-Approved-At: Sat, 19 Feb 2022 10:01:55 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Chris Wilson , netdev , intel-gfx@lists.freedesktop.org, Lucas De Marchi , LKML , dri-devel@lists.freedesktop.org, Jakub Kicinski , Dmitry Vyukov Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, Feb 17, 2022 at 7:23 AM Eric Dumazet wrote: > Then, iterating the list and update the array (that you can keep > sorted by ->stack_handle) The 'sorted' part might be unnecessary, if all callers keep @display_limits small enough.