From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Dumazet Subject: Re: [PATCH net-next] mlx4: Better use of order-0 pages in RX path Date: Mon, 13 Mar 2017 16:28:04 -0700 Message-ID: References: <20170313005848.7076-1-edumazet@google.com> <20170313173432.GA31333@ast-mbp.thefacebook.com> <20170313183121.GA36306@ast-mbp.thefacebook.com> <20170313202300.GA52396@ast-mbp.thefacebook.com> <20170313232137.GA77943@ast-mbp.thefacebook.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Cc: "David S . Miller" , netdev , Tariq Toukan , Saeed Mahameed , Willem de Bruijn , Alexei Starovoitov , Eric Dumazet , Alexander Duyck To: Alexei Starovoitov Return-path: Received: from mail-it0-f48.google.com ([209.85.214.48]:38573 "EHLO mail-it0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751486AbdCMX2G (ORCPT ); Mon, 13 Mar 2017 19:28:06 -0400 Received: by mail-it0-f48.google.com with SMTP id m27so41698566iti.1 for ; Mon, 13 Mar 2017 16:28:05 -0700 (PDT) In-Reply-To: <20170313232137.GA77943@ast-mbp.thefacebook.com> Sender: netdev-owner@vger.kernel.org List-ID: On Mon, Mar 13, 2017 at 4:21 PM, Alexei Starovoitov wrote: > > is it once in the beginning only? If so then why that > 'if (!ring->page_cache.index)' check is done for every packet? You did not really read the patch, otherwise you would not ask these questions. Test it, and if you find a regression, shout loudly.