From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6F37C433F5 for ; Fri, 18 Feb 2022 13:05:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235721AbiBRNGC (ORCPT ); Fri, 18 Feb 2022 08:06:02 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:47842 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235645AbiBRNFy (ORCPT ); Fri, 18 Feb 2022 08:05:54 -0500 Received: from mail-yw1-x1135.google.com (mail-yw1-x1135.google.com [IPv6:2607:f8b0:4864:20::1135]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AEA252B4622 for ; Fri, 18 Feb 2022 05:05:37 -0800 (PST) Received: by mail-yw1-x1135.google.com with SMTP id 00721157ae682-2d641c31776so65579067b3.12 for ; Fri, 18 Feb 2022 05:05:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=93CVqQreNey4UxGTD3l51x3Bbik2BD7CmQHLf6XaIHw=; b=SehDqi+GFuUda/fggyakKXC3GucwEVDzfyQ+XB9SegLzhnRdrEK7aOvlk06jwkzCsS aNaSLYT+u+8pGDTa6UjxHl1z8UdBLaj0G/HWoaslLDhTyhLJg9cGPFP+Y6it77yj34pM tFCzlWkyBqHljmskcdiiY81P7bZ5VzAUc2D5oDJkUhlSsNIDaEDZqmc6HVSKvgvsGWwa nEx03mCYzfg4NNLI/TK2UKoqYUJ/BWOdpZ4uoww3tVdfX3l5hbuamJYD5Ic9lKdNcPPA 6yHpMj89muImtCYlQ/NSY24a+GuI562an7j8znatM/94Eb4hg1AvJQIlfSgm/3qAqJid zvvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=93CVqQreNey4UxGTD3l51x3Bbik2BD7CmQHLf6XaIHw=; b=Odiighs1ZwS5CuMi7SDn0qXAFKx/Pcxg61kWHvqu0F2O44fLPZJLXFpASqYUHnSo7+ VtYfZFZRMDhfl5f86eeNenhmOyNDuf/zbbfxwkbLWS+PnIg3lt1VY50t4FhkHU2PQ2Ug CToDgVAsL3FsZPeO7EHzb/NERXHhP/iNasRtdBGDVVehR6Lah7R8hDUGdGH2HJ8IUFlT WxIYxSSJQXmSOpzhDzhWXtuUj9EeCqzLz48374zmr3AbZc2xvsSK0oGz6SdSiP55wy5c LEltGuzEj6aNEGdexcCUcr8oy/6Btngu6e3RAW+v5Xct2d5c7juxSTVKDKzz0YgxTNjo XZJQ== X-Gm-Message-State: AOAM530TUN9bT6vsHUEI3e65iTkIROZr1zDp/Jh6uUceXsVn06RCU0Ax C2AY00At7AeAqGFz0o1D47yD6zaJ+rmPV4mWq4pdzw== X-Google-Smtp-Source: ABdhPJzQYHdum9Us26v+wAaJ5eNXNrTZvi6ppwsd2WRgDYD9Vt2zVCDpVIbdO7xcL4XMVutgalQNlOxbsGcJqi6X7k0= X-Received: by 2002:a81:1516:0:b0:2d0:e7ca:2a5 with SMTP id 22-20020a811516000000b002d0e7ca02a5mr7291377ywv.55.1645189536473; Fri, 18 Feb 2022 05:05:36 -0800 (PST) MIME-Version: 1.0 References: <20220217140441.1218045-1-andrzej.hajda@intel.com> <20220217140441.1218045-6-andrzej.hajda@intel.com> <8f6fb098-d0d9-910e-7d42-9fbc541f9891@intel.com> In-Reply-To: <8f6fb098-d0d9-910e-7d42-9fbc541f9891@intel.com> From: Eric Dumazet Date: Fri, 18 Feb 2022 05:05:25 -0800 Message-ID: Subject: Re: [PATCH 5/9] lib/ref_tracker: improve allocation flags To: Andrzej Hajda Cc: LKML , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, netdev , Jani Nikula , Daniel Vetter , Lucas De Marchi , Chris Wilson , Dmitry Vyukov , Jakub Kicinski Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 18, 2022 at 2:28 AM Andrzej Hajda wrote: > > git log --oneline 5740d0689096..4d449bdc5b26 --no-merges -- lib/ref_tracker.c > > c2d1e3df4af59261777b39c2e47476acd4d1cbeb ref_tracker: remove > > filter_irq_stacks() call > > 8fd5522f44dcd7f05454ddc4f16d0f821b676cd9 ref_tracker: add a count of > > untracked references > > e3ececfe668facd87d920b608349a32607060e66 ref_tracker: implement > > use-after-free detection > > > So I will cherry-pick these patches into next version of patchset, with > "NO MERGE" annotation (to allow testing), and if my ref_track patches > will be accepted then they can go via net-dev tree and intel patches > will wait till update of drm-tip. > Is this scenario OK? One possibility would be to split your patch series in two, to merge the ref_tracker changes directly in net-next asap. But I have no strong opinion, maybe Jakub/David have some guidance. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 28DC1C43217 for ; Sat, 19 Feb 2022 10:02:26 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id F0B6710F672; Sat, 19 Feb 2022 10:02:13 +0000 (UTC) Received: from mail-yw1-x1133.google.com (mail-yw1-x1133.google.com [IPv6:2607:f8b0:4864:20::1133]) by gabe.freedesktop.org (Postfix) with ESMTPS id AD0D510EBF6 for ; Fri, 18 Feb 2022 13:05:37 +0000 (UTC) Received: by mail-yw1-x1133.google.com with SMTP id 00721157ae682-2d6923bca1aso56637697b3.9 for ; Fri, 18 Feb 2022 05:05:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=93CVqQreNey4UxGTD3l51x3Bbik2BD7CmQHLf6XaIHw=; b=SehDqi+GFuUda/fggyakKXC3GucwEVDzfyQ+XB9SegLzhnRdrEK7aOvlk06jwkzCsS aNaSLYT+u+8pGDTa6UjxHl1z8UdBLaj0G/HWoaslLDhTyhLJg9cGPFP+Y6it77yj34pM tFCzlWkyBqHljmskcdiiY81P7bZ5VzAUc2D5oDJkUhlSsNIDaEDZqmc6HVSKvgvsGWwa nEx03mCYzfg4NNLI/TK2UKoqYUJ/BWOdpZ4uoww3tVdfX3l5hbuamJYD5Ic9lKdNcPPA 6yHpMj89muImtCYlQ/NSY24a+GuI562an7j8znatM/94Eb4hg1AvJQIlfSgm/3qAqJid zvvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=93CVqQreNey4UxGTD3l51x3Bbik2BD7CmQHLf6XaIHw=; b=d5srnsNJGj9roRh7S3w2HrXNO1qlvwf2FsZWjCmoV6qUsB9GttBVbfr5Z2drHu1iL2 5UdTCERker56Na82S+eOEtJwECT1XLoLphuhErLL92bN3bUZOwxsgXhGbiHqM0bfASrx h4dvOf/iJ5KJVRMfaBpkbR/Sd3uFPxwvqWex6Sj7bBIwR8kRNbuazL8VlIZeBKIWRUk/ bld/6Odq/k/2PSLcbhFhG+FbFuoB81n2q2bDvea9MR+WVU/0t+gP8b3dicLumYJB0+T5 hLh0S5y4VOVk1gxy7ZKF2Bv6/QiLnsn7QvikWwbo/D3uiCJ2P5JyLmVTEN9hWMjtAp44 +aoQ== X-Gm-Message-State: AOAM531ZVMbGDS+krgpix3U9HCetyFVr2d9udiDTnk0BnEmmXjpXdA1Z xEAUPJjjhQKYNanMv2A/34DRi8WQW3auEK4UUrliP6yCjr0qm/L1 X-Google-Smtp-Source: ABdhPJzQYHdum9Us26v+wAaJ5eNXNrTZvi6ppwsd2WRgDYD9Vt2zVCDpVIbdO7xcL4XMVutgalQNlOxbsGcJqi6X7k0= X-Received: by 2002:a81:1516:0:b0:2d0:e7ca:2a5 with SMTP id 22-20020a811516000000b002d0e7ca02a5mr7291377ywv.55.1645189536473; Fri, 18 Feb 2022 05:05:36 -0800 (PST) MIME-Version: 1.0 References: <20220217140441.1218045-1-andrzej.hajda@intel.com> <20220217140441.1218045-6-andrzej.hajda@intel.com> <8f6fb098-d0d9-910e-7d42-9fbc541f9891@intel.com> In-Reply-To: <8f6fb098-d0d9-910e-7d42-9fbc541f9891@intel.com> From: Eric Dumazet Date: Fri, 18 Feb 2022 05:05:25 -0800 Message-ID: Subject: Re: [PATCH 5/9] lib/ref_tracker: improve allocation flags To: Andrzej Hajda Content-Type: text/plain; charset="UTF-8" X-Mailman-Approved-At: Sat, 19 Feb 2022 10:01:55 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Chris Wilson , netdev , intel-gfx@lists.freedesktop.org, Lucas De Marchi , LKML , dri-devel@lists.freedesktop.org, Jakub Kicinski , Dmitry Vyukov Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, Feb 18, 2022 at 2:28 AM Andrzej Hajda wrote: > > git log --oneline 5740d0689096..4d449bdc5b26 --no-merges -- lib/ref_tracker.c > > c2d1e3df4af59261777b39c2e47476acd4d1cbeb ref_tracker: remove > > filter_irq_stacks() call > > 8fd5522f44dcd7f05454ddc4f16d0f821b676cd9 ref_tracker: add a count of > > untracked references > > e3ececfe668facd87d920b608349a32607060e66 ref_tracker: implement > > use-after-free detection > > > So I will cherry-pick these patches into next version of patchset, with > "NO MERGE" annotation (to allow testing), and if my ref_track patches > will be accepted then they can go via net-dev tree and intel patches > will wait till update of drm-tip. > Is this scenario OK? One possibility would be to split your patch series in two, to merge the ref_tracker changes directly in net-next asap. But I have no strong opinion, maybe Jakub/David have some guidance. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9BFACC433EF for ; Tue, 22 Feb 2022 13:32:59 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9B95010E673; Tue, 22 Feb 2022 13:32:57 +0000 (UTC) Received: from mail-yw1-x1132.google.com (mail-yw1-x1132.google.com [IPv6:2607:f8b0:4864:20::1132]) by gabe.freedesktop.org (Postfix) with ESMTPS id C7E4A10EC1C for ; Fri, 18 Feb 2022 13:05:37 +0000 (UTC) Received: by mail-yw1-x1132.google.com with SMTP id 00721157ae682-2d07ae0b1c0so65631777b3.2 for ; Fri, 18 Feb 2022 05:05:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=93CVqQreNey4UxGTD3l51x3Bbik2BD7CmQHLf6XaIHw=; b=SehDqi+GFuUda/fggyakKXC3GucwEVDzfyQ+XB9SegLzhnRdrEK7aOvlk06jwkzCsS aNaSLYT+u+8pGDTa6UjxHl1z8UdBLaj0G/HWoaslLDhTyhLJg9cGPFP+Y6it77yj34pM tFCzlWkyBqHljmskcdiiY81P7bZ5VzAUc2D5oDJkUhlSsNIDaEDZqmc6HVSKvgvsGWwa nEx03mCYzfg4NNLI/TK2UKoqYUJ/BWOdpZ4uoww3tVdfX3l5hbuamJYD5Ic9lKdNcPPA 6yHpMj89muImtCYlQ/NSY24a+GuI562an7j8znatM/94Eb4hg1AvJQIlfSgm/3qAqJid zvvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=93CVqQreNey4UxGTD3l51x3Bbik2BD7CmQHLf6XaIHw=; b=DATjkYZyDRd3hAanLj5Tb8YhInTlKSZv+KAFe6rVDw+Lb1pxlV2uMwQbSEc0XWXl/I ZooGd7xiLPkDiXPUk9WFlj69tGtsrr2pwQCfdqqXtROZHnGkMBGWNLqHbkZiKqAooZ3f cAUXl6Yz2lvS8qtonFgyc8lrcikpSLZqtal83f6tdAcILa971TiHTGFGWBa3ftTSHqef r+1X+EXeTTUeSi6IT0pf+ykqnydsSCrivZmarPeruAKR6ysq1zy9suHDwsZuzx/KWEB7 qTM0loCWfEAgVOmP0YvZtCvJpYyGGel6qv9hC0u4gDR+2ZfBrOo2HQcSdAzBPMHQ8Rt0 A5Wg== X-Gm-Message-State: AOAM532ZcXXfhBgCUZZ182OKbgbOAsLF0ntBzZehopQUlqvGR6Hh727A WbQ0UKkPAszL9fp0tSMW8gUlV3xrveJVRL4TLEbWRw== X-Google-Smtp-Source: ABdhPJzQYHdum9Us26v+wAaJ5eNXNrTZvi6ppwsd2WRgDYD9Vt2zVCDpVIbdO7xcL4XMVutgalQNlOxbsGcJqi6X7k0= X-Received: by 2002:a81:1516:0:b0:2d0:e7ca:2a5 with SMTP id 22-20020a811516000000b002d0e7ca02a5mr7291377ywv.55.1645189536473; Fri, 18 Feb 2022 05:05:36 -0800 (PST) MIME-Version: 1.0 References: <20220217140441.1218045-1-andrzej.hajda@intel.com> <20220217140441.1218045-6-andrzej.hajda@intel.com> <8f6fb098-d0d9-910e-7d42-9fbc541f9891@intel.com> In-Reply-To: <8f6fb098-d0d9-910e-7d42-9fbc541f9891@intel.com> From: Eric Dumazet Date: Fri, 18 Feb 2022 05:05:25 -0800 Message-ID: To: Andrzej Hajda Content-Type: text/plain; charset="UTF-8" X-Mailman-Approved-At: Tue, 22 Feb 2022 13:32:50 +0000 Subject: Re: [Intel-gfx] [PATCH 5/9] lib/ref_tracker: improve allocation flags X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Chris Wilson , netdev , intel-gfx@lists.freedesktop.org, Lucas De Marchi , LKML , dri-devel@lists.freedesktop.org, Jakub Kicinski , Dmitry Vyukov Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Fri, Feb 18, 2022 at 2:28 AM Andrzej Hajda wrote: > > git log --oneline 5740d0689096..4d449bdc5b26 --no-merges -- lib/ref_tracker.c > > c2d1e3df4af59261777b39c2e47476acd4d1cbeb ref_tracker: remove > > filter_irq_stacks() call > > 8fd5522f44dcd7f05454ddc4f16d0f821b676cd9 ref_tracker: add a count of > > untracked references > > e3ececfe668facd87d920b608349a32607060e66 ref_tracker: implement > > use-after-free detection > > > So I will cherry-pick these patches into next version of patchset, with > "NO MERGE" annotation (to allow testing), and if my ref_track patches > will be accepted then they can go via net-dev tree and intel patches > will wait till update of drm-tip. > Is this scenario OK? One possibility would be to split your patch series in two, to merge the ref_tracker changes directly in net-next asap. But I have no strong opinion, maybe Jakub/David have some guidance.