From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 601ACC433F5 for ; Fri, 17 Sep 2021 16:48:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 477CE61108 for ; Fri, 17 Sep 2021 16:48:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240313AbhIQQth (ORCPT ); Fri, 17 Sep 2021 12:49:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40854 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244635AbhIQQtb (ORCPT ); Fri, 17 Sep 2021 12:49:31 -0400 Received: from mail-qk1-x729.google.com (mail-qk1-x729.google.com [IPv6:2607:f8b0:4864:20::729]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A4E44C061764 for ; Fri, 17 Sep 2021 09:48:09 -0700 (PDT) Received: by mail-qk1-x729.google.com with SMTP id bk29so19320702qkb.8 for ; Fri, 17 Sep 2021 09:48:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=wR3Cge17MmW0C/wFwIkuwW0vhWinSIKQL4zslzCVJSM=; b=TOyudvBR6pecijFVuc93gHbV2tInqmXi3fFOhiyk9nAFHgfcdCUf6txaS6yXwW6HUV bjgGfwKhJJj1s6kfMqeskkE8bbGqmCmAbaxT36donNMXIeJK5+J/F1OWXCiGFW9TRGJf vNpNstshLKA/Yo+AnV1PHZH+gDLdnH9DSRLAjtbWf2WFXxG4dQyivSKCelFPBOxUM0OT JQuzgWRfA16AlA7sBF1DXoPPHW3NBVY7b4eKRSPyjGhe4SwkeVY6MuapeFCqsnKSRzAm FrUKGNTnk/ijKT3SJBDf9hvx3YKBeoIhxbq8DUrd/E0yMkjdI4HFGB+UR51qfBJwMVG5 DR7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wR3Cge17MmW0C/wFwIkuwW0vhWinSIKQL4zslzCVJSM=; b=iBOHGhWO+81KX9vcTij1XEZ6d8Z2DDy5KawpbNWbVFBMyCTv7ZHfo7R+NxbgzpaMhx z4a0UDvByPNtW5o5P9Zd8ionrWNJx+4b0YJdXe06lgsMII38AiMgzW6KTyviSftg16RG 6rj33VkMqCGf92VLsACtJeKyYzQ4tlwcj90W3jfOhd06x+uHBJfh7ZlJSaJ7+qkl/pW3 dtJ8WbZbbnZu/9sAvX3acMVuPAwJFOzybatupbl5KQ9scTXPoABiY7fFZD6cDqZtuk4a n7Q24XeztV2VbS0qAtRTHlMb6MfV6wDQ1q+xePb00T2U7uVMKrCIuzzmfV+g+iT7QB2L CAiA== X-Gm-Message-State: AOAM530fHRDB1Z4pM9Bx2z+mu6qB++YtiPpoqt3ESVJIaZqet/Trt5cJ vvtGl2iwtVpNf+3uLO92liON2cSjEbbJAO+SeB6TYw== X-Google-Smtp-Source: ABdhPJx/RMx7Jy1FxwshuCXU4vaskb7Aw4Mde0Qdeag3JDzQ+DzMXYmk4uDor8koAs0zFuRQ4d4o3QjbgAkCsNhpO2M= X-Received: by 2002:a25:47c4:: with SMTP id u187mr15755593yba.225.1631897288414; Fri, 17 Sep 2021 09:48:08 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Eric Dumazet Date: Fri, 17 Sep 2021 09:47:57 -0700 Message-ID: Subject: Re: [RFC PATCH 0/5] net: remove sk skb caches To: Paolo Abeni Cc: netdev , "David S. Miller" , Jakub Kicinski , Mat Martineau , Ayush Sawal , MPTCP Upstream Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Sep 17, 2021 at 8:39 AM Paolo Abeni wrote: > > Eric noted we would be better off reverting the sk > skb caches. > > MPTCP relies on such a feature, so we need a > little refactor of the MPTCP tx path before the mentioned > revert. > > The first patch avoids that the next one will cause a name > clash. The second exposes additional TCP helpers. The 3rd patch > changes the MPTCP code to do locally the whole skb allocation > and updating, so it does not rely anymore on core TCP helpers > for that nor the sk skb cache. > > As a side effect, we can drop the tcp_build_frag helper. > > Finally, we can pull Eric's revert. > > Note that patch 3/5 will conflict with the pending -net fix > for a recently reported syzkaller splat. > Thanks for working on this Paolo ! From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f175.google.com (mail-qk1-f175.google.com [209.85.222.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2B4763FC3 for ; Fri, 17 Sep 2021 16:48:12 +0000 (UTC) Received: by mail-qk1-f175.google.com with SMTP id b64so19433193qkg.0 for ; Fri, 17 Sep 2021 09:48:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=wR3Cge17MmW0C/wFwIkuwW0vhWinSIKQL4zslzCVJSM=; b=TOyudvBR6pecijFVuc93gHbV2tInqmXi3fFOhiyk9nAFHgfcdCUf6txaS6yXwW6HUV bjgGfwKhJJj1s6kfMqeskkE8bbGqmCmAbaxT36donNMXIeJK5+J/F1OWXCiGFW9TRGJf vNpNstshLKA/Yo+AnV1PHZH+gDLdnH9DSRLAjtbWf2WFXxG4dQyivSKCelFPBOxUM0OT JQuzgWRfA16AlA7sBF1DXoPPHW3NBVY7b4eKRSPyjGhe4SwkeVY6MuapeFCqsnKSRzAm FrUKGNTnk/ijKT3SJBDf9hvx3YKBeoIhxbq8DUrd/E0yMkjdI4HFGB+UR51qfBJwMVG5 DR7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wR3Cge17MmW0C/wFwIkuwW0vhWinSIKQL4zslzCVJSM=; b=orN1VQIlumc9CIm4wSG/nGxDdJmaGnWtMkgNRazI7K1g0DdkF67bQGH5RM4S+ngcXE 8mWhWONY5vk9vURs3gbuNLcgKer1j29a+tt57y8H9gWywaXgstIqnxK2nLiYpXJx3ncD 1YffurG3qrgKQn3+4caUdthwZAPAvwxnWtYiznzF1n/UuSU5pKxaLDE3B6gcRaaYIjq/ Jkn7nc2CxW2SKN7FzM2zu26n4a6HuUzox7EGz+lwB+HXfb33hf+qBPejLtDLAZMvjJc4 I1IkM8VQ/e/UPh0yW7EOzbMpdX2XJsxWgVpJVAwdkwPB+oO/vAWx3XLGiwjQhXAYnXwB b+kw== X-Gm-Message-State: AOAM530Fl9T2pBHRIGFkDt3dXcfR1glnmL3biycuymC1Gl5IrCVb6NkU mDbiNY1PIiZ2qAHd4CZMPLgke1kpnYtM457DsOBOYw== X-Google-Smtp-Source: ABdhPJx/RMx7Jy1FxwshuCXU4vaskb7Aw4Mde0Qdeag3JDzQ+DzMXYmk4uDor8koAs0zFuRQ4d4o3QjbgAkCsNhpO2M= X-Received: by 2002:a25:47c4:: with SMTP id u187mr15755593yba.225.1631897288414; Fri, 17 Sep 2021 09:48:08 -0700 (PDT) Precedence: bulk X-Mailing-List: mptcp@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: In-Reply-To: From: Eric Dumazet Date: Fri, 17 Sep 2021 09:47:57 -0700 Message-ID: Subject: Re: [RFC PATCH 0/5] net: remove sk skb caches To: Paolo Abeni Cc: netdev , "David S. Miller" , Jakub Kicinski , Mat Martineau , Ayush Sawal , MPTCP Upstream Content-Type: text/plain; charset="UTF-8" On Fri, Sep 17, 2021 at 8:39 AM Paolo Abeni wrote: > > Eric noted we would be better off reverting the sk > skb caches. > > MPTCP relies on such a feature, so we need a > little refactor of the MPTCP tx path before the mentioned > revert. > > The first patch avoids that the next one will cause a name > clash. The second exposes additional TCP helpers. The 3rd patch > changes the MPTCP code to do locally the whole skb allocation > and updating, so it does not rely anymore on core TCP helpers > for that nor the sk skb cache. > > As a side effect, we can drop the tcp_build_frag helper. > > Finally, we can pull Eric's revert. > > Note that patch 3/5 will conflict with the pending -net fix > for a recently reported syzkaller splat. > Thanks for working on this Paolo !