From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83133C4332E for ; Mon, 23 Mar 2020 18:47:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4F498205ED for ; Mon, 23 Mar 2020 18:47:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="XONA2ALh" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727771AbgCWSra (ORCPT ); Mon, 23 Mar 2020 14:47:30 -0400 Received: from mail-yb1-f195.google.com ([209.85.219.195]:35664 "EHLO mail-yb1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727275AbgCWSra (ORCPT ); Mon, 23 Mar 2020 14:47:30 -0400 Received: by mail-yb1-f195.google.com with SMTP id x63so7692075ybx.2 for ; Mon, 23 Mar 2020 11:47:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Qmii+y/AcNF/3IaoysaoSwbUreiK2GotAvn0cRg6OCo=; b=XONA2ALhlQSOjB4m/OLYG90hyIRbP5OVRK9yqkf5dg3l3UN/GmwUjmmlBELMEnBinR AVRS8uN7cnbpMdhHPC/dIgWWnv0urvibcgcuw32VT2v3GtXVox37tuYVf11F/5AsXR75 HAXWSI+I5O3XeocnR2BCnMOeYCxIb+mydXqoh3bzpCdorYoimgWSKGoHXOngMCO+nDhD sJP/ZhFvYAaE1LlKnkMJU5QOEWis3VZCA9HGRHFExWX5sHvjTzHD/ibaWzBxjcEWA3P4 oaAy6yTljtF6AIHzt6IK+ZD2T1qX3xxZImsftO+hA1DuTkFJE1+WUBSXawTwM4+nKS4E 6t2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Qmii+y/AcNF/3IaoysaoSwbUreiK2GotAvn0cRg6OCo=; b=l3y4vZBW5G1YGUy2h0F9BHMIlNvLBmm+KU0B2+WdINWlntBJnMlgl0PuXVEmv6ti89 zMlS1E3RJJTDOyuLn2rgCOE3peolcpGtrK99CzB3Vbdqbv/XTy7jF3F4RRFsQ7YK+l2K K3rzXTY7iGd4vhVJGN7rFhS6J5Xw4EWRT50KGxfgcEUJABk9bHQOwaesDmZbm/2qHK1f fFHRm/gK2grMqh/6YGuV9SE6mHy29UHf4HapoutFshbGGWx6Nel50iwCE/JzXbsTm0lf 1QLtwAmg2C4p5Iol5TuceczzDGNp0ipRxDW91SNVaSm5V+pGGoARAnc/FLxNQOA4ipUM 96EA== X-Gm-Message-State: ANhLgQ0kyN3UC9y4y92NhfByFr7Ju9hSe5T5l8hSWG6Olprnji7+PFQr 96f1Txl5AF4/+sjA7eoWSU3L9R5jTZn5XfnugvfGaw== X-Google-Smtp-Source: ADFU+vtav6o/bnihXn2iB8YftH+/bmoXqpYdTtOQ4OeJHLeaMCZEmjlm8VxvL+9kjDSOTxO20pi5Nzxesf03O67paTY= X-Received: by 2002:a25:c206:: with SMTP id s6mr37781574ybf.101.1584989248967; Mon, 23 Mar 2020 11:47:28 -0700 (PDT) MIME-Version: 1.0 References: <20200323181814.87661-1-kuniyu@amazon.co.jp> <20200323181814.87661-3-kuniyu@amazon.co.jp> In-Reply-To: <20200323181814.87661-3-kuniyu@amazon.co.jp> From: Eric Dumazet Date: Mon, 23 Mar 2020 11:47:17 -0700 Message-ID: Subject: Re: [PATCH net-next 2/2] tcp/dccp: Remove unnecessary initialization of refcounted. To: Kuniyuki Iwashima Cc: "David S . Miller" , Jakub Kicinski , Gerrit Renker , Alexey Kuznetsov , Hideaki YOSHIFUJI , dccp@vger.kernel.org, netdev , Kuniyuki Iwashima , osa-contribution-log@amazon.com Content-Type: text/plain; charset="UTF-8" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Mar 23, 2020 at 11:22 AM Kuniyuki Iwashima wrote: > > When we get a TCP_NEW_SYN_RECV/DCCP_NEW_SYN_RECV socket by > __inet_lookup_skb(), refcounted is already set true, so it is not > necessary to do it again. This changelog is absolutely not accurate. sk is a listener here. (because sk was set to req->rsk_listener;) Please do not add confusion by mixing different things. I prefer not relying on the old value of 'refcounted', since we switched sk value. Note that we call reqsk_put(req); regardless of 'refcounted' I would rather not change this code and make future backports more complicated. Thanks. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Dumazet Date: Mon, 23 Mar 2020 18:47:17 +0000 Subject: Re: [PATCH net-next 2/2] tcp/dccp: Remove unnecessary initialization of refcounted. Message-Id: List-Id: References: <20200323181814.87661-3-kuniyu@amazon.co.jp> In-Reply-To: <20200323181814.87661-3-kuniyu@amazon.co.jp> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: dccp@vger.kernel.org On Mon, Mar 23, 2020 at 11:22 AM Kuniyuki Iwashima wrote: > > When we get a TCP_NEW_SYN_RECV/DCCP_NEW_SYN_RECV socket by > __inet_lookup_skb(), refcounted is already set true, so it is not > necessary to do it again. This changelog is absolutely not accurate. sk is a listener here. (because sk was set to req->rsk_listener;) Please do not add confusion by mixing different things. I prefer not relying on the old value of 'refcounted', since we switched sk value. Note that we call reqsk_put(req); regardless of 'refcounted' I would rather not change this code and make future backports more complicated. Thanks.