From: Eric Dumazet <edumazet@google.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Eric Dumazet <eric.dumazet@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>,
syzbot <syzkaller@googlegroups.com>,
Talal Ahmad <talalahmad@google.com>,
Arjun Roy <arjunroy@google.com>,
Willem de Bruijn <willemb@google.com>,
Soheil Hassas Yeganeh <soheil@google.com>
Subject: Re: [PATCH net] tcp: take care of mixed splice()/sendmsg(MSG_ZEROCOPY) case
Date: Fri, 4 Feb 2022 20:20:43 -0800 [thread overview]
Message-ID: <CANn89iLpPA4c6RLWZpONXP0rrjMn__T7_yN=qsBFE8L5VwyMyg@mail.gmail.com> (raw)
In-Reply-To: <20220204200648.496c7963@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On Fri, Feb 4, 2022 at 8:06 PM Jakub Kicinski <kuba@kernel.org> wrote:
>
> On Thu, 3 Feb 2022 14:55:47 -0800 Eric Dumazet wrote:
> > + if (!sk_wmem_schedule(sk, extra))
> > + return ENOMEM;
>
> Let me make this negative when applying, looks like an inconsequential
> typo with current callers.
Agreed, at first I was returning 0/1, and changed the 1 to ENOMEM at
the last moment.
Thanks !
next prev parent reply other threads:[~2022-02-05 4:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-03 22:55 [PATCH net] tcp: take care of mixed splice()/sendmsg(MSG_ZEROCOPY) case Eric Dumazet
2022-02-04 14:39 ` Soheil Hassas Yeganeh
2022-02-05 4:06 ` Jakub Kicinski
2022-02-05 4:20 ` Eric Dumazet [this message]
2022-02-05 4:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANn89iLpPA4c6RLWZpONXP0rrjMn__T7_yN=qsBFE8L5VwyMyg@mail.gmail.com' \
--to=edumazet@google.com \
--cc=arjunroy@google.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=soheil@google.com \
--cc=syzkaller@googlegroups.com \
--cc=talalahmad@google.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.