From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B09E0C433F5 for ; Thu, 23 Sep 2021 07:05:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 87DDD61164 for ; Thu, 23 Sep 2021 07:05:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239358AbhIWHH1 (ORCPT ); Thu, 23 Sep 2021 03:07:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57738 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239550AbhIWHH1 (ORCPT ); Thu, 23 Sep 2021 03:07:27 -0400 Received: from mail-oi1-x231.google.com (mail-oi1-x231.google.com [IPv6:2607:f8b0:4864:20::231]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 85EDAC061574 for ; Thu, 23 Sep 2021 00:05:56 -0700 (PDT) Received: by mail-oi1-x231.google.com with SMTP id w19so8334173oik.10 for ; Thu, 23 Sep 2021 00:05:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=stapelberg.ch; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=IthV7tE5yfFcxnSKvKQkyd8eIFf4X2+/XnbxnjKj63A=; b=Ti5PxVpEJ43IsCs3soMxypjPHP8YvDGzovtrxlfJoqYfMSobbR/y5JdJukiM/KKvXX J07UmFZMjmOIc2MzXUWdBI52WJGqwrBxeoTPxsM3Vk6hc3jn7qZWrkHl2Xs8vzzFbMh5 8uE00Z0RLEQWMuRC1x+V3/QIJcoSpe0g2cTvvsyIZYC2EMgJ/pwIT2u5iD3ZF1N8f6DH quIfq69aE1jXpKsnt7NJU7RV78k7UJXTfBsf8hNnCHj6jArP4Sdei971mmMjPpLqUCCS orlLyN0v3pFuxPTqQi2sjvw32m+5LArmmeyR5MmweQADTFHBVh0EqfJLwrVJSVIeQFqN 9HCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=IthV7tE5yfFcxnSKvKQkyd8eIFf4X2+/XnbxnjKj63A=; b=KBNwQ/5PGxT9OjfaogTKHIZnAW9oFP3MbQiQNdWETcFNhOISHLjNO6GViLY9x4ak6N GFDNp/YekTENBbkmgXkEWvfUvl3Iz9T6HCqbHq8hy/UI2shs2yeMS0atoIzlm03DHEkf +FfmU40BWanBK+zgkiVNS6s42irzDD+ACyhbMmgOQUQh9nYtocSANg8BWCg9zXJG62Oe 8aqm5HOhX1GO1YdEMVnV9uIKjk7jSUXzXdpRB0qzYKc13e9MyHndXeGbRi2uMBute+b0 EUGAMqixTwhZG96Bjst6SVFOrxATT/H1euWSGFgH5Xj6mflrvTJTVgl/nEDSn13U+mU2 3CqA== X-Gm-Message-State: AOAM5304lUm2RrWt6ldFqhc8k5Qv2wYVEO9zfBcoNXes7AICbEsqU9g1 0UY87fsc5K95grxQ/fA6pwE4one2SAxePOPBIAtArw== X-Google-Smtp-Source: ABdhPJziUkXCfKg1abMsQJVrmNpsTMA3+ywisLcmJYhVcH4rGHtvpHWAEag5v5Tq1ibv0luPVijjEvBObRJ/fojrVgw= X-Received: by 2002:aca:ab51:: with SMTP id u78mr11733036oie.177.1632380755894; Thu, 23 Sep 2021 00:05:55 -0700 (PDT) MIME-Version: 1.0 References: <20210922125419.4125779-1-maxime@cerno.tech> In-Reply-To: From: Michael Stapelberg Date: Thu, 23 Sep 2021 09:05:40 +0200 Message-ID: Subject: Re: [PATCH 0/5] drm/vc4: hdmi: Remove CPU hangs, take 2 To: Maxime Ripard Cc: Maarten Lankhorst , Thomas Zimmermann , Daniel Vetter , David Airlie , linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, Mike Turquette , Stephen Boyd , Nicolas Saenz Julienne , Florian Fainelli , Linus Torvalds Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org I can confirm that this patch series (applied to linux commit 58e2cf5d794616b84f591d4d1276c8953278ce24) works for me =E2=80=94 my Raspber= ry Pi 3 still boots fine (without HDMI connected). Thanks! On Wed, 22 Sept 2021 at 23:18, Michael Stapelberg w= rote: > > > On Wed, 22 Sept 2021 at 14:54, Maxime Ripard wrote: >> >> Hi, >> >> Here's another attempt at fixing the complete CPU stall while retrieving= the >> HDMI connector status when the connector is disabled. >> >> This was fixed already, but eventually got reverted by Linus due to the = same >> symptom happening in another situation. This was likely (but not confirm= ed by >> the reporter) due to the kernel being booted without an HDMI display con= nected, >> in which case the firmware won't initialise the HDMI State Machine clock= . > > > Sorry for the lack of confirmation: yes, this problem was encountered whe= n no HDMI display was connected. > > I=E2=80=99ll try testing your patch series tomorrow. > > Thanks for taking care of this! > >> >> >> This is fixed by patch 3. However, further changes in the clock drivers = were >> needed for clk_set_min_rate to be used, which are patches 1 and 2. >> >> Finally, patches 4 and 5 are the original patches that were reverted. Pa= tch 4 >> got a small modification to move the clk_set_min_rate() call before the = HSM >> clock is enabled. >> >> Let me know what you think, >> Maxime >> >> Maxime Ripard (5): >> clk: bcm-2835: Pick the closest clock rate >> clk: bcm-2835: Remove rounding up the dividers >> drm/vc4: hdmi: Set a default HSM rate >> drm/vc4: hdmi: Move the HSM clock enable to runtime_pm >> drm/vc4: hdmi: Make sure the controller is powered in detect >> >> drivers/clk/bcm/clk-bcm2835.c | 13 ++--- >> drivers/gpu/drm/vc4/vc4_hdmi.c | 90 ++++++++++++++++++++++++---------- >> 2 files changed, 68 insertions(+), 35 deletions(-) >> >> -- >> 2.31.1 >> > > > -- > Best regards, > Michael --=20 Best regards, Michael From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8048C433EF for ; Thu, 23 Sep 2021 07:08:23 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AC17D60F56 for ; Thu, 23 Sep 2021 07:08:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org AC17D60F56 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=stapelberg.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+XmVV1V9HEGV/uKFGhshCb3O6jVcrll1KR+4Mr4LSIc=; b=yv6N1vZX5UPzn2 nxc5xnZ5oiH0buKrOajw/LzdQ06gxYvuEG3OLKBP8XEi9kbVtYRBmdLo+u7CMvLq/pNHTb6DJMTLg 7TIcaab23uVY9oq3WYJD+bfa7I0gpSLbDS+HKEDqVRoaaLPrZd0ttEwVbuyygwNCKdT8bomCNih9m w2BqLaY2nb/3/hqhueJFaHqQuvwNAXeisxgTmqAMNXzkxVIpMWnhZCDA0L6SwNrJo0xEXIv3iM8jb jBBcw0oC+LNkUJd82vipKV24sFKAv+j6jYKFPOnM4L6rOzBAZjMWmyWgAMxgcNwkLok2pQiHuVJAE kGj6dT2RcEniPt6yNB9w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mTIo2-00ATyE-Eo; Thu, 23 Sep 2021 07:06:06 +0000 Received: from mail-oi1-x232.google.com ([2607:f8b0:4864:20::232]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mTIns-00ATwh-Vo for linux-arm-kernel@lists.infradead.org; Thu, 23 Sep 2021 07:05:58 +0000 Received: by mail-oi1-x232.google.com with SMTP id o66so8314370oib.11 for ; Thu, 23 Sep 2021 00:05:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=stapelberg.ch; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=IthV7tE5yfFcxnSKvKQkyd8eIFf4X2+/XnbxnjKj63A=; b=Ti5PxVpEJ43IsCs3soMxypjPHP8YvDGzovtrxlfJoqYfMSobbR/y5JdJukiM/KKvXX J07UmFZMjmOIc2MzXUWdBI52WJGqwrBxeoTPxsM3Vk6hc3jn7qZWrkHl2Xs8vzzFbMh5 8uE00Z0RLEQWMuRC1x+V3/QIJcoSpe0g2cTvvsyIZYC2EMgJ/pwIT2u5iD3ZF1N8f6DH quIfq69aE1jXpKsnt7NJU7RV78k7UJXTfBsf8hNnCHj6jArP4Sdei971mmMjPpLqUCCS orlLyN0v3pFuxPTqQi2sjvw32m+5LArmmeyR5MmweQADTFHBVh0EqfJLwrVJSVIeQFqN 9HCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=IthV7tE5yfFcxnSKvKQkyd8eIFf4X2+/XnbxnjKj63A=; b=wbRKz2rY3eBVCRe8NazCnAzg2Tug7TGTHUqfZH5Alrx98MxM3imMu7NbO/+smPG97S 4Hhy2a4o4ZsvR4PWYcmAOMrBHQ+EMToqxi+mVnE8HtRnkZ9EY2sw1Xthsd2RfPWmAlaV R1Z/fPPMiJh2B35u5cmhDcPzigcKoUG1raWsrXezBUmpqat0UGi11JgUstnAG/J2dlVA 9LTSUrqkoxqBU/nvZKHbeZsppKAiJpOombfKcTSixz1aVril1Ng5c0V/jqPnKGau2UEV mfZy43n0eUCnynnnn3y/y/7WiYZmLZlGyOnYoTLLVIpKMsWBrebadY9UJ+hSMUAWUAdO EcsQ== X-Gm-Message-State: AOAM5327er2bI1E7usVCyqbwX4+agHAAvqvYJubKAPF2PXvTrfJzG+Nn Hj6G+Pg1nzonbXOf6LdnRyaTHgyydkKjrt36ccSFtw== X-Google-Smtp-Source: ABdhPJziUkXCfKg1abMsQJVrmNpsTMA3+ywisLcmJYhVcH4rGHtvpHWAEag5v5Tq1ibv0luPVijjEvBObRJ/fojrVgw= X-Received: by 2002:aca:ab51:: with SMTP id u78mr11733036oie.177.1632380755894; Thu, 23 Sep 2021 00:05:55 -0700 (PDT) MIME-Version: 1.0 References: <20210922125419.4125779-1-maxime@cerno.tech> In-Reply-To: From: Michael Stapelberg Date: Thu, 23 Sep 2021 09:05:40 +0200 Message-ID: Subject: Re: [PATCH 0/5] drm/vc4: hdmi: Remove CPU hangs, take 2 To: Maxime Ripard Cc: Maarten Lankhorst , Thomas Zimmermann , Daniel Vetter , David Airlie , linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, Mike Turquette , Stephen Boyd , Nicolas Saenz Julienne , Florian Fainelli , Linus Torvalds X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210923_000557_155107_1D5DADDE X-CRM114-Status: GOOD ( 21.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SSBjYW4gY29uZmlybSB0aGF0IHRoaXMgcGF0Y2ggc2VyaWVzIChhcHBsaWVkIHRvIGxpbnV4IGNv bW1pdAo1OGUyY2Y1ZDc5NDYxNmI4NGY1OTFkNGQxMjc2Yzg5NTMyNzhjZTI0KSB3b3JrcyBmb3Ig bWUg4oCUIG15IFJhc3BiZXJyeQpQaSAzIHN0aWxsIGJvb3RzIGZpbmUgKHdpdGhvdXQgSERNSSBj b25uZWN0ZWQpLgoKVGhhbmtzIQoKCk9uIFdlZCwgMjIgU2VwdCAyMDIxIGF0IDIzOjE4LCBNaWNo YWVsIFN0YXBlbGJlcmcgPG1pY2hhZWxAc3RhcGVsYmVyZy5jaD4gd3JvdGU6Cj4KPgo+IE9uIFdl ZCwgMjIgU2VwdCAyMDIxIGF0IDE0OjU0LCBNYXhpbWUgUmlwYXJkIDxtYXhpbWVAY2Vybm8udGVj aD4gd3JvdGU6Cj4+Cj4+IEhpLAo+Pgo+PiBIZXJlJ3MgYW5vdGhlciBhdHRlbXB0IGF0IGZpeGlu ZyB0aGUgY29tcGxldGUgQ1BVIHN0YWxsIHdoaWxlIHJldHJpZXZpbmcgdGhlCj4+IEhETUkgY29u bmVjdG9yIHN0YXR1cyB3aGVuIHRoZSBjb25uZWN0b3IgaXMgZGlzYWJsZWQuCj4+Cj4+IFRoaXMg d2FzIGZpeGVkIGFscmVhZHksIGJ1dCBldmVudHVhbGx5IGdvdCByZXZlcnRlZCBieSBMaW51cyBk dWUgdG8gdGhlIHNhbWUKPj4gc3ltcHRvbSBoYXBwZW5pbmcgaW4gYW5vdGhlciBzaXR1YXRpb24u IFRoaXMgd2FzIGxpa2VseSAoYnV0IG5vdCBjb25maXJtZWQgYnkKPj4gdGhlIHJlcG9ydGVyKSBk dWUgdG8gdGhlIGtlcm5lbCBiZWluZyBib290ZWQgd2l0aG91dCBhbiBIRE1JIGRpc3BsYXkgY29u bmVjdGVkLAo+PiBpbiB3aGljaCBjYXNlIHRoZSBmaXJtd2FyZSB3b24ndCBpbml0aWFsaXNlIHRo ZSBIRE1JIFN0YXRlIE1hY2hpbmUgY2xvY2suCj4KPgo+IFNvcnJ5IGZvciB0aGUgbGFjayBvZiBj b25maXJtYXRpb246IHllcywgdGhpcyBwcm9ibGVtIHdhcyBlbmNvdW50ZXJlZCB3aGVuIG5vIEhE TUkgZGlzcGxheSB3YXMgY29ubmVjdGVkLgo+Cj4gSeKAmWxsIHRyeSB0ZXN0aW5nIHlvdXIgcGF0 Y2ggc2VyaWVzIHRvbW9ycm93Lgo+Cj4gVGhhbmtzIGZvciB0YWtpbmcgY2FyZSBvZiB0aGlzIQo+ Cj4+Cj4+Cj4+IFRoaXMgaXMgZml4ZWQgYnkgcGF0Y2ggMy4gSG93ZXZlciwgZnVydGhlciBjaGFu Z2VzIGluIHRoZSBjbG9jayBkcml2ZXJzIHdlcmUKPj4gbmVlZGVkIGZvciBjbGtfc2V0X21pbl9y YXRlIHRvIGJlIHVzZWQsIHdoaWNoIGFyZSBwYXRjaGVzIDEgYW5kIDIuCj4+Cj4+IEZpbmFsbHks IHBhdGNoZXMgNCBhbmQgNSBhcmUgdGhlIG9yaWdpbmFsIHBhdGNoZXMgdGhhdCB3ZXJlIHJldmVy dGVkLiBQYXRjaCA0Cj4+IGdvdCBhIHNtYWxsIG1vZGlmaWNhdGlvbiB0byBtb3ZlIHRoZSBjbGtf c2V0X21pbl9yYXRlKCkgY2FsbCBiZWZvcmUgdGhlIEhTTQo+PiBjbG9jayBpcyBlbmFibGVkLgo+ Pgo+PiBMZXQgbWUga25vdyB3aGF0IHlvdSB0aGluaywKPj4gTWF4aW1lCj4+Cj4+IE1heGltZSBS aXBhcmQgKDUpOgo+PiAgIGNsazogYmNtLTI4MzU6IFBpY2sgdGhlIGNsb3Nlc3QgY2xvY2sgcmF0 ZQo+PiAgIGNsazogYmNtLTI4MzU6IFJlbW92ZSByb3VuZGluZyB1cCB0aGUgZGl2aWRlcnMKPj4g ICBkcm0vdmM0OiBoZG1pOiBTZXQgYSBkZWZhdWx0IEhTTSByYXRlCj4+ICAgZHJtL3ZjNDogaGRt aTogTW92ZSB0aGUgSFNNIGNsb2NrIGVuYWJsZSB0byBydW50aW1lX3BtCj4+ICAgZHJtL3ZjNDog aGRtaTogTWFrZSBzdXJlIHRoZSBjb250cm9sbGVyIGlzIHBvd2VyZWQgaW4gZGV0ZWN0Cj4+Cj4+ ICBkcml2ZXJzL2Nsay9iY20vY2xrLWJjbTI4MzUuYyAgfCAxMyArKy0tLQo+PiAgZHJpdmVycy9n cHUvZHJtL3ZjNC92YzRfaGRtaS5jIHwgOTAgKysrKysrKysrKysrKysrKysrKysrKysrLS0tLS0t LS0tLQo+PiAgMiBmaWxlcyBjaGFuZ2VkLCA2OCBpbnNlcnRpb25zKCspLCAzNSBkZWxldGlvbnMo LSkKPj4KPj4gLS0KPj4gMi4zMS4xCj4+Cj4KPgo+IC0tCj4gQmVzdCByZWdhcmRzLAo+IE1pY2hh ZWwKCgoKLS0gCkJlc3QgcmVnYXJkcywKTWljaGFlbAoKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGlu dXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQu b3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=