From mboxrd@z Thu Jan  1 00:00:00 1970
From: yotam gigi <yotam.gi@gmail.com>
Subject: Re: [PATCH net 1/3] net: sched: ife: signal not finding metaid
Date: Thu, 19 Apr 2018 08:37:10 +0300
Message-ID: <CANnrxJjLvzoDiMWmv0Ad-O44N-Vc=8Jjm2KrEKxiLt9a9fcNmA@mail.gmail.com>
References: <20180418213534.6215-1-aring@mojatatu.com> <20180418213534.6215-2-aring@mojatatu.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Cc: Jamal Hadi Salim <jhs@mojatatu.com>, davem@davemloft.net,
        Cong Wang <xiyou.wangcong@gmail.com>,
        =?UTF-8?B?SmnFmcOtIFDDrXJrbw==?= <jiri@resnulli.us>,
        Yuval Mintz <yuvalm@mellanox.com>, netdev@vger.kernel.org,
        kernel@mojatatu.com
To: Alexander Aring <aring@mojatatu.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-io0-f196.google.com ([209.85.223.196]:45522 "EHLO
        mail-io0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750913AbeDSFhL (ORCPT
        <rfc822;netdev@vger.kernel.org>); Thu, 19 Apr 2018 01:37:11 -0400
Received: by mail-io0-f196.google.com with SMTP id a7-v6so5183824ioc.12
        for <netdev@vger.kernel.org>; Wed, 18 Apr 2018 22:37:11 -0700 (PDT)
In-Reply-To: <20180418213534.6215-2-aring@mojatatu.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Thu, Apr 19, 2018 at 12:35 AM, Alexander Aring <aring@mojatatu.com> wrote:
> We need to record stats for received metadata that we dont know how
> to process. Have find_decode_metaid() return -ENOENT to capture this.

Agree.

>
> Signed-off-by: Alexander Aring <aring@mojatatu.com>

Reviewed-by: Yotam Gigi <yotam.gi@gmail.com>

> ---
>  net/sched/act_ife.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/sched/act_ife.c b/net/sched/act_ife.c
> index a5994cf0512b..49b8ab551fbe 100644
> --- a/net/sched/act_ife.c
> +++ b/net/sched/act_ife.c
> @@ -652,7 +652,7 @@ static int find_decode_metaid(struct sk_buff *skb, struct tcf_ife_info *ife,
>                 }
>         }
>
> -       return 0;
> +       return -ENOENT;
>  }
>
>  static int tcf_ife_decode(struct sk_buff *skb, const struct tc_action *a,
> --
> 2.11.0
>