From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A00CC433E0 for ; Thu, 28 May 2020 17:11:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ECC8720721 for ; Thu, 28 May 2020 17:11:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="XPXvL/9o" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405349AbgE1RLb (ORCPT ); Thu, 28 May 2020 13:11:31 -0400 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:54219 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2405320AbgE1RLa (ORCPT ); Thu, 28 May 2020 13:11:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1590685887; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xaYkM24G2m803F/chb/jq5pTBxpALIamh9MB8ZyiK4k=; b=XPXvL/9oMcKj3o3Os1KDPX1jTM78tAhBs6xzlo5P5fTj9JJujLlsbC36Me65/TV82PflsV rmH2TyDnAcLQg5U8y9fqVfAhUGINnXZFFR9GaC9F5STNjuRtZ2PUyQzRBfSQLiQP1hjGp4 Lbt5mu1ljqTcpzq/m4Z1QEBvbYZNyTI= Received: from mail-oo1-f70.google.com (mail-oo1-f70.google.com [209.85.161.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-504-utugfRQMOh66XuOCRaoeHQ-1; Thu, 28 May 2020 13:11:22 -0400 X-MC-Unique: utugfRQMOh66XuOCRaoeHQ-1 Received: by mail-oo1-f70.google.com with SMTP id y16so921627oot.1 for ; Thu, 28 May 2020 10:11:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=xaYkM24G2m803F/chb/jq5pTBxpALIamh9MB8ZyiK4k=; b=qmeHdd2x3MGXxQMkoHuuxC78QMJRe+Ox9wR7mgWrtXf2s8qc0WDa9wnbNQWwbYYM1j VSy3sBJyZNGG4zJ2nBMuaWjEDkPFfiiq+TMJalRfSIsYb8WDHoJYgY8Oc+70Ej1rfpBz GDtvIY8cuzgemheFz1a/LxAZ9ffjkKx2q5A0rsFMEDCZCShE8I67WzsbTMoppO8ADCbn WKNCGLHSYNNtBxDAJ0GIdwA35D/4kXQUG1Fm/5qzUfs/jovf6l9xG+n2IA9EhQCWG4vy 8hTo/4USNDCedEcvI5JtWUHC99EK6p+sNLkp51sweVt7Y1IrYjVEy8jUm85TP1o96TFV I9LQ== X-Gm-Message-State: AOAM530wSUyL6oAxULXs5k3w+N2a10DL/+lmNsa43JQgEYKweOuL2Fqb kZtE+d8be5nptgbuGxtM+ojc3gQjwS+QFtSX4AA1AXE4bB4vUASeuczMmLA8IcqR2cRABQilzVD J4wRE1Q7GYDVoTZef7+Q2HLqsgZMQ X-Received: by 2002:aca:f3c6:: with SMTP id r189mr2798497oih.73.1590685873680; Thu, 28 May 2020 10:11:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzNpt7lm09wPE/RS56oNAzVrcNKbkTdlzTw/HKlW3RUZud4VndZKG1homLi/1T2REUUB8K/J+bW21Kp6ThU/Pk= X-Received: by 2002:aca:f3c6:: with SMTP id r189mr2798478oih.73.1590685873348; Thu, 28 May 2020 10:11:13 -0700 (PDT) MIME-Version: 1.0 References: <20200528100557.20489f04@redhat.com> <20200528105631.GE3115014@kroah.com> <20200528161437.x3e2ddxmj6nlhvv7@ast-mbp.dhcp.thefacebook.com> In-Reply-To: <20200528161437.x3e2ddxmj6nlhvv7@ast-mbp.dhcp.thefacebook.com> From: Yauheni Kaliuta Date: Thu, 28 May 2020 20:10:57 +0300 Message-ID: Subject: Re: [PATCH] selftests/bpf: split -extras target to -static and -gen To: Alexei Starovoitov Cc: Greg KH , Jiri Benc , shuah , Andrii Nakryiko , bpf , Jiri Olsa , Andrii Nakryiko , Daniel Borkmann , "open list:KERNEL SELFTEST FRAMEWORK" Content-Type: text/plain; charset="UTF-8" Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org Hi, Alexei, On Thu, May 28, 2020 at 7:14 PM Alexei Starovoitov wrote: > > On Thu, May 28, 2020 at 12:56:31PM +0200, Greg KH wrote: > > On Thu, May 28, 2020 at 10:05:57AM +0200, Jiri Benc wrote: > > > On Wed, 27 May 2020 15:23:13 -0700, Alexei Starovoitov wrote: > > > > I prefer to keep selftests/bpf install broken. > > > > This forced marriage between kselftests and selftests/bpf > > > > never worked well. I think it's a time to free them up from each other. > > > > > > Alexei, it would be great if you could cooperate with other people > > > instead of pushing your own way. The selftests infrastructure was put > > > to the kernel to have one place for testing. Inventing yet another way > > > to add tests does not help anyone. You don't own the kernel. We're > > > community, we should cooperate. > > > > I agree, we rely on the infrastructure of the kselftests framework so > > that testing systems do not have to create "custom" frameworks to handle > > all of the individual variants that could easily crop up here. > > > > Let's keep it easy for people to run and use these tests, to not do so > > is to ensure that they are not used, which is the exact opposite goal of > > creating tests. > > Greg, > > It is easy for people (bpf developers) to run and use the tests. > Every developer runs them before submitting patches. > New tests is a hard requirement for any new features. > Maintainers run them for every push. > > What I was and will push back hard is when other people (not bpf developers) > come back with an excuse that some CI system has a hard time running these > tests. It's the problem of weak CI. That CI needs to be fixed. Not the tests. > The example of this is that we already have github/libbpf CI that runs > selftests/bpf just fine. Anyone who wants to do another CI are welcome to copy > paste what already works instead of burdening people (bpf developers) who run > and use existing tests. I frankly have no sympathy to folks who put their own > interest of their CI development in front of bpf community of developers. > The main job of CI is to help developers and maintainers. > Where helping means to not impose new dumb rules on developers because CI > framework is dumb. Fix CI instead. > Any good reason why bpf selftests, residing under selftests/, should be an exception? "Breakages" is not, breakages are fixable. -- WBR, Yauheni