From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B8798C19F2D for ; Tue, 9 Aug 2022 17:02:29 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id F252A84A71; Tue, 9 Aug 2022 19:02:26 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="o5wcdprb"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id BD05E84A63; Tue, 9 Aug 2022 19:02:24 +0200 (CEST) Received: from mail-vk1-xa30.google.com (mail-vk1-xa30.google.com [IPv6:2607:f8b0:4864:20::a30]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 313A184A86 for ; Tue, 9 Aug 2022 19:02:19 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=ralph.siemsen@linaro.org Received: by mail-vk1-xa30.google.com with SMTP id x128so3135198vke.3 for ; Tue, 09 Aug 2022 10:02:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc; bh=Y0RJ5rDgapg96vlxwSb4hwdNLN+EWToBWo8PhTmaYpw=; b=o5wcdprbSM8f7uhFOHwTlPJfLYLy/Yn8yRw0qJxz/7unRaAz0TDSMFEKU0FRK7GGp6 1rKcvA+C45v8qR1Wj2SpG+S482zOqWxChkYh2DhcgE/Sf7aWMZD+0329oNmhisLRKvh6 WIP5HCCCtLujAX9d8GMwE7zSCXAPhCe8lvARVaF8ovDv42Ah61wneBmaI/ZwmvmytQXq 5Hbsk1AiWZR4s6ZFbcP5kiPvtBd+YZIMef9s1D/t/wNPQktn3xwTDQsiCF2Ww934Cnfq 18u2+YE8fsOWU2s9web6MZxGsK5Y0k0tKbHP+j7c1jnl45KfVW0BbVnRhqFRrmPiKqi0 Osyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc; bh=Y0RJ5rDgapg96vlxwSb4hwdNLN+EWToBWo8PhTmaYpw=; b=BRK1Jl6zMU7zvKasnDmOvdLfke+GF86x2wUZ+x2TLwCfTu+/MjwEdRWdkgKzwWfOaF X7vzhQ1MJZevrtgiL3jCwxWgSZFyEW4J/ebwj1LgsSb8rQnHAD3kcfw9Nn/YemyVXZ6E L1eGZfrtHlICunjzYRLPxrQQ/mKJnrAfoFthOVWum6NhphpTMRpldLsY7s+CxORB9DFm VrB9E1uN+Ffj4kp3njgS/G1/172w1nWyY99lBUoaEK02ImhWu6DGpqHsSxP8MKV5fC+w kJR9EEO9jaHObxvK7dZshu8ScZZR40QeOd90f1HqLI4+3+ocP0oMQiuxhoQIVWdQIUwX OFSA== X-Gm-Message-State: ACgBeo3+XukdFGEHCzND+bPZjWEHBQUV//biIVeHGtT0hzU5NLEWs6dq sJNIqN00N6G3WIsVvYku4Jg2+XlBj+V+2LQcfS7HfQ== X-Google-Smtp-Source: AA6agR5pUP66i+17ucQZt7F25HyUNMrypKOpaIhnC9we4UTe8AhV7y0v91BMNmUnJJCX5X8G0YnKFM2vCCPAxjQ97LY= X-Received: by 2002:a1f:a48b:0:b0:376:6af3:55 with SMTP id n133-20020a1fa48b000000b003766af30055mr10246317vke.18.1660064537580; Tue, 09 Aug 2022 10:02:17 -0700 (PDT) MIME-Version: 1.0 References: <20220809125959.217333-1-ralph.siemsen@linaro.org> <20220809125959.217333-10-ralph.siemsen@linaro.org> <20220809130348.hhtdgnytufppni72@pali> <20220809130726.iikcgrqnnts55fyi@pali> <20220809160659.a4t4hyvbhj2f52o7@pali> In-Reply-To: <20220809160659.a4t4hyvbhj2f52o7@pali> From: Ralph Siemsen Date: Tue, 9 Aug 2022 13:02:06 -0400 Message-ID: Subject: Re: [RFC PATCH v1 9/9] tools: Add tool to create Renesas SPKG images To: =?UTF-8?Q?Pali_Roh=C3=A1r?= Cc: u-boot@lists.denx.de, AKASHI Takahiro , Andre Przywara , Heiko Thiery , Samuel Holland , Simon Glass , Stefan Roese Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On Tue, Aug 9, 2022 at 12:07 PM Pali Roh=C3=A1r wrote: > > This documentation is not probably up-to-date. List of all kwbimage > config options can be visible in kwbimage_generate_config() function. I will check the code as well. > > 1) mkimage already has far too many options > > I know. But for nand there can be just --nand suboption1,suboption2,... > format. For other non-nand vendor specific option it would be an issue. > Maybe something like --vendor option or --image-options ... could be > used? In my case this would work, as there are only 3 parameters for NAND. However in general, it could get pretty messy, I see at least ten different NAND parameters described in the NAND DT binding. > > 2) covering all possible vendor-specific values/encodings of NAND > > parameters would be quite a task > > Yea, it is problematic. But... is not everything related to NAND just > common to what can be specified in device tree properties for nand node? > And de-facto already known and well-defined? I did have the thought of using device tree. It does have the advantage that it is a known format with defined parameters. > Because I cannot imagine what else for what there is not already device > tree binding, could be required for vendor bootrom. (But maybe I just do > not see it...) In quite a few cases, the DT parameters are incomplete, or just hints (see "nand-ecc-maximize"), that trigger various run-time decisions about the actual parameters. Duplicating this logic in mkimage seems difficult, bordering on impossible if it depends on run-time identification of the flash chip, for example. > Just one suggestion: It is a good idea to also implement "verify_header" > mkimage callback. Build process then use it to verify that generated > image is really correct. I'll check it out, thanks! Ralph