From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F3ECC433EF for ; Thu, 17 Feb 2022 17:08:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243589AbiBQRI3 (ORCPT ); Thu, 17 Feb 2022 12:08:29 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:41194 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237119AbiBQRI1 (ORCPT ); Thu, 17 Feb 2022 12:08:27 -0500 Received: from mail-io1-xd30.google.com (mail-io1-xd30.google.com [IPv6:2607:f8b0:4864:20::d30]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7127B171286 for ; Thu, 17 Feb 2022 09:08:12 -0800 (PST) Received: by mail-io1-xd30.google.com with SMTP id q20so2149788ioi.0 for ; Thu, 17 Feb 2022 09:08:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=M11Cv6Sf/j5dBAWER/x//EgaASJgRbtSRPsqwYtb7M4=; b=AQ/k55OjpjGBB1pLkNFlC+B4Rqjq1fFpYg5CWkuHo4cjDdAbCAo3Lc79LQGsvtj/RF rDW48u3nVT+DhEbuxVoUB8m6H25pvVyJICHiCp1Aw41/bpjCeoe0T4oces4UdzEB+tMD 7rIPNu/QXKZttNEFVzZn+psJ0FHqQV+FbrCxEGPtGOKHloBGt/HoRprd9lUGW1k2Pdy4 FUhDkepXMh/hblE2VOmrhVy1ZlyjDYgOwNkzPsWc0aauENwk24GT8UD4SypDWGKX26Sl 1NKFiSXKBflQPL/NtcN1Llc1XlrcmvxRs1DDRH/YOuTt714XkvP67ZUsoCIBGP5DQt+v 2F5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=M11Cv6Sf/j5dBAWER/x//EgaASJgRbtSRPsqwYtb7M4=; b=UN/wqa3pxWXx0B6vug2KlY2pKfOp9V2YIXbwwipZFTADIuKNL+HAgazjGLPAOJQiTc NSOdgXMdHLHVX/6KixEzoSfQhhjLA3WO8Z4gl1v611fTXX2we+PmZ0sC2Dh7U87uuy1d 7f2k10XzmJ6uzu4eSMQJDd421BY1QSAv2UeA9i8FAVHhKHIgA6Yzyq8t4p2HxwUB76l5 HcM9Ce+hzBgHRAgzzo1eErhtLWBJSEa9sOgMwZq0Va35wQ5d+mnqK+bJC4MiOvmFGwnK 0PCy1WLG1iNDtwlXY826Po5expNqFm1UcNqCKxHreM0NKwVinadtylUmVoYel7+BD3U6 /9Zg== X-Gm-Message-State: AOAM533zZPQXtP85zKbb24B6TYOStsRMVB2HvK5Pg8wO88adxqtw8t+M FglCPQ6eAmjpdLk2mDZB/BaINRdFl8bNDhh8myEHvQ== X-Google-Smtp-Source: ABdhPJyilzR9QVcWD7iWcOH8FJUnoZ1sJLTQbCGDblWFfwASjChV0x5rcZZZLRppbnsEtWInlhUNc/BOGQygTfvfwLM= X-Received: by 2002:a02:6308:0:b0:30e:7e14:848b with SMTP id j8-20020a026308000000b0030e7e14848bmr2446771jac.139.1645117690194; Thu, 17 Feb 2022 09:08:10 -0800 (PST) MIME-Version: 1.0 References: <00000000000038779505d5d8b372@google.com> In-Reply-To: From: Aleksandr Nogikh Date: Thu, 17 Feb 2022 18:07:59 +0100 Message-ID: Subject: Re: [syzbot] riscv/fixes boot error: can't ssh into the instance To: Alexandre Ghiti Cc: Dmitry Vyukov , Alexandre Ghiti , linux-riscv@lists.infradead.org, kasan-dev , Palmer Dabbelt , syzbot , LKML , syzkaller-bugs@googlegroups.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Alex, On Thu, Feb 17, 2022 at 5:53 PM Alexandre Ghiti wrote: > > Aleksandr, > > On Wed, Feb 16, 2022 at 5:58 PM Alexandre Ghiti > wrote: > > > > First, thank you for working on this. > > > > On Wed, Feb 16, 2022 at 5:17 PM Aleksandr Nogikh wrote: > > > > > > If I use just defconfig + DEBUG_VIRTUAL, without any KASAN, it begins > > > to boot, but overwhelms me with tons of `virt_to_phys used for > > > non-linear address:` errors. > > > > > > Like that > > > > > > [ 2.701271] virt_to_phys used for non-linear address: > > > 00000000b59e31b6 (0xffffffff806c2000) > > > [ 2.701727] WARNING: CPU: 0 PID: 1 at arch/riscv/mm/physaddr.c:16 > > > __virt_to_phys+0x7e/0x86 > > > [ 2.702207] Modules linked in: > > > [ 2.702393] CPU: 0 PID: 1 Comm: swapper/0 Tainted: G W > > > 5.17.0-rc1 #1 > > > [ 2.702806] Hardware name: riscv-virtio,qemu (DT) > > > [ 2.703051] epc : __virt_to_phys+0x7e/0x86 > > > [ 2.703298] ra : __virt_to_phys+0x7e/0x86 > > > [ 2.703547] epc : ffffffff80008448 ra : ffffffff80008448 sp : > > > ffff8f800021bde0 > > > [ 2.703977] gp : ffffffff80ed9b30 tp : ffffaf8001230000 t0 : > > > ffffffff80eea56f > > > [ 2.704704] t1 : ffffffff80eea560 t2 : 0000000000000000 s0 : > > > ffff8f800021be00 > > > [ 2.705153] s1 : ffffffff806c2000 a0 : 000000000000004f a1 : > > > ffffffff80e723d8 > > > [ 2.705555] a2 : 0000000000000010 a3 : fffffffffffffffe a4 : > > > 0000000000000000 > > > [ 2.706027] a5 : 0000000000000000 a6 : 0000000000000005 a7 : > > > ffffffffffffffff > > > [ 2.706474] s2 : ffffffff80b80b08 s3 : 00000000000000c2 s4 : > > > ffffffff806c2000 > > > [ 2.706891] s5 : ffffffff80edba10 s6 : ffffffff80edb960 s7 : > > > 0000000000000001 > > > [ 2.707290] s8 : 00000000000000ff s9 : ffffffff80b80b40 s10: > > > 00000000000000cc > > > [ 2.707689] s11: ffffaf807e1fcf00 t3 : 0000000000000076 t4 : > > > ffffffffffffffff > > > [ 2.708092] t5 : 00000000000001f2 t6 : ffff8f800021bb48 > > > [ 2.708433] status: 0000000000000120 badaddr: 0000000000000000 > > > cause: 0000000000000003 > > > [ 2.708919] [] free_reserved_area+0x72/0x19a > > > [ 2.709296] [] free_initmem+0x6c/0x7c > > > [ 2.709648] [] kernel_init+0x3a/0x10a > > > [ 2.709993] [] ret_from_exception+0x0/0xc > > > [ 2.710310] ---[ end trace 0000000000000000 ]--- > > > > > > > I was able to reproduce this: the first one regarding init_zero_pfn is > > legit but not wrong, I have to check when it was introduced and how to > > fix this. > > Regarding the huge batch that follows, at first sight, I would say > > this is linked to my sv48 patchset but that does not seem important as > > the address is a kernel mapping address so the use of virt_to_phys is > > right. > > > > > On Wed, Feb 16, 2022 at 5:09 PM Aleksandr Nogikh wrote: > > > > > > > > On Wed, Feb 16, 2022 at 12:56 PM Dmitry Vyukov wrote: > > > > > > > > > > On Wed, 16 Feb 2022 at 12:47, Aleksandr Nogikh wrote: > > > > > > > > > > > > On Wed, Feb 16, 2022 at 11:37 AM Aleksandr Nogikh wrote: > > > > > > > > > > > > > > Hi Alex, > > > > > > > > > > > > > > On Wed, Feb 16, 2022 at 5:14 AM Alexandre Ghiti wrote: > > > > > > > > > > > > > > > > Hi Dmitry, > > > > > > > > > > > > > > > > On 2/15/22 18:12, Dmitry Vyukov wrote: > > > > > > > > > On Wed, 2 Feb 2022 at 14:18, Alexandre Ghiti > > > > > > > > > wrote: > > > > > > > > >> Hi Aleksandr, > > > > > > > > >> > > > > > > > > >> On Wed, Feb 2, 2022 at 12:08 PM Aleksandr Nogikh wrote: > > > > > > > > >>> Hello, > > > > > > > > >>> > > > > > > > > >>> syzbot has already not been able to fuzz its RISC-V instance for 97 > > > > > > > > >> That's a longtime, I'll take a look more regularly. > > > > > > > > >> > > > > > > > > >>> days now because the compiled kernel cannot boot. I bisected the issue > > > > > > > > >>> to the following commit: > > > > > > > > >>> > > > > > > > > >>> commit 54c5639d8f507ebefa814f574cb6f763033a72a5 > > > > > > > > >>> Author: Alexandre Ghiti > > > > > > > > >>> Date: Fri Oct 29 06:59:27 2021 +0200 > > > > > > > > >>> > > > > > > > > >>> riscv: Fix asan-stack clang build > > > > > > > > >>> > > > > > > > > >>> Apparently, the problem appears on GCC-built RISC-V kernels with KASAN > > > > > > > > >>> enabled. In the previous message syzbot mentions > > > > > > > > >>> "riscv64-linux-gnu-gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU > > > > > > > > >>> Binutils for Debian) 2.35.2", but the issue also reproduces finely on > > > > > > > > >>> a newer GCC compiler: "riscv64-linux-gnu-gcc (Debian 11.2.0-10) > > > > > > > > >>> 11.2.0, GNU ld (GNU Binutils for Debian) 2.37". > > > > > > > > >>> For convenience, I also duplicate the .config file from the bot's > > > > > > > > >>> message: https://syzkaller.appspot.com/x/.config?x=522544a2e0ef2a7d > > > > > > > > >>> > > > > > > > > >>> Can someone with KASAN and RISC-V expertise please take a look? > > > > > > > > >> I'll take a look at that today. > > > > > > > > >> > > > > > > > > >> Thanks for reporting the issue, > > > > > > > > > > > > > > > > > > > > > > > > > I took a quick look, not enough to fix it but I know the issue comes > > > > > > > > from the inline instrumentation, I have no problem with the outline > > > > > > > > instrumentation. I need to find some cycles to work on this, my goal is > > > > > > > > to fix this for 5.17. > > > > > > > > > > > > > > Thanks for the update! > > > > > > > > > > > > > > Can you please share the .config with which you tested the outline > > > > > > > instrumentation? > > > > > > > I updated the syzbot config to use KASAN_OUTLINE instead of KASAN_INLINE, > > > > > > > but it still does not boot :( > > > > > > > > > > > > > > Here's what I used: > > > > > > > https://gist.github.com/a-nogikh/279c85c2d24f47efcc3e865c08844138 > > > > > > > > > > > > Update: it doesn't boot with that big config, but boots if I generate > > > > > > a simple one with KASAN_OUTLINE: > > > > > > > > > > > > make defconfig ARCH=riscv CROSS_COMPILE=riscv64-linux-gnu- > > > > > > ./scripts/config -e KASAN -e KASAN_OUTLINE > > > > > > make olddefconfig ARCH=riscv CROSS_COMPILE=riscv64-linux-gnu- > > > > > > > > > > > > And it indeed doesn't work if I use KASAN_INLINE. > > > > > > > > > > It may be an issue with code size. Full syzbot config + KASAN + KCOV > > > > > produce hugely massive .text. It may be hitting some limitation in the > > > > > bootloader/kernel bootstrap code. > > > > I took a quick glance and it traps on a KASAN address that is not > > mapped, either because it is too soon or because the mapping failed > > somehow. > > > > I'll definitely dive into that tomorrow, sorry for being slow here and > > thanks again for all your work, that helps a lot. > > > > Thanks, > > > > Alex > > > > > > > > > > I bisected the difference between the config we use on syzbot and the > > > > simple one that was generated like I described above. > > > > Turns out that it's the DEBUG_VIRTUAL config that makes the difference. > > > > > > > > make defconfig ARCH=riscv CROSS_COMPILE=riscv64-linux-gnu- > > > > ./scripts/config -e KASAN -e KASAN_OUTLINE -e DEBUG_VIRTUAL > > > > make olddefconfig ARCH=riscv CROSS_COMPILE=riscv64-linux-gnu- > > > > > > > > And the resulting kernel does not boot. > > > > My env: the `riscv/fixes` branch, commit > > > > 6df2a016c0c8a3d0933ef33dd192ea6606b115e3, qemu 6.2.0. > > I fixed a few things today: KASAN + SPARSE_VMEMMAP, DEBUG_VIRTUAL and > maybe KASAN + KCOV. > > With those small fixes, I was able to boot your large dotconfig with > KASAN_OUTLINE, the inline version still fails, this is my next target > :) > I'll push that tomorrow! Awesome, thank you very much! Looking forward to finally seeing the instance run :) -- Best Regards, Aleksandr > > Thanks again, > > Alex From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 189B3C433F5 for ; Thu, 17 Feb 2022 17:08:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Io4vpbOfVh+16MX/jdOVdOTNW5HaKRUYffyQ3i/Ormw=; b=rBeVuYjC5rolru X5Q/Qg212AMBETNZkvgkgejhpLxFC1NH7Ct0+kJag0WOo9jr1Rmq33BKCdVgYbvoKfIe8q9bx4/6C jhYCCmbwOR98P6njNg4UM15lDxWCb/EVJWsR6hkEjshQfyglrRHK5r0bMeoZ2iQ0aZ6lwy7TBuMs9 9S2u5FCNvgGTKuMDEDGfD5kTASMyR/XUoYKJBDZNa0uMFgLDAbo5Ru98+iiyMpt11+aY74lM52ZQB XMHDag5n77E32WeMtJGID/DOqPz5sIQDGyeGeeBtzLoT9yaNsvnFIRjOsgnrn7pHsKPk0Ylm/k9CP 81GFmW1OglI5hjK+Hd5Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nKkGQ-00BY7L-J0; Thu, 17 Feb 2022 17:08:18 +0000 Received: from mail-io1-xd32.google.com ([2607:f8b0:4864:20::d32]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nKkGN-00BY68-QQ for linux-riscv@lists.infradead.org; Thu, 17 Feb 2022 17:08:17 +0000 Received: by mail-io1-xd32.google.com with SMTP id m185so4426062iof.10 for ; Thu, 17 Feb 2022 09:08:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=M11Cv6Sf/j5dBAWER/x//EgaASJgRbtSRPsqwYtb7M4=; b=AQ/k55OjpjGBB1pLkNFlC+B4Rqjq1fFpYg5CWkuHo4cjDdAbCAo3Lc79LQGsvtj/RF rDW48u3nVT+DhEbuxVoUB8m6H25pvVyJICHiCp1Aw41/bpjCeoe0T4oces4UdzEB+tMD 7rIPNu/QXKZttNEFVzZn+psJ0FHqQV+FbrCxEGPtGOKHloBGt/HoRprd9lUGW1k2Pdy4 FUhDkepXMh/hblE2VOmrhVy1ZlyjDYgOwNkzPsWc0aauENwk24GT8UD4SypDWGKX26Sl 1NKFiSXKBflQPL/NtcN1Llc1XlrcmvxRs1DDRH/YOuTt714XkvP67ZUsoCIBGP5DQt+v 2F5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=M11Cv6Sf/j5dBAWER/x//EgaASJgRbtSRPsqwYtb7M4=; b=6P+h8wSkY8aWliiOWKeqCbp6b7+ZuDz0HRh3GF6hLIG87B46aoVNAEyzjXGzkayTJW 2XpO/528+KNfH2TgirEcRZtXE5YEQptRqpilwDXd9eenLCr6TKuOWR1Kwk/60taaNc17 f1UQh6F+AH6w1yOFWhE0ckLVQRaEcRn/rJDZp0k5glXIKiJG90qWPI4NNhrTE8TXXLpe ryMCam2/lp2tSGSOn401VPw92/cqXnrGu0tOq6iZjDQqr1RyglE+uL4UK5nZDJ+hXbC+ UY++qDvgfqAvZJnpT6SYQ5rfaW6MjrlFxT0/nuRBNsUPkM+E5SqDo+ldvu6y5V9g087n GzYg== X-Gm-Message-State: AOAM531kFcNMg5gNZphci/DbwCA1Cch4sFClWLnNyKvdN9GitG12JrgX 1c+NODV3oE/51i2UtudgLMiJQLoQJLdWpQ/wd9tYLA== X-Google-Smtp-Source: ABdhPJyilzR9QVcWD7iWcOH8FJUnoZ1sJLTQbCGDblWFfwASjChV0x5rcZZZLRppbnsEtWInlhUNc/BOGQygTfvfwLM= X-Received: by 2002:a02:6308:0:b0:30e:7e14:848b with SMTP id j8-20020a026308000000b0030e7e14848bmr2446771jac.139.1645117690194; Thu, 17 Feb 2022 09:08:10 -0800 (PST) MIME-Version: 1.0 References: <00000000000038779505d5d8b372@google.com> In-Reply-To: From: Aleksandr Nogikh Date: Thu, 17 Feb 2022 18:07:59 +0100 Message-ID: Subject: Re: [syzbot] riscv/fixes boot error: can't ssh into the instance To: Alexandre Ghiti Cc: Dmitry Vyukov , Alexandre Ghiti , linux-riscv@lists.infradead.org, kasan-dev , Palmer Dabbelt , syzbot , LKML , syzkaller-bugs@googlegroups.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220217_090815_885874_D63D36CB X-CRM114-Status: GOOD ( 47.74 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org Hi Alex, On Thu, Feb 17, 2022 at 5:53 PM Alexandre Ghiti wrote: > > Aleksandr, > > On Wed, Feb 16, 2022 at 5:58 PM Alexandre Ghiti > wrote: > > > > First, thank you for working on this. > > > > On Wed, Feb 16, 2022 at 5:17 PM Aleksandr Nogikh wrote: > > > > > > If I use just defconfig + DEBUG_VIRTUAL, without any KASAN, it begins > > > to boot, but overwhelms me with tons of `virt_to_phys used for > > > non-linear address:` errors. > > > > > > Like that > > > > > > [ 2.701271] virt_to_phys used for non-linear address: > > > 00000000b59e31b6 (0xffffffff806c2000) > > > [ 2.701727] WARNING: CPU: 0 PID: 1 at arch/riscv/mm/physaddr.c:16 > > > __virt_to_phys+0x7e/0x86 > > > [ 2.702207] Modules linked in: > > > [ 2.702393] CPU: 0 PID: 1 Comm: swapper/0 Tainted: G W > > > 5.17.0-rc1 #1 > > > [ 2.702806] Hardware name: riscv-virtio,qemu (DT) > > > [ 2.703051] epc : __virt_to_phys+0x7e/0x86 > > > [ 2.703298] ra : __virt_to_phys+0x7e/0x86 > > > [ 2.703547] epc : ffffffff80008448 ra : ffffffff80008448 sp : > > > ffff8f800021bde0 > > > [ 2.703977] gp : ffffffff80ed9b30 tp : ffffaf8001230000 t0 : > > > ffffffff80eea56f > > > [ 2.704704] t1 : ffffffff80eea560 t2 : 0000000000000000 s0 : > > > ffff8f800021be00 > > > [ 2.705153] s1 : ffffffff806c2000 a0 : 000000000000004f a1 : > > > ffffffff80e723d8 > > > [ 2.705555] a2 : 0000000000000010 a3 : fffffffffffffffe a4 : > > > 0000000000000000 > > > [ 2.706027] a5 : 0000000000000000 a6 : 0000000000000005 a7 : > > > ffffffffffffffff > > > [ 2.706474] s2 : ffffffff80b80b08 s3 : 00000000000000c2 s4 : > > > ffffffff806c2000 > > > [ 2.706891] s5 : ffffffff80edba10 s6 : ffffffff80edb960 s7 : > > > 0000000000000001 > > > [ 2.707290] s8 : 00000000000000ff s9 : ffffffff80b80b40 s10: > > > 00000000000000cc > > > [ 2.707689] s11: ffffaf807e1fcf00 t3 : 0000000000000076 t4 : > > > ffffffffffffffff > > > [ 2.708092] t5 : 00000000000001f2 t6 : ffff8f800021bb48 > > > [ 2.708433] status: 0000000000000120 badaddr: 0000000000000000 > > > cause: 0000000000000003 > > > [ 2.708919] [] free_reserved_area+0x72/0x19a > > > [ 2.709296] [] free_initmem+0x6c/0x7c > > > [ 2.709648] [] kernel_init+0x3a/0x10a > > > [ 2.709993] [] ret_from_exception+0x0/0xc > > > [ 2.710310] ---[ end trace 0000000000000000 ]--- > > > > > > > I was able to reproduce this: the first one regarding init_zero_pfn is > > legit but not wrong, I have to check when it was introduced and how to > > fix this. > > Regarding the huge batch that follows, at first sight, I would say > > this is linked to my sv48 patchset but that does not seem important as > > the address is a kernel mapping address so the use of virt_to_phys is > > right. > > > > > On Wed, Feb 16, 2022 at 5:09 PM Aleksandr Nogikh wrote: > > > > > > > > On Wed, Feb 16, 2022 at 12:56 PM Dmitry Vyukov wrote: > > > > > > > > > > On Wed, 16 Feb 2022 at 12:47, Aleksandr Nogikh wrote: > > > > > > > > > > > > On Wed, Feb 16, 2022 at 11:37 AM Aleksandr Nogikh wrote: > > > > > > > > > > > > > > Hi Alex, > > > > > > > > > > > > > > On Wed, Feb 16, 2022 at 5:14 AM Alexandre Ghiti wrote: > > > > > > > > > > > > > > > > Hi Dmitry, > > > > > > > > > > > > > > > > On 2/15/22 18:12, Dmitry Vyukov wrote: > > > > > > > > > On Wed, 2 Feb 2022 at 14:18, Alexandre Ghiti > > > > > > > > > wrote: > > > > > > > > >> Hi Aleksandr, > > > > > > > > >> > > > > > > > > >> On Wed, Feb 2, 2022 at 12:08 PM Aleksandr Nogikh wrote: > > > > > > > > >>> Hello, > > > > > > > > >>> > > > > > > > > >>> syzbot has already not been able to fuzz its RISC-V instance for 97 > > > > > > > > >> That's a longtime, I'll take a look more regularly. > > > > > > > > >> > > > > > > > > >>> days now because the compiled kernel cannot boot. I bisected the issue > > > > > > > > >>> to the following commit: > > > > > > > > >>> > > > > > > > > >>> commit 54c5639d8f507ebefa814f574cb6f763033a72a5 > > > > > > > > >>> Author: Alexandre Ghiti > > > > > > > > >>> Date: Fri Oct 29 06:59:27 2021 +0200 > > > > > > > > >>> > > > > > > > > >>> riscv: Fix asan-stack clang build > > > > > > > > >>> > > > > > > > > >>> Apparently, the problem appears on GCC-built RISC-V kernels with KASAN > > > > > > > > >>> enabled. In the previous message syzbot mentions > > > > > > > > >>> "riscv64-linux-gnu-gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU > > > > > > > > >>> Binutils for Debian) 2.35.2", but the issue also reproduces finely on > > > > > > > > >>> a newer GCC compiler: "riscv64-linux-gnu-gcc (Debian 11.2.0-10) > > > > > > > > >>> 11.2.0, GNU ld (GNU Binutils for Debian) 2.37". > > > > > > > > >>> For convenience, I also duplicate the .config file from the bot's > > > > > > > > >>> message: https://syzkaller.appspot.com/x/.config?x=522544a2e0ef2a7d > > > > > > > > >>> > > > > > > > > >>> Can someone with KASAN and RISC-V expertise please take a look? > > > > > > > > >> I'll take a look at that today. > > > > > > > > >> > > > > > > > > >> Thanks for reporting the issue, > > > > > > > > > > > > > > > > > > > > > > > > > I took a quick look, not enough to fix it but I know the issue comes > > > > > > > > from the inline instrumentation, I have no problem with the outline > > > > > > > > instrumentation. I need to find some cycles to work on this, my goal is > > > > > > > > to fix this for 5.17. > > > > > > > > > > > > > > Thanks for the update! > > > > > > > > > > > > > > Can you please share the .config with which you tested the outline > > > > > > > instrumentation? > > > > > > > I updated the syzbot config to use KASAN_OUTLINE instead of KASAN_INLINE, > > > > > > > but it still does not boot :( > > > > > > > > > > > > > > Here's what I used: > > > > > > > https://gist.github.com/a-nogikh/279c85c2d24f47efcc3e865c08844138 > > > > > > > > > > > > Update: it doesn't boot with that big config, but boots if I generate > > > > > > a simple one with KASAN_OUTLINE: > > > > > > > > > > > > make defconfig ARCH=riscv CROSS_COMPILE=riscv64-linux-gnu- > > > > > > ./scripts/config -e KASAN -e KASAN_OUTLINE > > > > > > make olddefconfig ARCH=riscv CROSS_COMPILE=riscv64-linux-gnu- > > > > > > > > > > > > And it indeed doesn't work if I use KASAN_INLINE. > > > > > > > > > > It may be an issue with code size. Full syzbot config + KASAN + KCOV > > > > > produce hugely massive .text. It may be hitting some limitation in the > > > > > bootloader/kernel bootstrap code. > > > > I took a quick glance and it traps on a KASAN address that is not > > mapped, either because it is too soon or because the mapping failed > > somehow. > > > > I'll definitely dive into that tomorrow, sorry for being slow here and > > thanks again for all your work, that helps a lot. > > > > Thanks, > > > > Alex > > > > > > > > > > I bisected the difference between the config we use on syzbot and the > > > > simple one that was generated like I described above. > > > > Turns out that it's the DEBUG_VIRTUAL config that makes the difference. > > > > > > > > make defconfig ARCH=riscv CROSS_COMPILE=riscv64-linux-gnu- > > > > ./scripts/config -e KASAN -e KASAN_OUTLINE -e DEBUG_VIRTUAL > > > > make olddefconfig ARCH=riscv CROSS_COMPILE=riscv64-linux-gnu- > > > > > > > > And the resulting kernel does not boot. > > > > My env: the `riscv/fixes` branch, commit > > > > 6df2a016c0c8a3d0933ef33dd192ea6606b115e3, qemu 6.2.0. > > I fixed a few things today: KASAN + SPARSE_VMEMMAP, DEBUG_VIRTUAL and > maybe KASAN + KCOV. > > With those small fixes, I was able to boot your large dotconfig with > KASAN_OUTLINE, the inline version still fails, this is my next target > :) > I'll push that tomorrow! Awesome, thank you very much! Looking forward to finally seeing the instance run :) -- Best Regards, Aleksandr > > Thanks again, > > Alex _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv