From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-f194.google.com ([209.85.167.194]:44539 "EHLO mail-oi1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729374AbfHTJ4J (ORCPT ); Tue, 20 Aug 2019 05:56:09 -0400 Received: by mail-oi1-f194.google.com with SMTP id k22so3615422oiw.11 for ; Tue, 20 Aug 2019 02:56:08 -0700 (PDT) MIME-Version: 1.0 References: <20190820024941.12640-1-dja@axtens.net> In-Reply-To: <20190820024941.12640-1-dja@axtens.net> From: Marco Elver Date: Tue, 20 Aug 2019 11:55:56 +0200 Message-ID: Subject: Re: [PATCH v2 1/2] kasan: support instrumented bitops combined with generic bitops Content-Type: text/plain; charset="UTF-8" Sender: linux-s390-owner@vger.kernel.org List-ID: To: Daniel Axtens Cc: christophe.leroy@c-s.fr, linux-s390@vger.kernel.org, linux-arch , the arch/x86 maintainers , linuxppc-dev@lists.ozlabs.org, kasan-dev On Tue, 20 Aug 2019 at 04:50, Daniel Axtens wrote: > > Currently bitops-instrumented.h assumes that the architecture provides > atomic, non-atomic and locking bitops (e.g. both set_bit and __set_bit). > This is true on x86 and s390, but is not always true: there is a > generic bitops/non-atomic.h header that provides generic non-atomic > operations, and also a generic bitops/lock.h for locking operations. > > powerpc uses the generic non-atomic version, so it does not have it's > own e.g. __set_bit that could be renamed arch___set_bit. > > Split up bitops-instrumented.h to mirror the atomic/non-atomic/lock > split. This allows arches to only include the headers where they > have arch-specific versions to rename. Update x86 and s390. > > (The generic operations are automatically instrumented because they're > written in C, not asm.) > > Suggested-by: Christophe Leroy > Reviewed-by: Christophe Leroy > Signed-off-by: Daniel Axtens Acked-by: Marco Elver Thanks! From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marco Elver Subject: Re: [PATCH v2 1/2] kasan: support instrumented bitops combined with generic bitops Date: Tue, 20 Aug 2019 11:55:56 +0200 Message-ID: References: <20190820024941.12640-1-dja@axtens.net> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <20190820024941.12640-1-dja@axtens.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linuxppc-dev-bounces+glppe-linuxppc-embedded-2=m.gmane.org@lists.ozlabs.org Sender: "Linuxppc-dev" To: Daniel Axtens Cc: linux-s390@vger.kernel.org, the arch/x86 maintainers , kasan-dev , linux-arch , linuxppc-dev@lists.ozlabs.org List-Id: linux-arch.vger.kernel.org On Tue, 20 Aug 2019 at 04:50, Daniel Axtens wrote: > > Currently bitops-instrumented.h assumes that the architecture provides > atomic, non-atomic and locking bitops (e.g. both set_bit and __set_bit). > This is true on x86 and s390, but is not always true: there is a > generic bitops/non-atomic.h header that provides generic non-atomic > operations, and also a generic bitops/lock.h for locking operations. > > powerpc uses the generic non-atomic version, so it does not have it's > own e.g. __set_bit that could be renamed arch___set_bit. > > Split up bitops-instrumented.h to mirror the atomic/non-atomic/lock > split. This allows arches to only include the headers where they > have arch-specific versions to rename. Update x86 and s390. > > (The generic operations are automatically instrumented because they're > written in C, not asm.) > > Suggested-by: Christophe Leroy > Reviewed-by: Christophe Leroy > Signed-off-by: Daniel Axtens Acked-by: Marco Elver Thanks!