From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC731C432C3 for ; Sat, 16 Nov 2019 08:21:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8C52520733 for ; Sat, 16 Nov 2019 08:21:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="XWnuclkq" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726975AbfKPIVI (ORCPT ); Sat, 16 Nov 2019 03:21:08 -0500 Received: from mail-ot1-f67.google.com ([209.85.210.67]:43364 "EHLO mail-ot1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726257AbfKPIVI (ORCPT ); Sat, 16 Nov 2019 03:21:08 -0500 Received: by mail-ot1-f67.google.com with SMTP id l14so10104834oti.10 for ; Sat, 16 Nov 2019 00:21:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=IAbPck/tyWYpcH6q1DqU0wF9VrcqMWHjsvfsasMdJQ8=; b=XWnuclkqZMItq+/ksJ8Y1qa9/9oIF2fdvK7zku42Z8ODKYKzpWGUzZ/8O3BaVjf7Ag P71ZJ18PYDh/S+GcXJv7JbUHBfrVxcoQ8Tvy3/rDGiRsih1j0Zfw3p0aX5sUwbDmnNzp UJbeoNYdVfNU8lrJD/bixaoQ7gvdzCi0y77rY6eMix67aCD4LLAxKMFtrjIBZplbOSLa whiths2ljXaRVaJ66Ty6f/l0eqANuJrB5x+g554vTxKefToWIvkl2VMJofQLrWCYVNFN uMyJ4CtcCuhbdCcrnripCXXi0U9CRkogJhOh3chGjPKJVPuRp3IpvYuKiS5dSot+QvZ1 UFSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=IAbPck/tyWYpcH6q1DqU0wF9VrcqMWHjsvfsasMdJQ8=; b=UiXPOXyecTswvOOwV30YXZkH0MLlBGuRQIJuTZHjDxQDZY7clcbUB8+WwRhrYiIdI0 Xgf3IT9KMGpVtFd0xz7B6AeTDwOGM+8AH1lXcz/4pwcvcRoHNon9N1SXNDyV431Go4XL uG61arCN+m5KXJdgliSojatpmnIK5DL2dcTVm4TU5rHQ5W+0mztBGxbvRcCHSmD3unNI o6dAfLMWPowHyhbSsaPaTeh8TsjWXmTYedgPML07cpqsibaUT3bdsMZFFKnrWHnJUxTN 4TK8NuFOKyhC93YWoF6QMfKrI27FT3RpZuKO+c/AXPzuQuAC7YeNpB86N+ez0Iklzdu6 kldw== X-Gm-Message-State: APjAAAW0B5ASKEWBINZ6JTKCnFJ6BdnnuVAIphjBtGHbJQDKV+1TjCmz ir057p1JjoixnuzLmjCEPPGuBE2Wj0F16BTDq6OWSA== X-Google-Smtp-Source: APXvYqyFoD1MoXKYzcJ0ETjr8RD5raPWnHWPSZdYf70aViyP/iAqqE28rDX/p+nlWotCJAjaCdGBcwat07yGzdHKecY= X-Received: by 2002:a9d:3d76:: with SMTP id a109mr14975357otc.233.1573892466111; Sat, 16 Nov 2019 00:21:06 -0800 (PST) MIME-Version: 1.0 References: <20191114180303.66955-1-elver@google.com> <20191114195046.GP2865@paulmck-ThinkPad-P72> <20191114213303.GA237245@google.com> <20191114221559.GS2865@paulmck-ThinkPad-P72> <20191115164159.GU2865@paulmck-ThinkPad-P72> <20191115204321.GX2865@paulmck-ThinkPad-P72> In-Reply-To: <20191115204321.GX2865@paulmck-ThinkPad-P72> From: Marco Elver Date: Sat, 16 Nov 2019 09:20:54 +0100 Message-ID: Subject: Re: [PATCH v4 00/10] Add Kernel Concurrency Sanitizer (KCSAN) To: "Paul E. McKenney" Cc: LKMM Maintainers -- Akira Yokosawa , Alan Stern , Alexander Potapenko , Andrea Parri , Andrey Konovalov , Andy Lutomirski , Ard Biesheuvel , Arnd Bergmann , Boqun Feng , Borislav Petkov , Daniel Axtens , Daniel Lustig , Dave Hansen , David Howells , Dmitry Vyukov , "H. Peter Anvin" , Ingo Molnar , Jade Alglave , Joel Fernandes , Jonathan Corbet , Josh Poimboeuf , Luc Maranget , Mark Rutland , Nicholas Piggin , Peter Zijlstra , Thomas Gleixner , Will Deacon , Eric Dumazet , kasan-dev , linux-arch , "open list:DOCUMENTATION" , linux-efi@vger.kernel.org, Linux Kbuild mailing list , LKML , Linux Memory Management List , "the arch/x86 maintainers" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 15 Nov 2019 at 21:43, Paul E. McKenney wrote: > > On Fri, Nov 15, 2019 at 06:14:46PM +0100, Marco Elver wrote: > > On Fri, 15 Nov 2019 at 17:42, Paul E. McKenney wrote: > > > > > > On Fri, Nov 15, 2019 at 01:02:08PM +0100, Marco Elver wrote: > > > > On Thu, 14 Nov 2019 at 23:16, Paul E. McKenney wrote: > > > > > > > > > > On Thu, Nov 14, 2019 at 10:33:03PM +0100, Marco Elver wrote: > > > > > > On Thu, 14 Nov 2019, Paul E. McKenney wrote: > > > > > > > > > > > > > On Thu, Nov 14, 2019 at 07:02:53PM +0100, Marco Elver wrote: > > > > > > > > This is the patch-series for the Kernel Concurrency Sanitizer (KCSAN). > > > > > > > > KCSAN is a sampling watchpoint-based *data race detector*. More details > > > > > > > > are included in **Documentation/dev-tools/kcsan.rst**. This patch-series > > > > > > > > only enables KCSAN for x86, but we expect adding support for other > > > > > > > > architectures is relatively straightforward (we are aware of > > > > > > > > experimental ARM64 and POWER support). > > > > > > > > > > > > > > > > To gather early feedback, we announced KCSAN back in September, and have > > > > > > > > integrated the feedback where possible: > > > > > > > > http://lkml.kernel.org/r/CANpmjNPJ_bHjfLZCAPV23AXFfiPiyXXqqu72n6TgWzb2Gnu1eA@mail.gmail.com > > > > > > > > > > > > > > > > The current list of known upstream fixes for data races found by KCSAN > > > > > > > > can be found here: > > > > > > > > https://github.com/google/ktsan/wiki/KCSAN#upstream-fixes-of-data-races-found-by-kcsan > > > > > > > > > > > > > > > > We want to point out and acknowledge the work surrounding the LKMM, > > > > > > > > including several articles that motivate why data races are dangerous > > > > > > > > [1, 2], justifying a data race detector such as KCSAN. > > > > > > > > > > > > > > > > [1] https://lwn.net/Articles/793253/ > > > > > > > > [2] https://lwn.net/Articles/799218/ > > > > > > > > > > > > > > I queued this and ran a quick rcutorture on it, which completed > > > > > > > successfully with quite a few reports. > > > > > > > > > > > > Great. Many thanks for queuing this in -rcu. And regarding merge window > > > > > > you mentioned, we're fine with your assumption to targeting the next > > > > > > (v5.6) merge window. > > > > > > > > > > > > I've just had a look at linux-next to check what a future rebase > > > > > > requires: > > > > > > > > > > > > - There is a change in lib/Kconfig.debug and moving KCSAN to the > > > > > > "Generic Kernel Debugging Instruments" section seems appropriate. > > > > > > - bitops-instrumented.h was removed and split into 3 files, and needs > > > > > > re-inserting the instrumentation into the right places. > > > > > > > > > > > > Otherwise there are no issues. Let me know what you recommend. > > > > > > > > > > Sounds good! > > > > > > > > > > I will be rebasing onto v5.5-rc1 shortly after it comes out. My usual > > > > > approach is to fix any conflicts during that rebasing operation. > > > > > Does that make sense, or would you prefer to send me a rebased stack at > > > > > that point? Either way is fine for me. > > > > > > > > That's fine with me, thanks! To avoid too much additional churn on > > > > your end, I just replied to the bitops patch with a version that will > > > > apply with the change to bitops-instrumented infrastructure. > > > > > > My first thought was to replace 8/10 of the previous version of your > > > patch in -rcu (047ca266cfab "asm-generic, kcsan: Add KCSAN instrumentation > > > for bitops"), but this does not apply. So I am guessing that I instead > > > do this substitution when a rebase onto -rc1.. > > > > > > Except... > > > > > > > Also considering the merge window, we had a discussion and there are > > > > some arguments for targeting the v5.5 merge window: > > > > - we'd unblock ARM and POWER ports; > > > > - we'd unblock people wanting to use the data_race macro; > > > > - we'd unblock syzbot just tracking upstream; > > > > Unless there are strong reasons to not target v5.5, I leave it to you > > > > if you think it's appropriate. > > > > > > My normal process is to send the pull request shortly after -rc5 comes > > > out, but you do call out some benefits of getting it in sooner, so... > > > > > > What I will do is to rebase your series onto (say) -rc7, test it, and > > > see about an RFC pull request. > > > > > > One possible complication is the new 8/10 patch. But maybe it will > > > apply against -rc7? > > > > > > Another possible complication is this: > > > > > > scripts/kconfig/conf --syncconfig Kconfig > > > * > > > * Restart config... > > > * > > > * > > > * KCSAN: watchpoint-based dynamic data race detector > > > * > > > KCSAN: watchpoint-based dynamic data race detector (KCSAN) [N/y/?] (NEW) > > > > > > Might be OK in this case because it is quite obvious what it is doing. > > > (Avoiding pain from this is the reason that CONFIG_RCU_EXPERT exists.) > > > > > > But I will just mention this in the pull request. > > > > > > If there is a -rc8, there is of course a higher probability of making it > > > into the next merge window. > > > > > > Fair enough? > > > > Totally fine with that, sounds like a good plan, thanks! > > > > If it helps, in theory we can also drop and delay the bitops > > instrumentation patch until the new bitops instrumentation > > infrastructure is in 5.5-rc1. There won't be any false positives if > > this is missing, we might just miss a few data races until we have it. > > That sounds advisable for an attempt to hit this coming merge window. > > So just to make sure I understand, I drop 8/10 and keep the rest during > a rebase to 5.4-rc7, correct? Yes, that's right. Many thanks, -- Marco From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marco Elver Subject: Re: [PATCH v4 00/10] Add Kernel Concurrency Sanitizer (KCSAN) Date: Sat, 16 Nov 2019 09:20:54 +0100 Message-ID: References: <20191114180303.66955-1-elver@google.com> <20191114195046.GP2865@paulmck-ThinkPad-P72> <20191114213303.GA237245@google.com> <20191114221559.GS2865@paulmck-ThinkPad-P72> <20191115164159.GU2865@paulmck-ThinkPad-P72> <20191115204321.GX2865@paulmck-ThinkPad-P72> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <20191115204321.GX2865@paulmck-ThinkPad-P72> Sender: linux-kernel-owner@vger.kernel.org To: "Paul E. McKenney" Cc: LKMM Maintainers -- Akira Yokosawa , Alan Stern , Alexander Potapenko , Andrea Parri , Andrey Konovalov , Andy Lutomirski , Ard Biesheuvel , Arnd Bergmann , Boqun Feng , Borislav Petkov , Daniel Axtens , Daniel Lustig , Dave Hansen , David Howells , Dmitry Vyukov , "H. Peter Anvin" , Ingo Molnar , Jade Alglave , Joel Fernandes , Jonathan Corbet List-Id: linux-arch.vger.kernel.org On Fri, 15 Nov 2019 at 21:43, Paul E. McKenney wrote: > > On Fri, Nov 15, 2019 at 06:14:46PM +0100, Marco Elver wrote: > > On Fri, 15 Nov 2019 at 17:42, Paul E. McKenney wrote: > > > > > > On Fri, Nov 15, 2019 at 01:02:08PM +0100, Marco Elver wrote: > > > > On Thu, 14 Nov 2019 at 23:16, Paul E. McKenney wrote: > > > > > > > > > > On Thu, Nov 14, 2019 at 10:33:03PM +0100, Marco Elver wrote: > > > > > > On Thu, 14 Nov 2019, Paul E. McKenney wrote: > > > > > > > > > > > > > On Thu, Nov 14, 2019 at 07:02:53PM +0100, Marco Elver wrote: > > > > > > > > This is the patch-series for the Kernel Concurrency Sanitizer (KCSAN). > > > > > > > > KCSAN is a sampling watchpoint-based *data race detector*. More details > > > > > > > > are included in **Documentation/dev-tools/kcsan.rst**. This patch-series > > > > > > > > only enables KCSAN for x86, but we expect adding support for other > > > > > > > > architectures is relatively straightforward (we are aware of > > > > > > > > experimental ARM64 and POWER support). > > > > > > > > > > > > > > > > To gather early feedback, we announced KCSAN back in September, and have > > > > > > > > integrated the feedback where possible: > > > > > > > > http://lkml.kernel.org/r/CANpmjNPJ_bHjfLZCAPV23AXFfiPiyXXqqu72n6TgWzb2Gnu1eA@mail.gmail.com > > > > > > > > > > > > > > > > The current list of known upstream fixes for data races found by KCSAN > > > > > > > > can be found here: > > > > > > > > https://github.com/google/ktsan/wiki/KCSAN#upstream-fixes-of-data-races-found-by-kcsan > > > > > > > > > > > > > > > > We want to point out and acknowledge the work surrounding the LKMM, > > > > > > > > including several articles that motivate why data races are dangerous > > > > > > > > [1, 2], justifying a data race detector such as KCSAN. > > > > > > > > > > > > > > > > [1] https://lwn.net/Articles/793253/ > > > > > > > > [2] https://lwn.net/Articles/799218/ > > > > > > > > > > > > > > I queued this and ran a quick rcutorture on it, which completed > > > > > > > successfully with quite a few reports. > > > > > > > > > > > > Great. Many thanks for queuing this in -rcu. And regarding merge window > > > > > > you mentioned, we're fine with your assumption to targeting the next > > > > > > (v5.6) merge window. > > > > > > > > > > > > I've just had a look at linux-next to check what a future rebase > > > > > > requires: > > > > > > > > > > > > - There is a change in lib/Kconfig.debug and moving KCSAN to the > > > > > > "Generic Kernel Debugging Instruments" section seems appropriate. > > > > > > - bitops-instrumented.h was removed and split into 3 files, and needs > > > > > > re-inserting the instrumentation into the right places. > > > > > > > > > > > > Otherwise there are no issues. Let me know what you recommend. > > > > > > > > > > Sounds good! > > > > > > > > > > I will be rebasing onto v5.5-rc1 shortly after it comes out. My usual > > > > > approach is to fix any conflicts during that rebasing operation. > > > > > Does that make sense, or would you prefer to send me a rebased stack at > > > > > that point? Either way is fine for me. > > > > > > > > That's fine with me, thanks! To avoid too much additional churn on > > > > your end, I just replied to the bitops patch with a version that will > > > > apply with the change to bitops-instrumented infrastructure. > > > > > > My first thought was to replace 8/10 of the previous version of your > > > patch in -rcu (047ca266cfab "asm-generic, kcsan: Add KCSAN instrumentation > > > for bitops"), but this does not apply. So I am guessing that I instead > > > do this substitution when a rebase onto -rc1.. > > > > > > Except... > > > > > > > Also considering the merge window, we had a discussion and there are > > > > some arguments for targeting the v5.5 merge window: > > > > - we'd unblock ARM and POWER ports; > > > > - we'd unblock people wanting to use the data_race macro; > > > > - we'd unblock syzbot just tracking upstream; > > > > Unless there are strong reasons to not target v5.5, I leave it to you > > > > if you think it's appropriate. > > > > > > My normal process is to send the pull request shortly after -rc5 comes > > > out, but you do call out some benefits of getting it in sooner, so... > > > > > > What I will do is to rebase your series onto (say) -rc7, test it, and > > > see about an RFC pull request. > > > > > > One possible complication is the new 8/10 patch. But maybe it will > > > apply against -rc7? > > > > > > Another possible complication is this: > > > > > > scripts/kconfig/conf --syncconfig Kconfig > > > * > > > * Restart config... > > > * > > > * > > > * KCSAN: watchpoint-based dynamic data race detector > > > * > > > KCSAN: watchpoint-based dynamic data race detector (KCSAN) [N/y/?] (NEW) > > > > > > Might be OK in this case because it is quite obvious what it is doing. > > > (Avoiding pain from this is the reason that CONFIG_RCU_EXPERT exists.) > > > > > > But I will just mention this in the pull request. > > > > > > If there is a -rc8, there is of course a higher probability of making it > > > into the next merge window. > > > > > > Fair enough? > > > > Totally fine with that, sounds like a good plan, thanks! > > > > If it helps, in theory we can also drop and delay the bitops > > instrumentation patch until the new bitops instrumentation > > infrastructure is in 5.5-rc1. There won't be any false positives if > > this is missing, we might just miss a few data races until we have it. > > That sounds advisable for an attempt to hit this coming merge window. > > So just to make sure I understand, I drop 8/10 and keep the rest during > a rebase to 5.4-rc7, correct? Yes, that's right. Many thanks, -- Marco From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11C03C43141 for ; Sat, 16 Nov 2019 08:21:10 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8C29220730 for ; Sat, 16 Nov 2019 08:21:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="XWnuclkq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8C29220730 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C1F046B0003; Sat, 16 Nov 2019 03:21:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BCF186B0006; Sat, 16 Nov 2019 03:21:08 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ABE576B0007; Sat, 16 Nov 2019 03:21:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0224.hostedemail.com [216.40.44.224]) by kanga.kvack.org (Postfix) with ESMTP id 95C636B0003 for ; Sat, 16 Nov 2019 03:21:08 -0500 (EST) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with SMTP id 2F383181AEF10 for ; Sat, 16 Nov 2019 08:21:08 +0000 (UTC) X-FDA: 76161445416.03.coast62_440a07e773510 X-HE-Tag: coast62_440a07e773510 X-Filterd-Recvd-Size: 10195 Received: from mail-ot1-f67.google.com (mail-ot1-f67.google.com [209.85.210.67]) by imf45.hostedemail.com (Postfix) with ESMTP for ; Sat, 16 Nov 2019 08:21:07 +0000 (UTC) Received: by mail-ot1-f67.google.com with SMTP id l14so10104831oti.10 for ; Sat, 16 Nov 2019 00:21:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=IAbPck/tyWYpcH6q1DqU0wF9VrcqMWHjsvfsasMdJQ8=; b=XWnuclkqZMItq+/ksJ8Y1qa9/9oIF2fdvK7zku42Z8ODKYKzpWGUzZ/8O3BaVjf7Ag P71ZJ18PYDh/S+GcXJv7JbUHBfrVxcoQ8Tvy3/rDGiRsih1j0Zfw3p0aX5sUwbDmnNzp UJbeoNYdVfNU8lrJD/bixaoQ7gvdzCi0y77rY6eMix67aCD4LLAxKMFtrjIBZplbOSLa whiths2ljXaRVaJ66Ty6f/l0eqANuJrB5x+g554vTxKefToWIvkl2VMJofQLrWCYVNFN uMyJ4CtcCuhbdCcrnripCXXi0U9CRkogJhOh3chGjPKJVPuRp3IpvYuKiS5dSot+QvZ1 UFSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=IAbPck/tyWYpcH6q1DqU0wF9VrcqMWHjsvfsasMdJQ8=; b=VQCh6SfMxqyelH2d9HQIZHarK/0DfNp5l8huHZ6znMo7fTAr+xdNyJTL5IeXnpELXn 1iQCMtRQWtK2B7zuFbdopJqGYZxaaHd/qtgFoKCu36LJV6wedts9DvYNDwzivZTmqqAD +OMhO3UbTZFCoFZt10sngqub4h316hzBMv3aY3JAQrwtnUiqgqc3VqkRhOE6Y8VVwCSN FluF0T41REzx+ZbF2rFat1fU6fgLkP+XvLLfKmX+5WN/6lqzFwHNBOPpc12ZDUtFxVJQ +uZ4TVqqGWm+Y5cGj47NzjGRUVJMBC1cSk5n6nfI3z0gdzm3+hLz03T6ohO/oG6dOblM Qmyw== X-Gm-Message-State: APjAAAX5GXSocuhiDNos+6V1fHal4r2Bg6o+v8L26CWNxyYALNWHuZLx FB54Gyj3tDdWAeRn9IMagyU2Q1wCXtrTs9BzCaTfqw== X-Google-Smtp-Source: APXvYqyFoD1MoXKYzcJ0ETjr8RD5raPWnHWPSZdYf70aViyP/iAqqE28rDX/p+nlWotCJAjaCdGBcwat07yGzdHKecY= X-Received: by 2002:a9d:3d76:: with SMTP id a109mr14975357otc.233.1573892466111; Sat, 16 Nov 2019 00:21:06 -0800 (PST) MIME-Version: 1.0 References: <20191114180303.66955-1-elver@google.com> <20191114195046.GP2865@paulmck-ThinkPad-P72> <20191114213303.GA237245@google.com> <20191114221559.GS2865@paulmck-ThinkPad-P72> <20191115164159.GU2865@paulmck-ThinkPad-P72> <20191115204321.GX2865@paulmck-ThinkPad-P72> In-Reply-To: <20191115204321.GX2865@paulmck-ThinkPad-P72> From: Marco Elver Date: Sat, 16 Nov 2019 09:20:54 +0100 Message-ID: Subject: Re: [PATCH v4 00/10] Add Kernel Concurrency Sanitizer (KCSAN) To: "Paul E. McKenney" Cc: LKMM Maintainers -- Akira Yokosawa , Alan Stern , Alexander Potapenko , Andrea Parri , Andrey Konovalov , Andy Lutomirski , Ard Biesheuvel , Arnd Bergmann , Boqun Feng , Borislav Petkov , Daniel Axtens , Daniel Lustig , Dave Hansen , David Howells , Dmitry Vyukov , "H. Peter Anvin" , Ingo Molnar , Jade Alglave , Joel Fernandes , Jonathan Corbet , Josh Poimboeuf , Luc Maranget , Mark Rutland , Nicholas Piggin , Peter Zijlstra , Thomas Gleixner , Will Deacon , Eric Dumazet , kasan-dev , linux-arch , "open list:DOCUMENTATION" , linux-efi@vger.kernel.org, Linux Kbuild mailing list , LKML , Linux Memory Management List , "the arch/x86 maintainers" Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 15 Nov 2019 at 21:43, Paul E. McKenney wrote: > > On Fri, Nov 15, 2019 at 06:14:46PM +0100, Marco Elver wrote: > > On Fri, 15 Nov 2019 at 17:42, Paul E. McKenney wrote: > > > > > > On Fri, Nov 15, 2019 at 01:02:08PM +0100, Marco Elver wrote: > > > > On Thu, 14 Nov 2019 at 23:16, Paul E. McKenney wrote: > > > > > > > > > > On Thu, Nov 14, 2019 at 10:33:03PM +0100, Marco Elver wrote: > > > > > > On Thu, 14 Nov 2019, Paul E. McKenney wrote: > > > > > > > > > > > > > On Thu, Nov 14, 2019 at 07:02:53PM +0100, Marco Elver wrote: > > > > > > > > This is the patch-series for the Kernel Concurrency Sanitizer (KCSAN). > > > > > > > > KCSAN is a sampling watchpoint-based *data race detector*. More details > > > > > > > > are included in **Documentation/dev-tools/kcsan.rst**. This patch-series > > > > > > > > only enables KCSAN for x86, but we expect adding support for other > > > > > > > > architectures is relatively straightforward (we are aware of > > > > > > > > experimental ARM64 and POWER support). > > > > > > > > > > > > > > > > To gather early feedback, we announced KCSAN back in September, and have > > > > > > > > integrated the feedback where possible: > > > > > > > > http://lkml.kernel.org/r/CANpmjNPJ_bHjfLZCAPV23AXFfiPiyXXqqu72n6TgWzb2Gnu1eA@mail.gmail.com > > > > > > > > > > > > > > > > The current list of known upstream fixes for data races found by KCSAN > > > > > > > > can be found here: > > > > > > > > https://github.com/google/ktsan/wiki/KCSAN#upstream-fixes-of-data-races-found-by-kcsan > > > > > > > > > > > > > > > > We want to point out and acknowledge the work surrounding the LKMM, > > > > > > > > including several articles that motivate why data races are dangerous > > > > > > > > [1, 2], justifying a data race detector such as KCSAN. > > > > > > > > > > > > > > > > [1] https://lwn.net/Articles/793253/ > > > > > > > > [2] https://lwn.net/Articles/799218/ > > > > > > > > > > > > > > I queued this and ran a quick rcutorture on it, which completed > > > > > > > successfully with quite a few reports. > > > > > > > > > > > > Great. Many thanks for queuing this in -rcu. And regarding merge window > > > > > > you mentioned, we're fine with your assumption to targeting the next > > > > > > (v5.6) merge window. > > > > > > > > > > > > I've just had a look at linux-next to check what a future rebase > > > > > > requires: > > > > > > > > > > > > - There is a change in lib/Kconfig.debug and moving KCSAN to the > > > > > > "Generic Kernel Debugging Instruments" section seems appropriate. > > > > > > - bitops-instrumented.h was removed and split into 3 files, and needs > > > > > > re-inserting the instrumentation into the right places. > > > > > > > > > > > > Otherwise there are no issues. Let me know what you recommend. > > > > > > > > > > Sounds good! > > > > > > > > > > I will be rebasing onto v5.5-rc1 shortly after it comes out. My usual > > > > > approach is to fix any conflicts during that rebasing operation. > > > > > Does that make sense, or would you prefer to send me a rebased stack at > > > > > that point? Either way is fine for me. > > > > > > > > That's fine with me, thanks! To avoid too much additional churn on > > > > your end, I just replied to the bitops patch with a version that will > > > > apply with the change to bitops-instrumented infrastructure. > > > > > > My first thought was to replace 8/10 of the previous version of your > > > patch in -rcu (047ca266cfab "asm-generic, kcsan: Add KCSAN instrumentation > > > for bitops"), but this does not apply. So I am guessing that I instead > > > do this substitution when a rebase onto -rc1.. > > > > > > Except... > > > > > > > Also considering the merge window, we had a discussion and there are > > > > some arguments for targeting the v5.5 merge window: > > > > - we'd unblock ARM and POWER ports; > > > > - we'd unblock people wanting to use the data_race macro; > > > > - we'd unblock syzbot just tracking upstream; > > > > Unless there are strong reasons to not target v5.5, I leave it to you > > > > if you think it's appropriate. > > > > > > My normal process is to send the pull request shortly after -rc5 comes > > > out, but you do call out some benefits of getting it in sooner, so... > > > > > > What I will do is to rebase your series onto (say) -rc7, test it, and > > > see about an RFC pull request. > > > > > > One possible complication is the new 8/10 patch. But maybe it will > > > apply against -rc7? > > > > > > Another possible complication is this: > > > > > > scripts/kconfig/conf --syncconfig Kconfig > > > * > > > * Restart config... > > > * > > > * > > > * KCSAN: watchpoint-based dynamic data race detector > > > * > > > KCSAN: watchpoint-based dynamic data race detector (KCSAN) [N/y/?] (NEW) > > > > > > Might be OK in this case because it is quite obvious what it is doing. > > > (Avoiding pain from this is the reason that CONFIG_RCU_EXPERT exists.) > > > > > > But I will just mention this in the pull request. > > > > > > If there is a -rc8, there is of course a higher probability of making it > > > into the next merge window. > > > > > > Fair enough? > > > > Totally fine with that, sounds like a good plan, thanks! > > > > If it helps, in theory we can also drop and delay the bitops > > instrumentation patch until the new bitops instrumentation > > infrastructure is in 5.5-rc1. There won't be any false positives if > > this is missing, we might just miss a few data races until we have it. > > That sounds advisable for an attempt to hit this coming merge window. > > So just to make sure I understand, I drop 8/10 and keep the rest during > a rebase to 5.4-rc7, correct? Yes, that's right. Many thanks, -- Marco