From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 092BCC11F66 for ; Wed, 14 Jul 2021 17:54:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E270361042 for ; Wed, 14 Jul 2021 17:54:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239803AbhGNR5t (ORCPT ); Wed, 14 Jul 2021 13:57:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52400 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229738AbhGNR5s (ORCPT ); Wed, 14 Jul 2021 13:57:48 -0400 Received: from mail-ot1-x32f.google.com (mail-ot1-x32f.google.com [IPv6:2607:f8b0:4864:20::32f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 12EB2C06175F for ; Wed, 14 Jul 2021 10:54:56 -0700 (PDT) Received: by mail-ot1-x32f.google.com with SMTP id f12-20020a056830204cb029048bcf4c6bd9so3363165otp.8 for ; Wed, 14 Jul 2021 10:54:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=jrD1pQ3OBKYY3c2yMtsYHqlgwFHdU07pE4enP3uNpXI=; b=mXM94q6eWDzYOpyvImS9eQ8zAI6VTBDihi0v+PaVTA5xcwni6yfsr0CBel81joQIRn Q3hUzE22kWqcLiDc4JlAEcGtcdb5S9kPy+j31Gp1WtEr0WAmWNx2HPDqIb2gSkqQHuK5 Der90yY3k7Zkx0r9eOiJHqODovoA9o0IazPSJDb8s8GWIovenhp/mW/sgXWbzTuULAgf sCMU8qPGcJRE56C/FqFhbq75MZtp+k6tDxx3W/qsykU4t2PJxQ04XFnmb+Zt5QcJt6ZN CfEAm8JTEF3euTOoMi7Ze9GgckUYgwNjdLDqCfNwYl3N2KXoiMIztLE2X9pYi3v0gTOX Rjww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jrD1pQ3OBKYY3c2yMtsYHqlgwFHdU07pE4enP3uNpXI=; b=mkccA5p5gdGbwTIgRcCgZQ/gCoGfVFnCH+6Nkq0VunOGOdAx/ZAIt94t/AqoOp/jzF oRT2c7Kj6TSmGfYbZhdYdYL1pXDYVWzER7pXCAqjbKcRdoMWbLppEz0QRYImwo61g56p +E+33eXQiI0l0ibQw+rQarbQMkRJtrIciIoHJqDi2NDkW4+d39ovc54EesfXnlvvfD8c 6lKIcokkGJEgw2ri+O8PvAerL2nT4UhlNwPlw+bp/IaK/celeV02YtcrJ7lzJqSbW4OA mMfFQXlCRFGjqgryGznKhekJy7EjvyRG6oRDJQ/rExQWoEdz+8/MMtUesangLImFR7Jz +0cQ== X-Gm-Message-State: AOAM531pk1u2yOFdk+azGNztKdgdAVXuf0M1WOP5t1LGfZlNXGALTlvF BpspPg6o0k5SsH9uQW5cfTV13xZ+kJouphOf1em4JQ== X-Google-Smtp-Source: ABdhPJyNOpkHIq1v8InV3LUaESTWKz/ywm13RR9OPuJloAv8GjTzcdQMHnmKgIa8CcW2pyfhzJ6x9nq5gr20/dRpi/Q= X-Received: by 2002:a9d:650e:: with SMTP id i14mr9109289otl.233.1626285295243; Wed, 14 Jul 2021 10:54:55 -0700 (PDT) MIME-Version: 1.0 References: <20210714082145.2709233-1-elver@google.com> <20210714173755.1083-1-yzhong@purestorage.com> In-Reply-To: <20210714173755.1083-1-yzhong@purestorage.com> From: Marco Elver Date: Wed, 14 Jul 2021 19:54:34 +0200 Message-ID: Subject: Re: [PATCH mm v2] kfence: show cpu and timestamp in alloc/free info To: Yuanyuan Zhong Cc: akpm@linux-foundation.org, corbet@lwn.net, dvyukov@google.com, glider@google.com, joern@purestorage.com, kasan-dev@googlegroups.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 14 Jul 2021 at 19:38, 'Yuanyuan Zhong' via kasan-dev wrote: > > + /* Timestamp matches printk timestamp format. */ > > + seq_con_printf(seq, "%s by task %d on cpu %d at %lu.%06lus:\n", > > + show_alloc ? "allocated" : "freed", meta->alloc_track.pid, > > + meta->alloc_track.cpu, (unsigned long)ts_sec, rem_nsec / 1000); > > s/meta->alloc_track\./track->/ Thanks for spotting this! v3: https://lkml.kernel.org/r/20210714175312.2947941-1-elver@google.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 086CBC07E9C for ; Wed, 14 Jul 2021 17:54:58 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 816DE61042 for ; Wed, 14 Jul 2021 17:54:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 816DE61042 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id CB8146B007E; Wed, 14 Jul 2021 13:54:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C8F146B0080; Wed, 14 Jul 2021 13:54:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B57BB6B0081; Wed, 14 Jul 2021 13:54:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0187.hostedemail.com [216.40.44.187]) by kanga.kvack.org (Postfix) with ESMTP id 90F2A6B007E for ; Wed, 14 Jul 2021 13:54:57 -0400 (EDT) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 8684A8245578 for ; Wed, 14 Jul 2021 17:54:56 +0000 (UTC) X-FDA: 78361944192.02.6027695 Received: from mail-ot1-f44.google.com (mail-ot1-f44.google.com [209.85.210.44]) by imf11.hostedemail.com (Postfix) with ESMTP id 45CB9F0000BA for ; Wed, 14 Jul 2021 17:54:56 +0000 (UTC) Received: by mail-ot1-f44.google.com with SMTP id f12-20020a056830204cb029048bcf4c6bd9so3363167otp.8 for ; Wed, 14 Jul 2021 10:54:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=jrD1pQ3OBKYY3c2yMtsYHqlgwFHdU07pE4enP3uNpXI=; b=mXM94q6eWDzYOpyvImS9eQ8zAI6VTBDihi0v+PaVTA5xcwni6yfsr0CBel81joQIRn Q3hUzE22kWqcLiDc4JlAEcGtcdb5S9kPy+j31Gp1WtEr0WAmWNx2HPDqIb2gSkqQHuK5 Der90yY3k7Zkx0r9eOiJHqODovoA9o0IazPSJDb8s8GWIovenhp/mW/sgXWbzTuULAgf sCMU8qPGcJRE56C/FqFhbq75MZtp+k6tDxx3W/qsykU4t2PJxQ04XFnmb+Zt5QcJt6ZN CfEAm8JTEF3euTOoMi7Ze9GgckUYgwNjdLDqCfNwYl3N2KXoiMIztLE2X9pYi3v0gTOX Rjww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jrD1pQ3OBKYY3c2yMtsYHqlgwFHdU07pE4enP3uNpXI=; b=YgU6BYP8LyfaBu9rd2Kp90QVdeL9aWe3QeqeAZ+PflJryhfUuZrUE2iNhcO4FzCiNc LqTG0er4e6Y32/ay1F8mcKQu3sa0CB/XNsQPUQDt5Ji4h8IfpxYO7iooNbCcSixZ5jY+ t7NJ0FbeM7oYWucjNzZzm+RFTlBaycPRxaKVO5oUhdKCTFDTClFdJcq4YXgSgAkj++5S pfLPR7sXx4crUgb+pf8aYQS8Fybhx6O5OT+FxyKXXLxs7/cc7E0PiMZMYqmYZKi0t0wL o7t1d2h8599T2CZKM2jd6IgYbHhp2yqlkQyJEOWpHLZ/7vU0zZBfC+zbzn3Sqr4gV8ot ZCmQ== X-Gm-Message-State: AOAM531l35DVEd6hbaNMWvXvKo6NI9S1CpkyXhorFViKsWmd611Ytw/Y 6A7aUwLTov+LGrxXR1Qlg5jqp3k8hZYWeZk9ggS3Jw== X-Google-Smtp-Source: ABdhPJyNOpkHIq1v8InV3LUaESTWKz/ywm13RR9OPuJloAv8GjTzcdQMHnmKgIa8CcW2pyfhzJ6x9nq5gr20/dRpi/Q= X-Received: by 2002:a9d:650e:: with SMTP id i14mr9109289otl.233.1626285295243; Wed, 14 Jul 2021 10:54:55 -0700 (PDT) MIME-Version: 1.0 References: <20210714082145.2709233-1-elver@google.com> <20210714173755.1083-1-yzhong@purestorage.com> In-Reply-To: <20210714173755.1083-1-yzhong@purestorage.com> From: Marco Elver Date: Wed, 14 Jul 2021 19:54:34 +0200 Message-ID: Subject: Re: [PATCH mm v2] kfence: show cpu and timestamp in alloc/free info To: Yuanyuan Zhong Cc: akpm@linux-foundation.org, corbet@lwn.net, dvyukov@google.com, glider@google.com, joern@purestorage.com, kasan-dev@googlegroups.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=google.com header.s=20161025 header.b=mXM94q6e; spf=pass (imf11.hostedemail.com: domain of elver@google.com designates 209.85.210.44 as permitted sender) smtp.mailfrom=elver@google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspamd-Server: rspam05 X-Stat-Signature: omhsprt4kmntb4yt41uzycmg4gucx786 X-Rspamd-Queue-Id: 45CB9F0000BA X-HE-Tag: 1626285296-488899 X-Bogosity: Ham, tests=bogofilter, spamicity=0.395416, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 14 Jul 2021 at 19:38, 'Yuanyuan Zhong' via kasan-dev wrote: > > + /* Timestamp matches printk timestamp format. */ > > + seq_con_printf(seq, "%s by task %d on cpu %d at %lu.%06lus:\n", > > + show_alloc ? "allocated" : "freed", meta->alloc_track.pid, > > + meta->alloc_track.cpu, (unsigned long)ts_sec, rem_nsec / 1000); > > s/meta->alloc_track\./track->/ Thanks for spotting this! v3: https://lkml.kernel.org/r/20210714175312.2947941-1-elver@google.com