From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBFFDC433EF for ; Thu, 2 Dec 2021 10:58:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1357081AbhLBLCA (ORCPT ); Thu, 2 Dec 2021 06:02:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44326 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1356693AbhLBLB7 (ORCPT ); Thu, 2 Dec 2021 06:01:59 -0500 Received: from mail-oo1-xc2e.google.com (mail-oo1-xc2e.google.com [IPv6:2607:f8b0:4864:20::c2e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A73CDC06174A for ; Thu, 2 Dec 2021 02:58:37 -0800 (PST) Received: by mail-oo1-xc2e.google.com with SMTP id p2-20020a4adfc2000000b002c2676904fdso8735890ood.13 for ; Thu, 02 Dec 2021 02:58:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=IzqbKmhzTEjnI7ZTKD5CYs3ONkw0vgvO+4qQMNKWOhs=; b=jBAsyWHHtQdvdVwofFUKLl/vEvVJTq5ZKgdda+6KDlneA10k5qh543jBb7XRJB7zwH GDkgVoc1NgPTdGPxq5kGEPgjiyo6474g2dWFaiZvIv3RELjH+sl7cvBc0wNr2Io7gx4r TL1CljXVKP4lkmYZVs6qSk++UV4W09Nd3kzkeP0edvpDSlaFudb7WjujxQ6EfyB8HtZt LjVzXVyCIOOu2LUY1yoStp+YcWOPe8yFGWEQ1wI6U2fZGBRMlG5TwEBlzfDmwgDgOWs0 yvZuXZ2cZnUNX10CjQpmCoKO9hUQHdyyhexybMfdEozrJSX0fNByluuAk+/F+osgP7Fb /3XA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=IzqbKmhzTEjnI7ZTKD5CYs3ONkw0vgvO+4qQMNKWOhs=; b=kn+TsF7wjZabG3WND6fXDiYMYJUostfDA7MiCPiIU8XGIjbEVTNP0h6kwnHhnscKdQ PfiYvpUjpJzimf1g3XmMGptp9vSZETyM5FJyRR4y9D+BbZ/G9j+q6WYPDyfB6H0pditq LuyTqKswKhlIj/vsw8rOxDtuxkHH8TG/UDa9mOYpWwF58nXCYa4qf2Dcrlt2PPXvwvNr v3nGWcMVOi2U00e6CtNUFQkzgMENOXVKrXFIgHMOWIAQ5xxl8eBxNR903+2oHJtsWuC7 o0LlJHEhqqjMoUuM4YFT0lllBDJw25J66LkUhq3CUh4Utz3mytGkA0NCdt0Shlj/V8GI G2mw== X-Gm-Message-State: AOAM532gHrlfWxHtcxnkziKpF6BOyFSNcXzFCIG5sRXmZ1bpXXoO1z4g KN2+9U+4AGH5UfnNlz4Wjel+XT0NBMeEphPfSctE2w== X-Google-Smtp-Source: ABdhPJy0SYfwgINWHWi/WuELADe0lbasBO4rFHdE66HRkYYEYqLp965NMbMU98OEeGl+lXo3NMeRuBkV89kTsnLtDwk= X-Received: by 2002:a4a:cf12:: with SMTP id l18mr8131443oos.25.1638442716865; Thu, 02 Dec 2021 02:58:36 -0800 (PST) MIME-Version: 1.0 References: <20211129145732.27000-1-wangkefeng.wang@huawei.com> <811af0bc-0c99-37f6-a39a-095418b10661@huawei.com> In-Reply-To: From: Marco Elver Date: Thu, 2 Dec 2021 11:58:20 +0100 Message-ID: Subject: Re: [PATCH v2] arm64: Enable KCSAN To: Kefeng Wang Cc: Mark Rutland , Catalin Marinas , Will Deacon , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, joey.gouly@arm.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2 Dec 2021 at 11:45, Kefeng Wang wrote: [...] > >> for now and more explanation into changlog. > > So what I gather arm64's final select line may look like: > > > > select HAVE_ARCH_KCSAN if EXPERT && (CC_IS_GCC || CLANG_VERSION >= 120000) > Yes, that's what we want now. I think we have all the pieces sorted out, so hopefully you have everything you need to do v3. [...] > > I actually have a "fix" for the data race in rwsem_spin_on_owner, that > > also shows where the other racing access comes from... which reminds me: > > https://lkml.kernel.org/r/20211202101238.33546-1-elver@google.com > > There's a owner_on_cpu(), we could reuse it, That looks like a reasonable thing to do, but can't say if it is actually the right thing to do. You could suggest it in reply to the patch I just sent and see what people say. Thanks, -- Marco From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2E628C433EF for ; Thu, 2 Dec 2021 10:59:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=riqnu6D5Wu22bue601/k/kfjjwZhzRqVzP3mSab2SkE=; b=CkYFxGHp29ZdiR 671VY90XyYmllpG3rKBLwDiendHyUgk1wGlUEHMabv5o4dXnyE5onvGl7Cr8xr7IV2eob7JHerXRx VUIzqHuPJVoH+XdKhoO/y8Q2I9VA4h2MMHWGHrDScT/5mDNLsOyao2Xn/bltj6Uq9kflp5JnWuJR9 iJD/Dx00tiA1xKVuu8pdS0AEMLK8RUE9/SNP41xBQPtu7np7grWeMogJRO8Ib5oNpsqFr9B37Lmlm yaLl/icu36qci6GDnLDYWXQ+71dTBSnZdn3XoLcmqHbo6mc4N56setJngi+j9rLnUkGu/PiUMgynH O9W8juWGiANaupPQK/Vw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1msjnW-00BuAC-Fm; Thu, 02 Dec 2021 10:58:42 +0000 Received: from mail-oo1-xc2a.google.com ([2607:f8b0:4864:20::c2a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1msjnS-00Bu9A-7l for linux-arm-kernel@lists.infradead.org; Thu, 02 Dec 2021 10:58:39 +0000 Received: by mail-oo1-xc2a.google.com with SMTP id v19-20020a4a2453000000b002bb88bfb594so8739002oov.4 for ; Thu, 02 Dec 2021 02:58:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=IzqbKmhzTEjnI7ZTKD5CYs3ONkw0vgvO+4qQMNKWOhs=; b=jBAsyWHHtQdvdVwofFUKLl/vEvVJTq5ZKgdda+6KDlneA10k5qh543jBb7XRJB7zwH GDkgVoc1NgPTdGPxq5kGEPgjiyo6474g2dWFaiZvIv3RELjH+sl7cvBc0wNr2Io7gx4r TL1CljXVKP4lkmYZVs6qSk++UV4W09Nd3kzkeP0edvpDSlaFudb7WjujxQ6EfyB8HtZt LjVzXVyCIOOu2LUY1yoStp+YcWOPe8yFGWEQ1wI6U2fZGBRMlG5TwEBlzfDmwgDgOWs0 yvZuXZ2cZnUNX10CjQpmCoKO9hUQHdyyhexybMfdEozrJSX0fNByluuAk+/F+osgP7Fb /3XA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=IzqbKmhzTEjnI7ZTKD5CYs3ONkw0vgvO+4qQMNKWOhs=; b=e+DRUAu9tbPWeDOXO62cKJHa+ZyDGSfNuafCAMJD97sj19zi2G6RTPA3QEkPLkOVQI e1Zcx4IqnSTEMfqM6J36xr5KaGL1bXS3P+njHVgFaxly+8+oVLrIV2BT/wg2svtZcHqW uDW0yjUmiXHYjXCbJ12W8nfglQ9owdSzV9ijtMfF6mujUyyRKrdmF3/DQ/Nl1Ob7kKDE cTmnsCymA3AEcYf4h6V30Io1eQg9/T/vSLk5MIHh+YKytzyjGGcx48psI7I0uCOAC0vM bNGfMfUYXrKcndGS+cuDzUt6Qpxg0EyRpIhJ7nQbJlIqoF9JCvWasdgb/VGwbKLDXDfH /fmw== X-Gm-Message-State: AOAM533+4+s071Ou1kuyjM4JeYkW6SjPTvRNoIr0kiXKY89Y8m0+kKqW Wu7CIBkCetw6gpyOdpTNizQMdNjadneggWWHBX413w== X-Google-Smtp-Source: ABdhPJy0SYfwgINWHWi/WuELADe0lbasBO4rFHdE66HRkYYEYqLp965NMbMU98OEeGl+lXo3NMeRuBkV89kTsnLtDwk= X-Received: by 2002:a4a:cf12:: with SMTP id l18mr8131443oos.25.1638442716865; Thu, 02 Dec 2021 02:58:36 -0800 (PST) MIME-Version: 1.0 References: <20211129145732.27000-1-wangkefeng.wang@huawei.com> <811af0bc-0c99-37f6-a39a-095418b10661@huawei.com> In-Reply-To: From: Marco Elver Date: Thu, 2 Dec 2021 11:58:20 +0100 Message-ID: Subject: Re: [PATCH v2] arm64: Enable KCSAN To: Kefeng Wang Cc: Mark Rutland , Catalin Marinas , Will Deacon , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, joey.gouly@arm.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211202_025838_304742_AE618D30 X-CRM114-Status: GOOD ( 15.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 2 Dec 2021 at 11:45, Kefeng Wang wrote: [...] > >> for now and more explanation into changlog. > > So what I gather arm64's final select line may look like: > > > > select HAVE_ARCH_KCSAN if EXPERT && (CC_IS_GCC || CLANG_VERSION >= 120000) > Yes, that's what we want now. I think we have all the pieces sorted out, so hopefully you have everything you need to do v3. [...] > > I actually have a "fix" for the data race in rwsem_spin_on_owner, that > > also shows where the other racing access comes from... which reminds me: > > https://lkml.kernel.org/r/20211202101238.33546-1-elver@google.com > > There's a owner_on_cpu(), we could reuse it, That looks like a reasonable thing to do, but can't say if it is actually the right thing to do. You could suggest it in reply to the patch I just sent and see what people say. Thanks, -- Marco _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel