From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6D6BC43334 for ; Mon, 11 Jul 2022 16:27:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229774AbiGKQ1H (ORCPT ); Mon, 11 Jul 2022 12:27:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48572 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229635AbiGKQ1F (ORCPT ); Mon, 11 Jul 2022 12:27:05 -0400 Received: from mail-yw1-x1135.google.com (mail-yw1-x1135.google.com [IPv6:2607:f8b0:4864:20::1135]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1B6D97A526 for ; Mon, 11 Jul 2022 09:27:04 -0700 (PDT) Received: by mail-yw1-x1135.google.com with SMTP id 00721157ae682-31c8bb90d09so54545097b3.8 for ; Mon, 11 Jul 2022 09:27:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=MNiOG9VLTXfyIumAzSkdBTE4Ro/vczfTyGGlVgeFa4E=; b=TEsjKApZIm2eGVFXX6zjsDd7ABvdwUwkWxz0rYWMXDFUGDLUjnYfCbSEh8axaflEcf /XAr0TEV8rX+gPcA0+uljGw/dhOFVhYtwVaJfH/iJZzU8Zl9ttHoRuTvQCNKLVlL8au0 3zPqttuKlbdSz8ISmN8t7W1UOYA8ZrDRI5lCKPMSixLQXgh7Jn8yPSiKsQw08yTUdZL0 fLEnLlY1fQ4/ZXeGTZzytVnyhHPgk+fmSFRNyB3kHmNQtFfPUaq1d4vdLWJxwt9rEGwT oYED+Sgjnb2pGD++4nURXUCClA1/XfbK7RNX65wwZQAx6AsAxtCq6ItH03wFIU9LttK1 POzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=MNiOG9VLTXfyIumAzSkdBTE4Ro/vczfTyGGlVgeFa4E=; b=z9icRFGkx+6eXjNFQ7a+6bZQN8B9KItQgYG8nfQff4o6F8eqFr/qwbcI/Kd0bbGq/Q YdOyOo8AJ5DtU1BA4rfbZTkYa7YpHuqsZxGlYJ/2xMz528+Nb6ZSK4Cet61DHyWVgmTs YNuvXgkoUXPDlTCj9QPWOeX8mZHQmeZoxvSEW/HQPAqPrlCyyMxu/GG3RRr1BbuIpC/J 8ZG3xvHQvaTeFfKKawnaFZOu5XMmaAk4KXfGE/cj5XWKjayRhRxHi5TXFapsfRGcvlGa EAvpfcfg21hoDgky77o+cFypLPrzWEdzHw11+DNpClJ58Ph9I+X7YYmifSTlkiaZ0PlW JLcg== X-Gm-Message-State: AJIora9jIzFJykyRlLBfyIWhqvref6X6NCFFkhmTPBIcaFQ4tE2LVXCD X4YKYkifzQh3gaArHqUbg/2vbIAGfHe+X6zzp9yxFw== X-Google-Smtp-Source: AGRyM1vFc9Nz3PdQYWOkyhyxSAnFDy6tbKimAKMs5WJU/DJQWlYu903flN0tTaSuogpfrJrZGoq5RrujLcEOvlsW8HY= X-Received: by 2002:a81:98d:0:b0:31c:921c:9783 with SMTP id 135-20020a81098d000000b0031c921c9783mr20064789ywj.316.1657556823180; Mon, 11 Jul 2022 09:27:03 -0700 (PDT) MIME-Version: 1.0 References: <20220701142310.2188015-1-glider@google.com> <20220701142310.2188015-11-glider@google.com> In-Reply-To: <20220701142310.2188015-11-glider@google.com> From: Marco Elver Date: Mon, 11 Jul 2022 18:26:27 +0200 Message-ID: Subject: Re: [PATCH v4 10/45] libnvdimm/pfn_dev: increase MAX_STRUCT_PAGE_SIZE To: Alexander Potapenko Cc: Alexander Viro , Alexei Starovoitov , Andrew Morton , Andrey Konovalov , Andy Lutomirski , Arnd Bergmann , Borislav Petkov , Christoph Hellwig , Christoph Lameter , David Rientjes , Dmitry Vyukov , Eric Dumazet , Greg Kroah-Hartman , Herbert Xu , Ilya Leoshkevich , Ingo Molnar , Jens Axboe , Joonsoo Kim , Kees Cook , Mark Rutland , Matthew Wilcox , "Michael S. Tsirkin" , Pekka Enberg , Peter Zijlstra , Petr Mladek , Steven Rostedt , Thomas Gleixner , Vasily Gorbik , Vegard Nossum , Vlastimil Babka , kasan-dev@googlegroups.com, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 1 Jul 2022 at 16:23, Alexander Potapenko wrote: > > KMSAN adds extra metadata fields to struct page, so it does not fit into > 64 bytes anymore. Does this somehow cause extra space being used in all kernel configs? If not, it would be good to note this in the commit message. > Signed-off-by: Alexander Potapenko Reviewed-by: Marco Elver > --- > Link: https://linux-review.googlesource.com/id/I353796acc6a850bfd7bb342aa1b63e616fc614f1 > --- > drivers/nvdimm/nd.h | 2 +- > drivers/nvdimm/pfn_devs.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/nvdimm/nd.h b/drivers/nvdimm/nd.h > index ec5219680092d..85ca5b4da3cf3 100644 > --- a/drivers/nvdimm/nd.h > +++ b/drivers/nvdimm/nd.h > @@ -652,7 +652,7 @@ void devm_namespace_disable(struct device *dev, > struct nd_namespace_common *ndns); > #if IS_ENABLED(CONFIG_ND_CLAIM) > /* max struct page size independent of kernel config */ > -#define MAX_STRUCT_PAGE_SIZE 64 > +#define MAX_STRUCT_PAGE_SIZE 128 > int nvdimm_setup_pfn(struct nd_pfn *nd_pfn, struct dev_pagemap *pgmap); > #else > static inline int nvdimm_setup_pfn(struct nd_pfn *nd_pfn, > diff --git a/drivers/nvdimm/pfn_devs.c b/drivers/nvdimm/pfn_devs.c > index 0e92ab4b32833..61af072ac98f9 100644 > --- a/drivers/nvdimm/pfn_devs.c > +++ b/drivers/nvdimm/pfn_devs.c > @@ -787,7 +787,7 @@ static int nd_pfn_init(struct nd_pfn *nd_pfn) > * when populating the vmemmap. This *should* be equal to > * PMD_SIZE for most architectures. > * > - * Also make sure size of struct page is less than 64. We > + * Also make sure size of struct page is less than 128. We > * want to make sure we use large enough size here so that > * we don't have a dynamic reserve space depending on > * struct page size. But we also want to make sure we notice > -- > 2.37.0.rc0.161.g10f37bed90-goog >